[INFO] fetching crate gilrs-core 0.6.0... [INFO] building gilrs-core-0.6.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate gilrs-core 0.6.0 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate gilrs-core 0.6.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gilrs-core 0.6.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate gilrs-core 0.6.0 [INFO] tweaked toml for crates.io crate gilrs-core 0.6.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate crates.io crate gilrs-core 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded once_cell v1.20.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e2a15cac7ada8d52160e263084507f0e4a08d5c5cd25055664aed2679bb56b0 [INFO] running `Command { std: "docker" "start" "-a" "6e2a15cac7ada8d52160e263084507f0e4a08d5c5cd25055664aed2679bb56b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e2a15cac7ada8d52160e263084507f0e4a08d5c5cd25055664aed2679bb56b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e2a15cac7ada8d52160e263084507f0e4a08d5c5cd25055664aed2679bb56b0", kill_on_drop: false }` [INFO] [stdout] 6e2a15cac7ada8d52160e263084507f0e4a08d5c5cd25055664aed2679bb56b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 774efe1044fe8236740c370f8968263edd79045c3e129b7c7ca24affc2ab26cf [INFO] running `Command { std: "docker" "start" "-a" "774efe1044fe8236740c370f8968263edd79045c3e129b7c7ca24affc2ab26cf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling inotify-sys v0.1.5 [INFO] [stderr] Compiling inotify v0.11.0 [INFO] [stderr] Compiling gilrs-core v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/platform/linux/gamepad.rs:102:40 [INFO] [stdout] | [INFO] [stdout] 101 | let devpath = CString::new(gamepad_path.to_str().unwrap()).unwrap(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `devpath` calls a custom destructor [INFO] [stdout] | `devpath` will be dropped later as of Edition 2024 [INFO] [stdout] 102 | if let Some(gamepad) = Gamepad::open(&devpath, &syspath, DiscoveryBackend::Inotify) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/gamepad.rs:1032:1 [INFO] [stdout] | [INFO] [stdout] 1032 | / impl Drop for Gamepad { [INFO] [stdout] 1033 | | fn drop(&mut self) { [INFO] [stdout] 1034 | | unsafe { [INFO] [stdout] 1035 | | if self.fd >= 0 { [INFO] [stdout] ... | [INFO] [stdout] 1046 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `devpath` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/platform/linux/gamepad.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 158 | for dev in en.iter() { [INFO] [stdout] | --- --------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `dev` calls a custom destructor [INFO] [stdout] | `dev` will be dropped later as of Edition 2024 [INFO] [stdout] 159 | if let Some(dev) = Device::from_syspath(&udev, &dev) { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | if let Some(gamepad) = Gamepad::open(devpath, syspath, DiscoveryBackend::Udev) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `gamepad` calls a custom destructor [INFO] [stdout] | `gamepad` will be dropped later as of Edition 2024 [INFO] [stdout] 166 | let idx = gamepads.len(); [INFO] [stdout] 167 | / gamepad [INFO] [stdout] 168 | | .register_fd(&epoll, idx as u64) [INFO] [stdout] 169 | | .map_err(|e| errno_to_platform_error(e, "registering gamepad in epoll"))?; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_________________________________________________________________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/gamepad.rs:1032:1 [INFO] [stdout] | [INFO] [stdout] 1032 | / impl Drop for Gamepad { [INFO] [stdout] 1033 | | fn drop(&mut self) { [INFO] [stdout] 1034 | | unsafe { [INFO] [stdout] 1035 | | if self.fd >= 0 { [INFO] [stdout] ... | [INFO] [stdout] 1046 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `dev` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/udev.rs:171:1 [INFO] [stdout] | [INFO] [stdout] 171 | / impl Drop for Device { [INFO] [stdout] 172 | | fn drop(&mut self) { [INFO] [stdout] 173 | | unsafe { [INFO] [stdout] 174 | | ud::udev_device_unref(self.0); [INFO] [stdout] ... | [INFO] [stdout] 177 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `gamepad` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/gamepad.rs:1032:1 [INFO] [stdout] | [INFO] [stdout] 1032 | / impl Drop for Gamepad { [INFO] [stdout] 1033 | | fn drop(&mut self) { [INFO] [stdout] 1034 | | unsafe { [INFO] [stdout] 1035 | | if self.fd >= 0 { [INFO] [stdout] ... | [INFO] [stdout] 1046 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mpmc/mod.rs:1346:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/gamepad.rs:1032:1 [INFO] [stdout] | [INFO] [stdout] 1032 | / impl Drop for Gamepad { [INFO] [stdout] 1033 | | fn drop(&mut self) { [INFO] [stdout] 1034 | | unsafe { [INFO] [stdout] 1035 | | if self.fd >= 0 { [INFO] [stdout] ... | [INFO] [stdout] 1046 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/platform/linux/gamepad.rs:159:32 [INFO] [stdout] | [INFO] [stdout] 158 | for dev in en.iter() { [INFO] [stdout] | --- --------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `dev` calls a custom destructor [INFO] [stdout] | `dev` will be dropped later as of Edition 2024 [INFO] [stdout] 159 | if let Some(dev) = Device::from_syspath(&udev, &dev) { [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | if let Some(gamepad) = Gamepad::open(devpath, syspath, DiscoveryBackend::Udev) { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `gamepad` calls a custom destructor [INFO] [stdout] | `gamepad` will be dropped later as of Edition 2024 [INFO] [stdout] 166 | let idx = gamepads.len(); [INFO] [stdout] 167 | / gamepad [INFO] [stdout] 168 | | .register_fd(&epoll, idx as u64) [INFO] [stdout] 169 | | .map_err(|e| errno_to_platform_error(e, "registering gamepad in epoll"))?; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_________________________________________________________________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/udev.rs:171:1 [INFO] [stdout] | [INFO] [stdout] 171 | / impl Drop for Device { [INFO] [stdout] 172 | | fn drop(&mut self) { [INFO] [stdout] 173 | | unsafe { [INFO] [stdout] 174 | | ud::udev_device_unref(self.0); [INFO] [stdout] ... | [INFO] [stdout] 177 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `dev` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/udev.rs:171:1 [INFO] [stdout] | [INFO] [stdout] 171 | / impl Drop for Device { [INFO] [stdout] 172 | | fn drop(&mut self) { [INFO] [stdout] 173 | | unsafe { [INFO] [stdout] 174 | | ud::udev_device_unref(self.0); [INFO] [stdout] ... | [INFO] [stdout] 177 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `gamepad` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/gamepad.rs:1032:1 [INFO] [stdout] | [INFO] [stdout] 1032 | / impl Drop for Gamepad { [INFO] [stdout] 1033 | | fn drop(&mut self) { [INFO] [stdout] 1034 | | unsafe { [INFO] [stdout] 1035 | | if self.fd >= 0 { [INFO] [stdout] ... | [INFO] [stdout] 1046 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mpmc/mod.rs:1346:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> src/platform/linux/gamepad.rs:1032:1 [INFO] [stdout] | [INFO] [stdout] 1032 | / impl Drop for Gamepad { [INFO] [stdout] 1033 | | fn drop(&mut self) { [INFO] [stdout] 1034 | | unsafe { [INFO] [stdout] 1035 | | if self.fd >= 0 { [INFO] [stdout] ... | [INFO] [stdout] 1046 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/platform/linux/gamepad.rs:298:31 [INFO] [stdout] | [INFO] [stdout] 298 | while let Ok(event) = self.hotplug_rx.try_recv() { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `event` calls a custom destructor [INFO] [stdout] | `event` will be dropped later as of Edition 2024 [INFO] [stdout] 299 | match event { [INFO] [stdout] 300 | HotplugEvent::New { devpath, syspath } => { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `devpath` calls a custom destructor [INFO] [stdout] | `devpath` will be dropped later as of Edition 2024 [INFO] [stdout] 301 | // We already know this gamepad, ignore it: [INFO] [stdout] 302 | let gamepad_path_str = devpath.clone().to_string_lossy().into_owned(); [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `event` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `devpath` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gilrs-core` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "774efe1044fe8236740c370f8968263edd79045c3e129b7c7ca24affc2ab26cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "774efe1044fe8236740c370f8968263edd79045c3e129b7c7ca24affc2ab26cf", kill_on_drop: false }` [INFO] [stdout] 774efe1044fe8236740c370f8968263edd79045c3e129b7c7ca24affc2ab26cf