[INFO] fetching crate gain 0.5.0... [INFO] building gain-0.5.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate gain 0.5.0 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate gain 0.5.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gain 0.5.0 [INFO] finished tweaking crates.io crate gain 0.5.0 [INFO] tweaked toml for crates.io crate gain 0.5.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding async-task v1.3.1 (available: v4.7.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded async-task v1.3.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3beb33cc85e81e53b094574a8174f53d66dae7581dfdc331709446fe05985b24 [INFO] running `Command { std: "docker" "start" "-a" "3beb33cc85e81e53b094574a8174f53d66dae7581dfdc331709446fe05985b24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3beb33cc85e81e53b094574a8174f53d66dae7581dfdc331709446fe05985b24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3beb33cc85e81e53b094574a8174f53d66dae7581dfdc331709446fe05985b24", kill_on_drop: false }` [INFO] [stdout] 3beb33cc85e81e53b094574a8174f53d66dae7581dfdc331709446fe05985b24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8578f7bc7942ef385106d56c6bd0e8da50ae097f288de2a5a0cc631d8a9eb9d5 [INFO] running `Command { std: "docker" "start" "-a" "8578f7bc7942ef385106d56c6bd0e8da50ae097f288de2a5a0cc631d8a9eb9d5", kill_on_drop: false }` [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling async-task v1.3.1 [INFO] [stderr] Compiling gain v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/buf.rs:77:62 [INFO] [stdout] | [INFO] [stdout] 77 | fn read<'a>(&'a mut self, dest: &'a mut [u8]) -> future::Read; [INFO] [stdout] | -- lifetime `'a` declared here ^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/buf.rs:242:62 [INFO] [stdout] | [INFO] [stdout] 242 | fn read<'a>(&'a mut self, dest: &'a mut [u8]) -> future::Read { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/buf.rs:311:62 [INFO] [stdout] | [INFO] [stdout] 311 | fn read<'a>(&'a mut self, dest: &'a mut [u8]) -> future::Read { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/buf.rs:325:66 [INFO] [stdout] | [INFO] [stdout] 325 | fn write<'a>(&'a mut self, data: &'a [u8]) -> super::future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/buf.rs:329:82 [INFO] [stdout] | [INFO] [stdout] 329 | fn write_note<'a>(&'a mut self, data: &'a [u8], note: i32) -> super::future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/buf.rs:333:70 [INFO] [stdout] | [INFO] [stdout] 333 | fn write_all<'a>(&'a mut self, data: &'a [u8]) -> super::future::WriteAll { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:35:59 [INFO] [stdout] | [INFO] [stdout] 35 | fn write<'a>(&'a mut self, data: &'a [u8]) -> future::Write; [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:38:75 [INFO] [stdout] | [INFO] [stdout] 38 | fn write_note<'a>(&'a mut self, data: &'a [u8], note: i32) -> future::Write; [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:41:63 [INFO] [stdout] | [INFO] [stdout] 41 | fn write_all<'a>(&'a mut self, data: &'a [u8]) -> future::WriteAll; [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:101:59 [INFO] [stdout] | [INFO] [stdout] 101 | fn write<'a>(&'a mut self, data: &'a [u8]) -> future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 105 | fn write_note<'a>(&'a mut self, data: &'a [u8], note: i32) -> future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:109:63 [INFO] [stdout] | [INFO] [stdout] 109 | fn write_all<'a>(&'a mut self, data: &'a [u8]) -> future::WriteAll { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:257:59 [INFO] [stdout] | [INFO] [stdout] 257 | fn write<'a>(&'a mut self, data: &'a [u8]) -> future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:261:75 [INFO] [stdout] | [INFO] [stdout] 261 | fn write_note<'a>(&'a mut self, data: &'a [u8], note: i32) -> future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:265:63 [INFO] [stdout] | [INFO] [stdout] 265 | fn write_all<'a>(&'a mut self, data: &'a [u8]) -> future::WriteAll { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:304:59 [INFO] [stdout] | [INFO] [stdout] 304 | fn write<'a>(&'a mut self, data: &'a [u8]) -> future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:308:75 [INFO] [stdout] | [INFO] [stdout] 308 | fn write_note<'a>(&'a mut self, data: &'a [u8], note: i32) -> future::Write { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/stream/mod.rs:312:63 [INFO] [stdout] | [INFO] [stdout] 312 | fn write_all<'a>(&'a mut self, data: &'a [u8]) -> future::WriteAll { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | let mut prev_share = prev.as_mut().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/task.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 44 | if let Poll::Ready(result) = future.as_mut().poll(cx) { [INFO] [stdout] | ------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | while let Some(task) = TASKS.borrow_mut().pop_front() { [INFO] [stdout] | ------------------^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 49 | task.run(); [INFO] [stdout] 50 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/async-task-1.3.1/src/task.rs:305:1 [INFO] [stdout] | [INFO] [stdout] 305 | impl Drop for Task { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gain` (lib) due to 1 previous error; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8578f7bc7942ef385106d56c6bd0e8da50ae097f288de2a5a0cc631d8a9eb9d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8578f7bc7942ef385106d56c6bd0e8da50ae097f288de2a5a0cc631d8a9eb9d5", kill_on_drop: false }` [INFO] [stdout] 8578f7bc7942ef385106d56c6bd0e8da50ae097f288de2a5a0cc631d8a9eb9d5