[INFO] fetching crate faf-replay-parser 0.5.2... [INFO] building faf-replay-parser-0.5.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate faf-replay-parser 0.5.2 into /workspace/builds/worker-2-tc1/source [INFO] validating manifest of crates.io crate faf-replay-parser 0.5.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate faf-replay-parser 0.5.2 [INFO] finished tweaking crates.io crate faf-replay-parser 0.5.2 [INFO] tweaked toml for crates.io crate faf-replay-parser 0.5.2 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate crates.io crate faf-replay-parser 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zstd v0.11.1+zstd.1.5.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 42d626f8dd93b6d93d2133eff592cc172e370ce808c475011bb493e4d4a6da69 [INFO] running `Command { std: "docker" "start" "-a" "42d626f8dd93b6d93d2133eff592cc172e370ce808c475011bb493e4d4a6da69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "42d626f8dd93b6d93d2133eff592cc172e370ce808c475011bb493e4d4a6da69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42d626f8dd93b6d93d2133eff592cc172e370ce808c475011bb493e4d4a6da69", kill_on_drop: false }` [INFO] [stdout] 42d626f8dd93b6d93d2133eff592cc172e370ce808c475011bb493e4d4a6da69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6456c5696b7e596b17b75d9304887b6f2111a2cb7c5a236875cf5581c145b273 [INFO] running `Command { std: "docker" "start" "-a" "6456c5696b7e596b17b75d9304887b6f2111a2cb7c5a236875cf5581c145b273", kill_on_drop: false }` [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling faf-replay-parser v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/scfa/parser.rs:326:19 [INFO] [stdout] | [INFO] [stdout] 326 | match self.parse_command() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 327 | Ok(Some(cmd)) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `cmd` calls a custom destructor [INFO] [stdout] | `cmd` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `cmd` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/scfa/parser.rs:774:15 [INFO] [stdout] | [INFO] [stdout] 774 | match parse_command(reader, options, buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | Ok(opt) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `opt` calls a custom destructor [INFO] [stdout] | `opt` will be dropped later as of Edition 2024 [INFO] [stdout] 780 | if let Some(cmd) = opt { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `cmd` calls a custom destructor [INFO] [stdout] | `cmd` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 798 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `opt` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] note: `cmd` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/ffi/c_str.rs:694:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `vec_read_until` is never used [INFO] [stdout] --> src/reader.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub trait ReplayBufReadExt: io::BufRead + ReplayReadExt { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] 155 | /// Convenience wrapper around `std::io::BufRead::read_until` for allocating a new `Vec`. [INFO] [stdout] 156 | fn vec_read_until(&mut self, byte: u8) -> io::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faf-replay-parser` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6456c5696b7e596b17b75d9304887b6f2111a2cb7c5a236875cf5581c145b273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6456c5696b7e596b17b75d9304887b6f2111a2cb7c5a236875cf5581c145b273", kill_on_drop: false }` [INFO] [stdout] 6456c5696b7e596b17b75d9304887b6f2111a2cb7c5a236875cf5581c145b273