[INFO] fetching crate ethereum-trie-test 0.3.9... [INFO] building ethereum-trie-test-0.3.9 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate ethereum-trie-test 0.3.9 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate ethereum-trie-test 0.3.9 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ethereum-trie-test 0.3.9 [INFO] finished tweaking crates.io crate ethereum-trie-test 0.3.9 [INFO] tweaked toml for crates.io crate ethereum-trie-test 0.3.9 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding sha3 v0.6.0 (available: v0.10.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1273cdafc91a1c734697823c44d34935705e4f587fea1e8e917faedab8eee0a1 [INFO] running `Command { std: "docker" "start" "-a" "1273cdafc91a1c734697823c44d34935705e4f587fea1e8e917faedab8eee0a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1273cdafc91a1c734697823c44d34935705e4f587fea1e8e917faedab8eee0a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1273cdafc91a1c734697823c44d34935705e4f587fea1e8e917faedab8eee0a1", kill_on_drop: false }` [INFO] [stdout] 1273cdafc91a1c734697823c44d34935705e4f587fea1e8e917faedab8eee0a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9fa6beb0be7ae1155e462bafccc20cbf522d1b9b2dd729363598e617aa8634e1 [INFO] running `Command { std: "docker" "start" "-a" "9fa6beb0be7ae1155e462bafccc20cbf522d1b9b2dd729363598e617aa8634e1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling nodrop v0.1.14 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling lazy_static v0.2.11 [INFO] [stderr] Compiling ethereum-hexutil v0.2.3 [INFO] [stderr] Compiling byte-tools v0.2.0 [INFO] [stderr] Compiling elastic-array-plus v0.9.1 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling generic-array v0.8.4 [INFO] [stderr] Compiling block-buffer v0.2.0 [INFO] [stderr] Compiling digest v0.6.1 [INFO] [stderr] Compiling sha3 v0.6.0 [INFO] [stderr] Compiling ethereum-rlp v0.2.3 [INFO] [stderr] Compiling rand v0.3.23 [INFO] [stderr] Compiling ethereum-bigint v0.2.9 [INFO] [stderr] Compiling ethereum-trie-test v0.3.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `DerefMut` and `Deref` [INFO] [stdout] --> src/lib.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::{Deref, DerefMut}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decodable`, `Encodable`, and `Prototype` [INFO] [stdout] --> src/merkle/nibble.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use rlp::{RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/merkle/nibble.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Formatter` and `self` [INFO] [stdout] --> src/merkle/nibble.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fmt::{self, Debug, Formatter}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use super::nibble::{self, Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleType`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/mod.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use self::nibble::{Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `::Trie` [INFO] [stdout] --> src/database/memory.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use ::Trie; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseOwned` [INFO] [stdout] --> src/database/memory.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use super::{Database, DatabaseOwned, DatabaseGuard}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Hasher` [INFO] [stdout] --> src/merkle/nibble.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::hash::{Hash, Hasher}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Decodable` [INFO] [stdout] --> src/merkle/node.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/lib.rs:283:74 [INFO] [stdout] | [INFO] [stdout] 283 | let submap = Self::build_submap(1, map.iter().filter(|&(key, value)| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/lib.rs:296:29 [INFO] [stdout] | [INFO] [stdout] 296 | .filter(|&(key, value)| key.len() == 0).next() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/lib.rs:297:20 [INFO] [stdout] | [INFO] [stdout] 297 | .map(|(key, value)| value.clone()); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_nodes` [INFO] [stdout] --> src/lib.rs:632:44 [INFO] [stdout] | [INFO] [stdout] 632 | MerkleNode::Branch(sub_nodes, sub_additional) => { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_additional` [INFO] [stdout] --> src/lib.rs:632:55 [INFO] [stdout] | [INFO] [stdout] 632 | MerkleNode::Branch(sub_nodes, sub_additional) => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_additional` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/database/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 68 | impl<'a, D: DatabaseGuard> Change<'a, D> { [INFO] [stdout] | ---------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 96 | pub fn free<'b>(&'b mut self, hash: H256) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `freed` is never read [INFO] [stdout] --> src/database/mod.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub struct ChangeSet { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 123 | freed: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:251:67 [INFO] [stdout] | [INFO] [stdout] 251 | submap.insert(key.split_at(common_len).1.into(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:263:71 [INFO] [stdout] | [INFO] [stdout] 263 | return MerkleNode::Leaf(key.clone(), map.get(key).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:297:38 [INFO] [stdout] | [INFO] [stdout] 297 | .map(|(key, value)| value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:433:64 [INFO] [stdout] | [INFO] [stdout] 433 | node_map.insert(node_nibble.clone(), node_value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:503:61 [INFO] [stdout] | [INFO] [stdout] 503 | node_map.insert(nibble::from_key(key), value.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:651:74 [INFO] [stdout] | [INFO] [stdout] 651 | Some(MerkleNode::Leaf(node_nibble.clone(), node_value.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/merkle/node.rs:60:55 [INFO] [stdout] | [INFO] [stdout] 60 | MerkleNode::Leaf(nibble.clone(), value.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `Command { std: "docker" "inspect" "9fa6beb0be7ae1155e462bafccc20cbf522d1b9b2dd729363598e617aa8634e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fa6beb0be7ae1155e462bafccc20cbf522d1b9b2dd729363598e617aa8634e1", kill_on_drop: false }` [INFO] [stdout] 9fa6beb0be7ae1155e462bafccc20cbf522d1b9b2dd729363598e617aa8634e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2ec1a070fb3215a7fdb2284d3c8618bfb5a1f7c41f22347a2fced2c15d56099 [INFO] running `Command { std: "docker" "start" "-a" "a2ec1a070fb3215a7fdb2284d3c8618bfb5a1f7c41f22347a2fced2c15d56099", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stdout] warning: unused imports: `DerefMut` and `Deref` [INFO] [stdout] --> src/lib.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::{Deref, DerefMut}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decodable`, `Encodable`, and `Prototype` [INFO] [stdout] --> src/merkle/nibble.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use rlp::{RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/merkle/nibble.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Formatter` and `self` [INFO] [stdout] --> src/merkle/nibble.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fmt::{self, Debug, Formatter}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use super::nibble::{self, Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleType`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/mod.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use self::nibble::{Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `::Trie` [INFO] [stdout] --> src/database/memory.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use ::Trie; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseOwned` [INFO] [stdout] --> src/database/memory.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use super::{Database, DatabaseOwned, DatabaseGuard}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Hasher` [INFO] [stdout] --> src/merkle/nibble.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::hash::{Hash, Hasher}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Decodable` [INFO] [stdout] --> src/merkle/node.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/lib.rs:283:74 [INFO] [stdout] | [INFO] [stdout] 283 | let submap = Self::build_submap(1, map.iter().filter(|&(key, value)| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/lib.rs:296:29 [INFO] [stdout] | [INFO] [stdout] 296 | .filter(|&(key, value)| key.len() == 0).next() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/lib.rs:297:20 [INFO] [stdout] | [INFO] [stdout] 297 | .map(|(key, value)| value.clone()); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_nodes` [INFO] [stdout] --> src/lib.rs:632:44 [INFO] [stdout] | [INFO] [stdout] 632 | MerkleNode::Branch(sub_nodes, sub_additional) => { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_additional` [INFO] [stdout] --> src/lib.rs:632:55 [INFO] [stdout] | [INFO] [stdout] 632 | MerkleNode::Branch(sub_nodes, sub_additional) => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_additional` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/database/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 68 | impl<'a, D: DatabaseGuard> Change<'a, D> { [INFO] [stdout] | ---------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 96 | pub fn free<'b>(&'b mut self, hash: H256) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `freed` is never read [INFO] [stdout] --> src/database/mod.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub struct ChangeSet { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 123 | freed: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:251:67 [INFO] [stdout] | [INFO] [stdout] 251 | submap.insert(key.split_at(common_len).1.into(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:263:71 [INFO] [stdout] | [INFO] [stdout] 263 | return MerkleNode::Leaf(key.clone(), map.get(key).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:297:38 [INFO] [stdout] | [INFO] [stdout] 297 | .map(|(key, value)| value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:433:64 [INFO] [stdout] | [INFO] [stdout] 433 | node_map.insert(node_nibble.clone(), node_value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:503:61 [INFO] [stdout] | [INFO] [stdout] 503 | node_map.insert(nibble::from_key(key), value.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:651:74 [INFO] [stdout] | [INFO] [stdout] 651 | Some(MerkleNode::Leaf(node_nibble.clone(), node_value.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling ethereum-trie-test v0.3.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/merkle/node.rs:60:55 [INFO] [stdout] | [INFO] [stdout] 60 | MerkleNode::Leaf(nibble.clone(), value.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DerefMut` and `Deref` [INFO] [stdout] --> src/lib.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::{Deref, DerefMut}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decodable`, `Encodable`, and `Prototype` [INFO] [stdout] --> src/merkle/nibble.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use rlp::{RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/merkle/nibble.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Formatter` and `self` [INFO] [stdout] --> src/merkle/nibble.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fmt::{self, Debug, Formatter}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use super::nibble::{self, Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Keccak256` [INFO] [stdout] --> src/merkle/node.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | use sha3::{Digest, Keccak256}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:158:32 [INFO] [stdout] | [INFO] [stdout] 158 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleType`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/mod.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use self::nibble::{Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `::Trie` [INFO] [stdout] --> src/database/memory.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use ::Trie; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseOwned` [INFO] [stdout] --> src/database/memory.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use super::{Database, DatabaseOwned, DatabaseGuard}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::UnsafeCell` [INFO] [stdout] --> src/lib.rs:726:9 [INFO] [stdout] | [INFO] [stdout] 726 | use std::cell::UnsafeCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Hasher` [INFO] [stdout] --> src/merkle/nibble.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::hash::{Hash, Hasher}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Decodable` [INFO] [stdout] --> src/merkle/node.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Digest` [INFO] [stdout] --> src/merkle/node.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | use sha3::{Digest, Keccak256}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseGuard` [INFO] [stdout] --> src/lib.rs:723:17 [INFO] [stdout] | [INFO] [stdout] 723 | use super::{DatabaseGuard, Trie}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/lib.rs:283:74 [INFO] [stdout] | [INFO] [stdout] 283 | let submap = Self::build_submap(1, map.iter().filter(|&(key, value)| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/lib.rs:296:29 [INFO] [stdout] | [INFO] [stdout] 296 | .filter(|&(key, value)| key.len() == 0).next() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/lib.rs:297:20 [INFO] [stdout] | [INFO] [stdout] 297 | .map(|(key, value)| value.clone()); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_nodes` [INFO] [stdout] --> src/lib.rs:632:44 [INFO] [stdout] | [INFO] [stdout] 632 | MerkleNode::Branch(sub_nodes, sub_additional) => { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sub_additional` [INFO] [stdout] --> src/lib.rs:632:55 [INFO] [stdout] | [INFO] [stdout] 632 | MerkleNode::Branch(sub_nodes, sub_additional) => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_additional` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:740:13 [INFO] [stdout] | [INFO] [stdout] 740 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:756:13 [INFO] [stdout] | [INFO] [stdout] 756 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:776:13 [INFO] [stdout] | [INFO] [stdout] 776 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:801:13 [INFO] [stdout] | [INFO] [stdout] 801 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:812:13 [INFO] [stdout] | [INFO] [stdout] 812 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:825:13 [INFO] [stdout] | [INFO] [stdout] 825 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:841:13 [INFO] [stdout] | [INFO] [stdout] 841 | let mut map = HashMap::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:843:13 [INFO] [stdout] | [INFO] [stdout] 843 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:854:13 [INFO] [stdout] | [INFO] [stdout] 854 | let mut map = HashMap::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:856:13 [INFO] [stdout] | [INFO] [stdout] 856 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:869:13 [INFO] [stdout] | [INFO] [stdout] 869 | let mut map = HashMap::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:871:13 [INFO] [stdout] | [INFO] [stdout] 871 | let mut database: HashMap> = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:872:13 [INFO] [stdout] | [INFO] [stdout] 872 | let mut trie: Trie>> = Trie::build(database, &map); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/database/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 68 | impl<'a, D: DatabaseGuard> Change<'a, D> { [INFO] [stdout] | ---------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 96 | pub fn free<'b>(&'b mut self, hash: H256) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `freed` is never read [INFO] [stdout] --> src/database/mod.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub struct ChangeSet { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 123 | freed: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:251:67 [INFO] [stdout] | [INFO] [stdout] 251 | submap.insert(key.split_at(common_len).1.into(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:263:71 [INFO] [stdout] | [INFO] [stdout] 263 | return MerkleNode::Leaf(key.clone(), map.get(key).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:297:38 [INFO] [stdout] | [INFO] [stdout] 297 | .map(|(key, value)| value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:433:64 [INFO] [stdout] | [INFO] [stdout] 433 | node_map.insert(node_nibble.clone(), node_value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:503:61 [INFO] [stdout] | [INFO] [stdout] 503 | node_map.insert(nibble::from_key(key), value.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:651:74 [INFO] [stdout] | [INFO] [stdout] 651 | Some(MerkleNode::Leaf(node_nibble.clone(), node_value.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/merkle/node.rs:60:55 [INFO] [stdout] | [INFO] [stdout] 60 | MerkleNode::Leaf(nibble.clone(), value.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "a2ec1a070fb3215a7fdb2284d3c8618bfb5a1f7c41f22347a2fced2c15d56099", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2ec1a070fb3215a7fdb2284d3c8618bfb5a1f7c41f22347a2fced2c15d56099", kill_on_drop: false }` [INFO] [stdout] a2ec1a070fb3215a7fdb2284d3c8618bfb5a1f7c41f22347a2fced2c15d56099