[INFO] fetching crate envsub 0.1.3... [INFO] building envsub-0.1.3 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate envsub 0.1.3 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate envsub 0.1.3 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate envsub 0.1.3 [INFO] finished tweaking crates.io crate envsub 0.1.3 [INFO] tweaked toml for crates.io crate envsub 0.1.3 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate crates.io crate envsub 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ff3dbcb66b6da64261cae1234b6255c593057501de6a635919f27dcf71e61fc [INFO] running `Command { std: "docker" "start" "-a" "6ff3dbcb66b6da64261cae1234b6255c593057501de6a635919f27dcf71e61fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ff3dbcb66b6da64261cae1234b6255c593057501de6a635919f27dcf71e61fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ff3dbcb66b6da64261cae1234b6255c593057501de6a635919f27dcf71e61fc", kill_on_drop: false }` [INFO] [stdout] 6ff3dbcb66b6da64261cae1234b6255c593057501de6a635919f27dcf71e61fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7fe41c8e4f5b81f1c8b4c2d55020c40c7398889c35895c7cbc9716441c8cd676 [INFO] running `Command { std: "docker" "start" "-a" "7fe41c8e4f5b81f1c8b4c2d55020c40c7398889c35895c7cbc9716441c8cd676", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling unicode-width v0.1.6 [INFO] [stderr] Compiling regex-syntax v0.6.11 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling getopts v0.2.21 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Compiling regex v1.2.1 [INFO] [stderr] Compiling envsub v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!(f.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!("{}", f.to_string()), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:179:46 [INFO] [stdout] | [INFO] [stdout] 179 | ... ":-" => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 179 - ":-" => match val.borrow() { [INFO] [stdout] 179 + ":-" => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:189:43 [INFO] [stdout] | [INFO] [stdout] 189 | ... _ => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 189 - _ => match val.borrow() { [INFO] [stdout] 189 + _ => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:194:42 [INFO] [stdout] | [INFO] [stdout] 194 | None => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 194 - None => match val.borrow() { [INFO] [stdout] 194 + None => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:208:52 [INFO] [stdout] | [INFO] [stdout] 208 | .map_or("", |m| m.as_str()) [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 209 | | .clone() [INFO] [stdout] | |________________________________^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `Command { std: "docker" "inspect" "7fe41c8e4f5b81f1c8b4c2d55020c40c7398889c35895c7cbc9716441c8cd676", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fe41c8e4f5b81f1c8b4c2d55020c40c7398889c35895c7cbc9716441c8cd676", kill_on_drop: false }` [INFO] [stdout] 7fe41c8e4f5b81f1c8b4c2d55020c40c7398889c35895c7cbc9716441c8cd676 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a043c0e2a323bc5f43e50e3d2f1c36cac51a9ea646b6b40ed5a7ea17d3927063 [INFO] running `Command { std: "docker" "start" "-a" "a043c0e2a323bc5f43e50e3d2f1c36cac51a9ea646b6b40ed5a7ea17d3927063", kill_on_drop: false }` [INFO] [stderr] Compiling envsub v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!(f.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 74 | Err(f) => panic!("{}", f.to_string()), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:179:46 [INFO] [stdout] | [INFO] [stdout] 179 | ... ":-" => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 179 - ":-" => match val.borrow() { [INFO] [stdout] 179 + ":-" => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:189:43 [INFO] [stdout] | [INFO] [stdout] 189 | ... _ => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 189 - _ => match val.borrow() { [INFO] [stdout] 189 + _ => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:194:42 [INFO] [stdout] | [INFO] [stdout] 194 | None => match val.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Option` does not implement `Borrow`, so calling `borrow` on `&Option` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 194 - None => match val.borrow() { [INFO] [stdout] 194 + None => match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:208:52 [INFO] [stdout] | [INFO] [stdout] 208 | .map_or("", |m| m.as_str()) [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 209 | | .clone() [INFO] [stdout] | |________________________________^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.13s [INFO] running `Command { std: "docker" "inspect" "a043c0e2a323bc5f43e50e3d2f1c36cac51a9ea646b6b40ed5a7ea17d3927063", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a043c0e2a323bc5f43e50e3d2f1c36cac51a9ea646b6b40ed5a7ea17d3927063", kill_on_drop: false }` [INFO] [stdout] a043c0e2a323bc5f43e50e3d2f1c36cac51a9ea646b6b40ed5a7ea17d3927063