[INFO] fetching crate earlgrey 0.4.1... [INFO] building earlgrey-0.4.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate earlgrey 0.4.1 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate earlgrey 0.4.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate earlgrey 0.4.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate earlgrey 0.4.1 [INFO] tweaked toml for crates.io crate earlgrey 0.4.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] crate crates.io crate earlgrey 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded fd-lock v4.0.2 [INFO] [stderr] Downloaded rustyline v14.0.0 [INFO] [stderr] Downloaded lexers v0.1.4 [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] [stderr] Downloaded nix v0.28.0 [INFO] [stderr] Downloaded libc v0.2.159 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27c959e5b26d15234339a7f02b33c0ea5772d781ef041d2b8e52ba6483e42865 [INFO] running `Command { std: "docker" "start" "-a" "27c959e5b26d15234339a7f02b33c0ea5772d781ef041d2b8e52ba6483e42865", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27c959e5b26d15234339a7f02b33c0ea5772d781ef041d2b8e52ba6483e42865", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27c959e5b26d15234339a7f02b33c0ea5772d781ef041d2b8e52ba6483e42865", kill_on_drop: false }` [INFO] [stdout] 27c959e5b26d15234339a7f02b33c0ea5772d781ef041d2b8e52ba6483e42865 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 061d7a516c86d9173c3690340af4ba43b548f55280f5540bdcab9e8954f86a0f [INFO] running `Command { std: "docker" "start" "-a" "061d7a516c86d9173c3690340af4ba43b548f55280f5540bdcab9e8954f86a0f", kill_on_drop: false }` [INFO] [stderr] Compiling earlgrey v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/earley/parser.rs:102:35 [INFO] [stdout] | [INFO] [stdout] 89 | for new_item in new_items { [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | if let Some(lexeme) = tokenizer.next() { [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `lexeme` calls a custom destructor [INFO] [stdout] | `lexeme` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `iter` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/earley/trees.rs:144:39 [INFO] [stdout] | [INFO] [stdout] 144 | while let Some((span, idx)) = self.source_idx.pop() { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `span` calls a custom destructor [INFO] [stdout] | `span` will be dropped later as of Edition 2024 [INFO] [stdout] 145 | if idx + 1 < span.sources().len() { [INFO] [stdout] | -------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `span` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/earley/trees.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 182 | while let Some(cursor) = spans.pop() { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `cursor` calls a custom destructor [INFO] [stdout] | `cursor` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | if cursor.sources().len() == 0 { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 191 | let completed_rule = &completions.pop().expect("BUG: span rule never completed").rule; [INFO] [stdout] | ---------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | match &cursor.sources()[span_source_idx] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: `cursor` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/earley/trees.rs:182:34 [INFO] [stdout] | [INFO] [stdout] 182 | while let Some(cursor) = spans.pop() { [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `cursor` calls a custom destructor [INFO] [stdout] | `cursor` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | if cursor.sources().len() == 0 { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 191 | let completed_rule = &completions.pop().expect("BUG: span rule never completed").rule; [INFO] [stdout] | ---------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let rule_args = args.split_off(args.len() - num_rule_slots).into_iter().rev().collect(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `rule_args` calls a custom destructor [INFO] [stdout] | `rule_args` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `cursor` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `earlgrey` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "061d7a516c86d9173c3690340af4ba43b548f55280f5540bdcab9e8954f86a0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "061d7a516c86d9173c3690340af4ba43b548f55280f5540bdcab9e8954f86a0f", kill_on_drop: false }` [INFO] [stdout] 061d7a516c86d9173c3690340af4ba43b548f55280f5540bdcab9e8954f86a0f