[INFO] fetching crate disk_utils 0.0.1... [INFO] building disk_utils-0.0.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate disk_utils 0.0.1 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate disk_utils 0.0.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate disk_utils 0.0.1 [INFO] finished tweaking crates.io crate disk_utils 0.0.1 [INFO] tweaked toml for crates.io crate disk_utils 0.0.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding byteorder v0.5.3 (available: v1.5.0) [INFO] [stderr] Adding crc v1.8.1 (available: v3.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded byteorder v0.5.3 [INFO] [stderr] Downloaded build_const v0.2.2 [INFO] [stderr] Downloaded crc v1.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88c01df4654e50b2ad3ebaaa840ff36564d62b614e346a67e6f87809240e94fe [INFO] running `Command { std: "docker" "start" "-a" "88c01df4654e50b2ad3ebaaa840ff36564d62b614e346a67e6f87809240e94fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88c01df4654e50b2ad3ebaaa840ff36564d62b614e346a67e6f87809240e94fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88c01df4654e50b2ad3ebaaa840ff36564d62b614e346a67e6f87809240e94fe", kill_on_drop: false }` [INFO] [stdout] 88c01df4654e50b2ad3ebaaa840ff36564d62b614e346a67e6f87809240e94fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ffcb487ecb952bb6a57c3887f18a038de1ac5c789f3b6cf6eb7e2975c00240d0 [INFO] running `Command { std: "docker" "start" "-a" "ffcb487ecb952bb6a57c3887f18a038de1ac5c789f3b6cf6eb7e2975c00240d0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling byteorder v0.5.3 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling disk_utils v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/testing.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | ThreadError(Box), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 14 | ThreadError(Box), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/testing.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | impl From> for TestFileError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | impl From> for TestFileError { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/testing.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | fn from(err: Box) -> TestFileError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | fn from(err: Box) -> TestFileError { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/wal/redo_log.rs:130:34 [INFO] [stdout] | [INFO] [stdout] 130 | while let Ok(data) = read_serializable_backwards::>(&mut iter) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `data` calls a custom destructor [INFO] [stdout] | `data` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/wal/redo_log.rs:167:34 [INFO] [stdout] | [INFO] [stdout] 167 | while let Ok(data) = read_serializable::>(&mut iter) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `data` calls a custom destructor [INFO] [stdout] | `data` will be dropped later as of Edition 2024 [INFO] [stdout] 168 | if let SingleLogEntry::ChangeEntry(entry) = data { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `entry` calls a custom destructor [INFO] [stdout] | `entry` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/wal/undo_log.rs:144:34 [INFO] [stdout] | [INFO] [stdout] 144 | while let Ok(data) = read_serializable_backwards::>(&mut iter) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `data` calls a custom destructor [INFO] [stdout] | `data` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | SingleLogEntry::InsertEntry(entry) => { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `entry` calls a custom destructor [INFO] [stdout] | `entry` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | SingleLogEntry::ChangeEntry(entry) => { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `disk_utils` (lib) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ffcb487ecb952bb6a57c3887f18a038de1ac5c789f3b6cf6eb7e2975c00240d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffcb487ecb952bb6a57c3887f18a038de1ac5c789f3b6cf6eb7e2975c00240d0", kill_on_drop: false }` [INFO] [stdout] ffcb487ecb952bb6a57c3887f18a038de1ac5c789f3b6cf6eb7e2975c00240d0