[INFO] fetching crate dangerous 0.10.0... [INFO] building dangerous-0.10.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate dangerous 0.10.0 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate dangerous 0.10.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dangerous 0.10.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate dangerous 0.10.0 [INFO] tweaked toml for crates.io crate dangerous 0.10.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate crates.io crate dangerous 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zc-derive v0.4.0 [INFO] [stderr] Downloaded colored-diff v0.2.2 [INFO] [stderr] Downloaded imap-proto v0.14.0 [INFO] [stderr] Downloaded anyhow v1.0.39 [INFO] [stderr] Downloaded zc v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d312462664bf70c9598ce98a7e425767dd7b2f14f60209eaeeb63892a9fc288 [INFO] running `Command { std: "docker" "start" "-a" "9d312462664bf70c9598ce98a7e425767dd7b2f14f60209eaeeb63892a9fc288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d312462664bf70c9598ce98a7e425767dd7b2f14f60209eaeeb63892a9fc288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d312462664bf70c9598ce98a7e425767dd7b2f14f60209eaeeb63892a9fc288", kill_on_drop: false }` [INFO] [stdout] 9d312462664bf70c9598ce98a7e425767dd7b2f14f60209eaeeb63892a9fc288 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06154a08ced044d973bb0c9738b4d912c3ffc059e2e381b2484bedcc63275b7d [INFO] running `Command { std: "docker" "start" "-a" "06154a08ced044d973bb0c9738b4d912c3ffc059e2e381b2484bedcc63275b7d", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling bytecount v0.6.2 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling dangerous v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/input/traits.rs:141:15 [INFO] [stdout] | [INFO] [stdout] 140 | let mut r = Reader::new(self.clone()); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `r` calls a custom destructor [INFO] [stdout] | `r` will be dropped later as of Edition 2024 [INFO] [stdout] 141 | match r.context( [INFO] [stdout] | _______________^ [INFO] [stdout] 142 | | CoreContext::from_operation(CoreOperation::ReadAll, self.span()), [INFO] [stdout] 143 | | f, [INFO] [stdout] 144 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/input/traits.rs:171:15 [INFO] [stdout] | [INFO] [stdout] 170 | let mut r = Reader::new(self.clone()); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `r` calls a custom destructor [INFO] [stdout] | `r` will be dropped later as of Edition 2024 [INFO] [stdout] 171 | match r.context( [INFO] [stdout] | _______________^ [INFO] [stdout] 172 | | CoreContext::from_operation(CoreOperation::ReadPartial, self.span()), [INFO] [stdout] 173 | | f, [INFO] [stdout] 174 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/input/traits.rs:653:27 [INFO] [stdout] | [INFO] [stdout] 652 | let mut reader = Reader::new(self.clone()); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `reader` calls a custom destructor [INFO] [stdout] | `reader` will be dropped later as of Edition 2024 [INFO] [stdout] 653 | if let Some(ok) = f(&mut reader) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 668 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/input/traits.rs:694:15 [INFO] [stdout] | [INFO] [stdout] 693 | let mut reader = Reader::new(self.clone()); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `reader` calls a custom destructor [INFO] [stdout] | `reader` will be dropped later as of Edition 2024 [INFO] [stdout] 694 | match reader.context(context, f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 708 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/reader/input.rs:265:25 [INFO] [stdout] | [INFO] [stdout] 264 | let checkpoint = self.input.clone(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `checkpoint` calls a custom destructor [INFO] [stdout] | `checkpoint` will be dropped later as of Edition 2024 [INFO] [stdout] 265 | if let Ok(ok) = f(self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/reader/input.rs:292:15 [INFO] [stdout] | [INFO] [stdout] 291 | let checkpoint = self.input.clone(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `checkpoint` calls a custom destructor [INFO] [stdout] | `checkpoint` will be dropped later as of Edition 2024 [INFO] [stdout] 292 | match f(self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dangerous` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "06154a08ced044d973bb0c9738b4d912c3ffc059e2e381b2484bedcc63275b7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06154a08ced044d973bb0c9738b4d912c3ffc059e2e381b2484bedcc63275b7d", kill_on_drop: false }` [INFO] [stdout] 06154a08ced044d973bb0c9738b4d912c3ffc059e2e381b2484bedcc63275b7d