[INFO] fetching crate crop 0.4.2... [INFO] building crop-0.4.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate crop 0.4.2 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate crop 0.4.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crop 0.4.2 [INFO] finished tweaking crates.io crate crop 0.4.2 [INFO] tweaked toml for crates.io crate crop 0.4.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate crates.io crate crop 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded plotters-svg v0.3.5 [INFO] [stderr] Downloaded ciborium-io v0.2.1 [INFO] [stderr] Downloaded str_indices v0.4.3 [INFO] [stderr] Downloaded ciborium-ll v0.2.1 [INFO] [stderr] Downloaded ciborium v0.2.1 [INFO] [stderr] Downloaded plotters-backend v0.3.5 [INFO] [stderr] Downloaded plotters v0.3.5 [INFO] [stderr] Downloaded ropey v1.6.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88e87821d1c852d8f67ee0ea43e9d581d19b69dc1447d9a7282cf1b1cb30421c [INFO] running `Command { std: "docker" "start" "-a" "88e87821d1c852d8f67ee0ea43e9d581d19b69dc1447d9a7282cf1b1cb30421c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88e87821d1c852d8f67ee0ea43e9d581d19b69dc1447d9a7282cf1b1cb30421c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88e87821d1c852d8f67ee0ea43e9d581d19b69dc1447d9a7282cf1b1cb30421c", kill_on_drop: false }` [INFO] [stdout] 88e87821d1c852d8f67ee0ea43e9d581d19b69dc1447d9a7282cf1b1cb30421c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9354da87456754d2b31fbaea0f844c5307ccf1e316146d13db945c2a2819eaae [INFO] running `Command { std: "docker" "start" "-a" "9354da87456754d2b31fbaea0f844c5307ccf1e316146d13db945c2a2819eaae", kill_on_drop: false }` [INFO] [stderr] Compiling str_indices v0.4.3 [INFO] [stderr] Compiling crop v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/rope/rope.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(any(test, fuzzing, feature = "arity_4"))] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/rope/rope.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | #[cfg(not(any(test, fuzzing, feature = "arity_4")))] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/rope/rope.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | #[cfg(fuzzing)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/rope/rope.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | #[cfg(not(any(test, fuzzing, feature = "small_chunks")))] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/tree.rs:970:37 [INFO] [stdout] | [INFO] [stdout] 970 | if let Some(leaf) = leaves.next() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 974 | inode.drain(child_idx..end); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 977 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/tree/tiny_arc.rs:144:1 [INFO] [stdout] | [INFO] [stdout] 144 | / impl Drop for Arc { [INFO] [stdout] 145 | | #[inline] [INFO] [stdout] 146 | | fn drop(&mut self) { [INFO] [stdout] 147 | | let old = self.inner().counter.fetch_sub(1, atomic::Ordering::Release); [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/tree.rs:985:44 [INFO] [stdout] | [INFO] [stdout] 985 | if let Some(replacement) = replacements.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 993 | let last = [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `last` calls a custom destructor [INFO] [stdout] | `last` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1017 | inode.drain(child_idx + 1..end); [INFO] [stdout] | ------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 1018 | } else { [INFO] [stdout] 1019 | inode.drain(child_idx..end); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1027 | inode.drain(child_idx..end); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1030 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/tree/tiny_arc.rs:144:1 [INFO] [stdout] | [INFO] [stdout] 144 | / impl Drop for Arc { [INFO] [stdout] 145 | | #[inline] [INFO] [stdout] 146 | | fn drop(&mut self) { [INFO] [stdout] 147 | | let old = self.inner().counter.fetch_sub(1, atomic::Ordering::Release); [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `last` invokes this custom destructor [INFO] [stdout] --> src/tree/tiny_arc.rs:144:1 [INFO] [stdout] | [INFO] [stdout] 144 | / impl Drop for Arc { [INFO] [stdout] 145 | | #[inline] [INFO] [stdout] 146 | | fn drop(&mut self) { [INFO] [stdout] 147 | | let old = self.inner().counter.fetch_sub(1, atomic::Ordering::Release); [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/tree.rs:1052:37 [INFO] [stdout] | [INFO] [stdout] 1052 | if let Some(leaf) = leaves.pop() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1056 | inode.drain(start..child_idx + 1); [INFO] [stdout] | --------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1059 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/tree/tiny_arc.rs:144:1 [INFO] [stdout] | [INFO] [stdout] 144 | / impl Drop for Arc { [INFO] [stdout] 145 | | #[inline] [INFO] [stdout] 146 | | fn drop(&mut self) { [INFO] [stdout] 147 | | let old = self.inner().counter.fetch_sub(1, atomic::Ordering::Release); [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/tree.rs:1067:44 [INFO] [stdout] | [INFO] [stdout] 1067 | if let Some(replacement) = replacements.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1075 | let last = [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `last` calls a custom destructor [INFO] [stdout] | `last` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1104 | inode.drain(start..child_idx); [INFO] [stdout] | ----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 1105 | } else { [INFO] [stdout] 1106 | inode.drain(start..child_idx + 1); [INFO] [stdout] | --------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1114 | inode.drain(start..child_idx + 1); [INFO] [stdout] | --------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1117 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/tree/tiny_arc.rs:144:1 [INFO] [stdout] | [INFO] [stdout] 144 | / impl Drop for Arc { [INFO] [stdout] 145 | | #[inline] [INFO] [stdout] 146 | | fn drop(&mut self) { [INFO] [stdout] 147 | | let old = self.inner().counter.fetch_sub(1, atomic::Ordering::Release); [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `last` invokes this custom destructor [INFO] [stdout] --> src/tree/tiny_arc.rs:144:1 [INFO] [stdout] | [INFO] [stdout] 144 | / impl Drop for Arc { [INFO] [stdout] 145 | | #[inline] [INFO] [stdout] 146 | | fn drop(&mut self) { [INFO] [stdout] 147 | | let old = self.inner().counter.fetch_sub(1, atomic::Ordering::Release); [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/vec/drain.rs:174:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crop` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9354da87456754d2b31fbaea0f844c5307ccf1e316146d13db945c2a2819eaae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9354da87456754d2b31fbaea0f844c5307ccf1e316146d13db945c2a2819eaae", kill_on_drop: false }` [INFO] [stdout] 9354da87456754d2b31fbaea0f844c5307ccf1e316146d13db945c2a2819eaae