[INFO] fetching crate core-allocator 0.2.2... [INFO] building core-allocator-0.2.2 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate core-allocator 0.2.2 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate core-allocator 0.2.2 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate core-allocator 0.2.2 [INFO] finished tweaking crates.io crate core-allocator 0.2.2 [INFO] tweaked toml for crates.io crate core-allocator 0.2.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] crate crates.io crate core-allocator 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hwloc2 v2.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34d5844f2326d8656fc856849ce4a5ca45e83f0845e4abe1aeaa8ad2162a1da6 [INFO] running `Command { std: "docker" "start" "-a" "34d5844f2326d8656fc856849ce4a5ca45e83f0845e4abe1aeaa8ad2162a1da6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34d5844f2326d8656fc856849ce4a5ca45e83f0845e4abe1aeaa8ad2162a1da6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34d5844f2326d8656fc856849ce4a5ca45e83f0845e4abe1aeaa8ad2162a1da6", kill_on_drop: false }` [INFO] [stdout] 34d5844f2326d8656fc856849ce4a5ca45e83f0845e4abe1aeaa8ad2162a1da6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6c3762c588a57fa46f79d1042a7bdb84060a373ffbc20c67caf193199763ae0 [INFO] running `Command { std: "docker" "start" "-a" "e6c3762c588a57fa46f79d1042a7bdb84060a373ffbc20c67caf193199763ae0", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.106 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling hwloc2 v2.2.0 [INFO] [stderr] Compiling errno v0.2.8 [INFO] [stderr] Compiling nix v0.23.0 [INFO] [stderr] Compiling num v0.1.42 [INFO] [stderr] Compiling core-allocator v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/allocators.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | if let Ok(taken) = group.resource.try_lock() { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `taken` calls a custom destructor [INFO] [stdout] | `taken` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/resource.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Drop for ResourceHandle { [INFO] [stdout] 32 | | fn drop(&mut self) { [INFO] [stdout] 33 | | self.0.taken.store(false, Ordering::Relaxed) [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `taken` invokes this custom destructor [INFO] [stdout] --> src/resource.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Drop for ResourceHandle { [INFO] [stdout] 32 | | fn drop(&mut self) { [INFO] [stdout] 33 | | self.0.taken.store(false, Ordering::Relaxed) [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `core-allocator` (lib) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e6c3762c588a57fa46f79d1042a7bdb84060a373ffbc20c67caf193199763ae0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6c3762c588a57fa46f79d1042a7bdb84060a373ffbc20c67caf193199763ae0", kill_on_drop: false }` [INFO] [stdout] e6c3762c588a57fa46f79d1042a7bdb84060a373ffbc20c67caf193199763ae0