[INFO] fetching crate clroxide 1.1.1... [INFO] building clroxide-1.1.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate clroxide 1.1.1 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate clroxide 1.1.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clroxide 1.1.1 [INFO] finished tweaking crates.io crate clroxide 1.1.1 [INFO] tweaked toml for crates.io crate clroxide 1.1.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate crates.io crate clroxide 1.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90571a2a981142237e2a146d8573b9ba6b42ead207b4eda6ceeade5d55faeb0b [INFO] running `Command { std: "docker" "start" "-a" "90571a2a981142237e2a146d8573b9ba6b42ead207b4eda6ceeade5d55faeb0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90571a2a981142237e2a146d8573b9ba6b42ead207b4eda6ceeade5d55faeb0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90571a2a981142237e2a146d8573b9ba6b42ead207b4eda6ceeade5d55faeb0b", kill_on_drop: false }` [INFO] [stdout] 90571a2a981142237e2a146d8573b9ba6b42ead207b4eda6ceeade5d55faeb0b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d0883f2a10119b1d5ab6a96dd752b19e9e97a5acd322fef506a2f2833ce91a4 [INFO] running `Command { std: "docker" "start" "-a" "0d0883f2a10119b1d5ab6a96dd752b19e9e97a5acd322fef506a2f2833ce91a4", kill_on_drop: false }` [INFO] [stderr] Compiling windows-targets v0.42.2 [INFO] [stderr] Compiling windows v0.46.0 [INFO] [stderr] Compiling clroxide v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/primitives/helpers.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 150 | match unsafe { SafeArrayPutElement(safe_array_ptr, indices.as_ptr(), *v_ref as *const _) } { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 151 | Ok(_) => {}, [INFO] [stdout] 152 | Err(e) => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/windows-0.46.0/src/core/unknown.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | impl Drop for IUnknown { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `e` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/windows-0.46.0/src/core/unknown.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | impl Drop for IUnknown { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/primitives/helpers.rs:183:15 [INFO] [stdout] | [INFO] [stdout] 183 | match unsafe { SafeArrayPutElement(variant_array_ptr, indices.as_ptr(), v_ref as *const _) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Err(e) => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/windows-0.46.0/src/core/unknown.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | impl Drop for IUnknown { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `e` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/windows-0.46.0/src/core/unknown.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | impl Drop for IUnknown { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clroxide` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "0d0883f2a10119b1d5ab6a96dd752b19e9e97a5acd322fef506a2f2833ce91a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d0883f2a10119b1d5ab6a96dd752b19e9e97a5acd322fef506a2f2833ce91a4", kill_on_drop: false }` [INFO] [stdout] 0d0883f2a10119b1d5ab6a96dd752b19e9e97a5acd322fef506a2f2833ce91a4