[INFO] fetching crate cloudr 1.3.0... [INFO] building cloudr-1.3.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate cloudr 1.3.0 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate cloudr 1.3.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cloudr 1.3.0 [INFO] finished tweaking crates.io crate cloudr 1.3.0 [INFO] tweaked toml for crates.io crate cloudr 1.3.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 25a44850abb79ee9bb1ae9a577050abd85f404b13b4683389f2863a1f601bd2b [INFO] running `Command { std: "docker" "start" "-a" "25a44850abb79ee9bb1ae9a577050abd85f404b13b4683389f2863a1f601bd2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "25a44850abb79ee9bb1ae9a577050abd85f404b13b4683389f2863a1f601bd2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25a44850abb79ee9bb1ae9a577050abd85f404b13b4683389f2863a1f601bd2b", kill_on_drop: false }` [INFO] [stdout] 25a44850abb79ee9bb1ae9a577050abd85f404b13b4683389f2863a1f601bd2b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90409e57e543e85f61317273194ba5cfa7a02fc69283973d7ca7b8d43259a187 [INFO] running `Command { std: "docker" "start" "-a" "90409e57e543e85f61317273194ba5cfa7a02fc69283973d7ca7b8d43259a187", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling fxhash v0.2.1 [INFO] [stderr] Compiling cloudr v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `suspicious_auto_trait_impls` has been removed: no longer needed, see issue #93367 for more information [INFO] [stdout] --> src/lib.rs:124:10 [INFO] [stdout] | [INFO] [stdout] 124 | #![allow(suspicious_auto_trait_impls)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/iter.rs:112:62 [INFO] [stdout] | [INFO] [stdout] 111 | impl<'a, K, V> IterMut<'a, K, V> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 112 | pub fn new(pairs: Vec<(&'a K, &'a mut &'a V)>) -> IterMut { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/cloud.rs:920:42 [INFO] [stdout] | [INFO] [stdout] 918 | for cloud in others.into_iter() { [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 919 | let mut iter = cloud.into_iter(); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] 920 | while let Some((key, val)) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 921 | new_cloud.insert(key, val); [INFO] [stdout] 922 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:712:48 [INFO] [stdout] | [INFO] [stdout] 712 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:716:48 [INFO] [stdout] | [INFO] [stdout] 716 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:743:48 [INFO] [stdout] | [INFO] [stdout] 743 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:748:52 [INFO] [stdout] | [INFO] [stdout] 748 | new_cloud.insert(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&V` instead of cloning the inner type [INFO] [stdout] --> src/cloud.rs:884:40 [INFO] [stdout] | [INFO] [stdout] 884 | new_map.insert(k.clone(), v.clone().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cloudr` (lib) due to 1 previous error; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "90409e57e543e85f61317273194ba5cfa7a02fc69283973d7ca7b8d43259a187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90409e57e543e85f61317273194ba5cfa7a02fc69283973d7ca7b8d43259a187", kill_on_drop: false }` [INFO] [stdout] 90409e57e543e85f61317273194ba5cfa7a02fc69283973d7ca7b8d43259a187