[INFO] fetching crate cita_trie 5.0.1... [INFO] building cita_trie-5.0.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate cita_trie 5.0.1 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate cita_trie 5.0.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cita_trie 5.0.1 [INFO] finished tweaking crates.io crate cita_trie 5.0.1 [INFO] tweaked toml for crates.io crate cita_trie 5.0.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 125 packages to latest compatible versions [INFO] [stderr] Adding ethereum-types v0.14.1 (available: v0.15.1) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rlp v0.5.2 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rlp v0.5.2 [INFO] [stderr] Downloaded impl-rlp v0.3.0 [INFO] [stderr] Downloaded impl-serde v0.4.0 [INFO] [stderr] Downloaded ethbloom v0.13.0 [INFO] [stderr] Downloaded hasher v0.1.4 [INFO] [stderr] Downloaded ethereum-types v0.14.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 667158cb7b137401d1d3d39bdc73c0817b68787f26c2c54ddc8e72f7569a6e36 [INFO] running `Command { std: "docker" "start" "-a" "667158cb7b137401d1d3d39bdc73c0817b68787f26c2c54ddc8e72f7569a6e36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "667158cb7b137401d1d3d39bdc73c0817b68787f26c2c54ddc8e72f7569a6e36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "667158cb7b137401d1d3d39bdc73c0817b68787f26c2c54ddc8e72f7569a6e36", kill_on_drop: false }` [INFO] [stdout] 667158cb7b137401d1d3d39bdc73c0817b68787f26c2c54ddc8e72f7569a6e36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 378b4bbf66b71ce2cbc5a813102768f003ba9bc0cf75b335b6b44998723a0499 [INFO] running `Command { std: "docker" "start" "-a" "378b4bbf66b71ce2cbc5a813102768f003ba9bc0cf75b335b6b44998723a0499", kill_on_drop: false }` [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling bytes v1.9.0 [INFO] [stderr] Compiling rustc-hex v2.1.0 [INFO] [stderr] Compiling hasher v0.1.4 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling rlp v0.5.2 [INFO] [stderr] Compiling cita_trie v5.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/trie.rs:769:17 [INFO] [stdout] | [INFO] [stdout] 764 | let borrow_leaf = leaf.borrow(); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `borrow_leaf` calls a custom destructor [INFO] [stdout] | `borrow_leaf` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 769 | stream.out().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 770 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/bytes-1.9.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `borrow_leaf` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/trie.rs:789:17 [INFO] [stdout] | [INFO] [stdout] 772 | let borrow_branch = branch.borrow(); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | `borrow_branch` calls a custom destructor [INFO] [stdout] | `borrow_branch` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 789 | stream.out().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 790 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/bytes-1.9.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `borrow_branch` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/trie.rs:802:17 [INFO] [stdout] | [INFO] [stdout] 792 | let borrow_ext = ext.borrow(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `borrow_ext` calls a custom destructor [INFO] [stdout] | `borrow_ext` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 802 | stream.out().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 803 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/bytes-1.9.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `borrow_ext` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/trie.rs:871:20 [INFO] [stdout] | [INFO] [stdout] 866 | let borrow_leaf = leaf.borrow(); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `borrow_leaf` calls a custom destructor [INFO] [stdout] | `borrow_leaf` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 871 | Ok(stream.out().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 872 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/bytes-1.9.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `borrow_leaf` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/trie.rs:891:20 [INFO] [stdout] | [INFO] [stdout] 874 | let borrow_branch = branch.borrow(); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | `borrow_branch` calls a custom destructor [INFO] [stdout] | `borrow_branch` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 891 | Ok(stream.out().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 892 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/bytes-1.9.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `borrow_branch` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/trie.rs:904:20 [INFO] [stdout] | [INFO] [stdout] 894 | let borrow_ext = ext.borrow(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `borrow_ext` calls a custom destructor [INFO] [stdout] | `borrow_ext` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 904 | Ok(stream.out().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 905 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/bytes-1.9.0/src/bytes_mut.rs:1123:1 [INFO] [stdout] | [INFO] [stdout] 1123 | impl Drop for BytesMut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `borrow_ext` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cita_trie` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "378b4bbf66b71ce2cbc5a813102768f003ba9bc0cf75b335b6b44998723a0499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "378b4bbf66b71ce2cbc5a813102768f003ba9bc0cf75b335b6b44998723a0499", kill_on_drop: false }` [INFO] [stdout] 378b4bbf66b71ce2cbc5a813102768f003ba9bc0cf75b335b6b44998723a0499