[INFO] fetching crate chargrid_common 0.7.4... [INFO] building chargrid_common-0.7.4 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate chargrid_common 0.7.4 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate chargrid_common 0.7.4 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chargrid_common 0.7.4 [INFO] finished tweaking crates.io crate chargrid_common 0.7.4 [INFO] tweaked toml for crates.io crate chargrid_common 0.7.4 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded grid_2d v0.15.3 [INFO] [stderr] Downloaded chargrid_input v0.6.1 [INFO] [stderr] Downloaded chargrid_core v0.4.0 [INFO] [stderr] Downloaded rgb_int v0.1.5 [INFO] [stderr] Downloaded coord_2d v0.3.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ecf34e91365bc9e90ec7dd700f29e0addc22b75b2a6e47c615006c6b460a5db [INFO] running `Command { std: "docker" "start" "-a" "1ecf34e91365bc9e90ec7dd700f29e0addc22b75b2a6e47c615006c6b460a5db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ecf34e91365bc9e90ec7dd700f29e0addc22b75b2a6e47c615006c6b460a5db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ecf34e91365bc9e90ec7dd700f29e0addc22b75b2a6e47c615006c6b460a5db", kill_on_drop: false }` [INFO] [stdout] 1ecf34e91365bc9e90ec7dd700f29e0addc22b75b2a6e47c615006c6b460a5db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19245ff251e60b79de9bcf738d45c74d6bbc55915dec04e13c76002615467810 [INFO] running `Command { std: "docker" "start" "-a" "19245ff251e60b79de9bcf738d45c74d6bbc55915dec04e13c76002615467810", kill_on_drop: false }` [INFO] [stderr] Compiling coord_2d v0.3.6 [INFO] [stderr] Compiling rgb_int v0.1.5 [INFO] [stderr] Compiling chargrid_input v0.6.1 [INFO] [stderr] Compiling grid_2d v0.15.3 [INFO] [stderr] Compiling chargrid_core v0.4.0 [INFO] [stderr] Compiling chargrid_common v0.7.4 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/control_flow/unboxed.rs:624:25 [INFO] [stdout] | [INFO] [stdout] 623 | while let Some(control) = [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `control` calls a custom destructor [INFO] [stdout] | `control` will be dropped later as of Edition 2024 [INFO] [stdout] 624 | self.component.update(&mut self.state, ctx, Event::Peek) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/control_flow/unboxed.rs:677:47 [INFO] [stdout] | [INFO] [stdout] 677 | while let Some(control) = self.component.update(state, ctx, Event::Peek) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `control` calls a custom destructor [INFO] [stdout] | `control` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 686 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/control_flow/unboxed.rs:726:47 [INFO] [stdout] | [INFO] [stdout] 726 | while let Some(control) = self.component.update(state, ctx, Event::Peek) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `control` calls a custom destructor [INFO] [stdout] | `control` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 735 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/control_flow/unboxed.rs:780:47 [INFO] [stdout] | [INFO] [stdout] 780 | while let Some(control) = self.component.update(state, ctx, Event::Peek) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `control` calls a custom destructor [INFO] [stdout] | `control` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 789 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chargrid_common` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "19245ff251e60b79de9bcf738d45c74d6bbc55915dec04e13c76002615467810", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19245ff251e60b79de9bcf738d45c74d6bbc55915dec04e13c76002615467810", kill_on_drop: false }` [INFO] [stdout] 19245ff251e60b79de9bcf738d45c74d6bbc55915dec04e13c76002615467810