[INFO] fetching crate cantrip 0.4.0... [INFO] building cantrip-0.4.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate cantrip 0.4.0 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate cantrip 0.4.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cantrip 0.4.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cantrip 0.4.0 [INFO] tweaked toml for crates.io crate cantrip 0.4.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d25ac94088f95b24784f8a4f910854085cdc6c931917d685c34afdfbd8e936ba [INFO] running `Command { std: "docker" "start" "-a" "d25ac94088f95b24784f8a4f910854085cdc6c931917d685c34afdfbd8e936ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d25ac94088f95b24784f8a4f910854085cdc6c931917d685c34afdfbd8e936ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d25ac94088f95b24784f8a4f910854085cdc6c931917d685c34afdfbd8e936ba", kill_on_drop: false }` [INFO] [stdout] d25ac94088f95b24784f8a4f910854085cdc6c931917d685c34afdfbd8e936ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ede8a6c793017a4626ea5e87a8882e38c6b6bcd7cd3c2c56fd8191e7499266f2 [INFO] running `Command { std: "docker" "start" "-a" "ede8a6c793017a4626ea5e87a8882e38c6b6bcd7cd3c2c56fd8191e7499266f2", kill_on_drop: false }` [INFO] [stderr] Compiling cantrip v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/extensions/collection_to.rs:1073:30 [INFO] [stdout] | [INFO] [stdout] 1072 | for item in iterator { [INFO] [stdout] | ---- -------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `item` calls a custom destructor [INFO] [stdout] | `item` will be dropped later as of Edition 2024 [INFO] [stdout] 1073 | if let Some(mut top) = heap.peek_mut() { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `top` calls a custom destructor [INFO] [stdout] | `top` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1078 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/collections/binary_heap/mod.rs:306:1 [INFO] [stdout] note: `top` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/collections/binary_heap/mod.rs:306:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/extensions/collection_to.rs:1261:13 [INFO] [stdout] | [INFO] [stdout] 1260 | for item in self.into_iter() { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 1261 | match function(item) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1265 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/extensions/collection_to.rs:1435:30 [INFO] [stdout] | [INFO] [stdout] 1434 | for item in iterator { [INFO] [stdout] | ---- -------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `item` calls a custom destructor [INFO] [stdout] | `item` will be dropped later as of Edition 2024 [INFO] [stdout] 1435 | if let Some(mut top) = heap.peek_mut() { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `top` calls a custom destructor [INFO] [stdout] | `top` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1440 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/collections/binary_heap/mod.rs:306:1 [INFO] [stdout] note: `top` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/collections/binary_heap/mod.rs:306:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/extensions/map.rs:1646:13 [INFO] [stdout] | [INFO] [stdout] 1645 | for item in self.into_iter() { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 1646 | match function(item) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1650 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/extensions/sequence_to.rs:569:29 [INFO] [stdout] | [INFO] [stdout] 569 | if let Some(item) = iterator.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 570 | let key = to_key(&item); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `key` calls a custom destructor [INFO] [stdout] | `key` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let _unused = occurred.insert(key, Some(item)); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `_unused` calls a custom destructor [INFO] [stdout] | `_unused` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | }) [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cantrip` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "ede8a6c793017a4626ea5e87a8882e38c6b6bcd7cd3c2c56fd8191e7499266f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ede8a6c793017a4626ea5e87a8882e38c6b6bcd7cd3c2c56fd8191e7499266f2", kill_on_drop: false }` [INFO] [stdout] ede8a6c793017a4626ea5e87a8882e38c6b6bcd7cd3c2c56fd8191e7499266f2