[INFO] fetching crate bztree 0.2.0... [INFO] building bztree-0.2.0 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate bztree 0.2.0 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate bztree 0.2.0 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bztree 0.2.0 [INFO] finished tweaking crates.io crate bztree 0.2.0 [INFO] tweaked toml for crates.io crate bztree 0.2.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 87 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding jemallocator v0.3.2 (available: v0.5.4) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded mwcas v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f463f2b075828dc7d1fdb1ac6133c6d127da63b526d74f673b101baa53cdbdc [INFO] running `Command { std: "docker" "start" "-a" "5f463f2b075828dc7d1fdb1ac6133c6d127da63b526d74f673b101baa53cdbdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f463f2b075828dc7d1fdb1ac6133c6d127da63b526d74f673b101baa53cdbdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f463f2b075828dc7d1fdb1ac6133c6d127da63b526d74f673b101baa53cdbdc", kill_on_drop: false }` [INFO] [stdout] 5f463f2b075828dc7d1fdb1ac6133c6d127da63b526d74f673b101baa53cdbdc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b2bfd411517f80b7777cdd342d258adc3e04cb3d7dfece8cc2a3f0fb8ca14ef [INFO] running `Command { std: "docker" "start" "-a" "0b2bfd411517f80b7777cdd342d258adc3e04cb3d7dfece8cc2a3f0fb8ca14ef", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling mwcas v0.2.0 [INFO] [stderr] Compiling bztree v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/node/mod.rs:376:92 [INFO] [stdout] | [INFO] [stdout] 376 | pub fn range<'g, Q, Range>(&'g self, key_range: Range, guard: &'g Guard) -> NodeScanner [INFO] [stdout] | -- lifetime `'g` declared here ^ this elided lifetime gets resolved as `'g` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/node/mod.rs:385:63 [INFO] [stdout] | [INFO] [stdout] 385 | pub fn iter<'g>(&'g self, guard: &'g Guard) -> NodeScanner [INFO] [stdout] | -- lifetime `'g` declared here ^ this elided lifetime gets resolved as `'g` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:147:19 [INFO] [stdout] | [INFO] [stdout] 147 | match node.insert(key.clone(), value, guard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let path = self.find_path_to_key(&search_key, false, guard); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `path` calls a custom destructor [INFO] [stdout] | `path` will be dropped later as of Edition 2024 [INFO] [stdout] 156 | if let Some(path) = path { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:537:49 [INFO] [stdout] | [INFO] [stdout] 531 | match node.conditional_upsert(found_key.clone(), new_val, status_word, guard) { [INFO] [stdout] | ----------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 537 | if let Some(path) = self.find_path_to_key(&search_key, false, guard) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `path` calls a custom destructor [INFO] [stdout] | `path` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 545 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:530:40 [INFO] [stdout] | [INFO] [stdout] 530 | if let Some(new_val) = new_val((found_key, val)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 531 | match node.conditional_upsert(found_key.clone(), new_val, status_word, guard) { [INFO] [stdout] | ----------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 537 | if let Some(path) = self.find_path_to_key(&search_key, false, guard) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `path` calls a custom destructor [INFO] [stdout] | `path` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 564 | } else { [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:978:31 [INFO] [stdout] | [INFO] [stdout] 956 | Leaf(other) => match node.merge_with_leaf(other, self.node_size, guard) { [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 978 | match node.merge_with_interim( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 979 | | other, [INFO] [stdout] 980 | | node.estimated_len(guard) + other.estimated_len(guard), [INFO] [stdout] 981 | | guard, [INFO] [stdout] 982 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 998 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/node/mod.rs:1009:1 [INFO] [stdout] | [INFO] [stdout] 1009 | / impl Drop for Node { [INFO] [stdout] 1010 | | fn drop(&mut self) { [INFO] [stdout] ... | [INFO] [stdout] 1027 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/node/mod.rs:1009:1 [INFO] [stdout] | [INFO] [stdout] 1009 | / impl Drop for Node { [INFO] [stdout] 1010 | | fn drop(&mut self) { [INFO] [stdout] ... | [INFO] [stdout] 1027 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: casting `&T` to `&mut T` is undefined behavior, even if the reference is unused, consider instead using an `UnsafeCell` [INFO] [stdout] --> src/node/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | unsafe { &mut *($node as *const Node as *mut Node) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 180 | let entry = &mut deref_mut!(self).data_block[index]; [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, visit [INFO] [stdout] = note: even for types with interior mutability, the only legal way to obtain a mutable pointer from a shared reference is through `UnsafeCell::get` [INFO] [stdout] = note: `#[deny(invalid_reference_casting)]` on by default [INFO] [stdout] = note: this error originates in the macro `deref_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: casting `&T` to `&mut T` is undefined behavior, even if the reference is unused, consider instead using an `UnsafeCell` [INFO] [stdout] --> src/node/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | unsafe { &mut *($node as *const Node as *mut Node) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 226 | let entry = &mut deref_mut!(self).data_block[kv_index]; [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, visit [INFO] [stdout] = note: even for types with interior mutability, the only legal way to obtain a mutable pointer from a shared reference is through `UnsafeCell::get` [INFO] [stdout] = note: this error originates in the macro `deref_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: casting `&T` to `&mut T` is undefined behavior, even if the reference is unused, consider instead using an `UnsafeCell` [INFO] [stdout] --> src/node/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | unsafe { &mut *($node as *const Node as *mut Node) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 325 | let entry = &mut deref_mut!(self).data_block[index]; [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, visit [INFO] [stdout] = note: even for types with interior mutability, the only legal way to obtain a mutable pointer from a shared reference is through `UnsafeCell::get` [INFO] [stdout] = note: this error originates in the macro `deref_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: casting `&T` to `&mut T` is undefined behavior, even if the reference is unused, consider instead using an `UnsafeCell` [INFO] [stdout] --> src/node/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | unsafe { &mut *($node as *const Node as *mut Node) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 888 | let self_mut = deref_mut!(self); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, visit [INFO] [stdout] = note: even for types with interior mutability, the only legal way to obtain a mutable pointer from a shared reference is through `UnsafeCell::get` [INFO] [stdout] = note: this error originates in the macro `deref_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bztree` (lib) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0b2bfd411517f80b7777cdd342d258adc3e04cb3d7dfece8cc2a3f0fb8ca14ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b2bfd411517f80b7777cdd342d258adc3e04cb3d7dfece8cc2a3f0fb8ca14ef", kill_on_drop: false }` [INFO] [stdout] 0b2bfd411517f80b7777cdd342d258adc3e04cb3d7dfece8cc2a3f0fb8ca14ef