[INFO] fetching crate btree_experiment 0.1.106... [INFO] building btree_experiment-0.1.106 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate btree_experiment 0.1.106 into /workspace/builds/worker-2-tc1/source [INFO] validating manifest of crates.io crate btree_experiment 0.1.106 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate btree_experiment 0.1.106 [INFO] finished tweaking crates.io crate btree_experiment 0.1.106 [INFO] tweaked toml for crates.io crate btree_experiment 0.1.106 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cap v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9e2a22f241a47a8b7038b091c0825b1b9183787a2e7f05f4f39643694b3fb89 [INFO] running `Command { std: "docker" "start" "-a" "b9e2a22f241a47a8b7038b091c0825b1b9183787a2e7f05f4f39643694b3fb89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9e2a22f241a47a8b7038b091c0825b1b9183787a2e7f05f4f39643694b3fb89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9e2a22f241a47a8b7038b091c0825b1b9183787a2e7f05f4f39643694b3fb89", kill_on_drop: false }` [INFO] [stdout] b9e2a22f241a47a8b7038b091c0825b1b9183787a2e7f05f4f39643694b3fb89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c3d383ddb0c99e23c29cb7c859d91071b08125cdf7c82d4452c88a58860bde7 [INFO] running `Command { std: "docker" "start" "-a" "2c3d383ddb0c99e23c29cb7c859d91071b08125cdf7c82d4452c88a58860bde7", kill_on_drop: false }` [INFO] [stderr] Compiling btree_experiment v0.1.106 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1891:42 [INFO] [stdout] | [INFO] [stdout] 1879 | if let Some(kv) = s.v.next() { [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1885 | self.fwd_stk.pop(); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1891 | if let Some(x) = self.fwd_leaf.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1894 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:377:1 [INFO] [stdout] | [INFO] [stdout] 377 | / impl Drop for IntoIterShortVec { [INFO] [stdout] 378 | | fn drop(&mut self) { [INFO] [stdout] 379 | | while self.len() > 0 { [INFO] [stdout] 380 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 384 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:889:1 [INFO] [stdout] | [INFO] [stdout] 889 | / impl Drop for IntoIterPairVec { [INFO] [stdout] 890 | | fn drop(&mut self) { [INFO] [stdout] 891 | | while self.ix != self.ixb { [INFO] [stdout] 892 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 896 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1887:23 [INFO] [stdout] | [INFO] [stdout] 1879 | if let Some(kv) = s.v.next() { [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1885 | self.fwd_stk.pop(); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 1886 | } else { [INFO] [stdout] 1887 | match self.steal_bck() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1896 | if let Some(x) = self.bck_leaf.next() { [INFO] [stdout] | -------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1902 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | / impl Drop for ShortVec { [INFO] [stdout] 176 | | fn drop(&mut self) { [INFO] [stdout] 177 | | let mut len = self.len as usize; [INFO] [stdout] 178 | | while len > 0 { [INFO] [stdout] ... | [INFO] [stdout] 187 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:406:1 [INFO] [stdout] | [INFO] [stdout] 406 | / impl Drop for PairVec { [INFO] [stdout] 407 | | fn drop(&mut self) { [INFO] [stdout] 408 | | while self.len != 0 { [INFO] [stdout] 409 | | self.pop(); [INFO] [stdout] ... | [INFO] [stdout] 413 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:377:1 [INFO] [stdout] | [INFO] [stdout] 377 | / impl Drop for IntoIterShortVec { [INFO] [stdout] 378 | | fn drop(&mut self) { [INFO] [stdout] 379 | | while self.len() > 0 { [INFO] [stdout] 380 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 384 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:889:1 [INFO] [stdout] | [INFO] [stdout] 889 | / impl Drop for IntoIterPairVec { [INFO] [stdout] 890 | | fn drop(&mut self) { [INFO] [stdout] 891 | | while self.ix != self.ixb { [INFO] [stdout] 892 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 896 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1921:42 [INFO] [stdout] | [INFO] [stdout] 1909 | if let Some(kv) = s.v.next_back() { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1915 | self.bck_stk.pop(); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1921 | if let Some(x) = self.bck_leaf.next_back() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1924 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:377:1 [INFO] [stdout] | [INFO] [stdout] 377 | / impl Drop for IntoIterShortVec { [INFO] [stdout] 378 | | fn drop(&mut self) { [INFO] [stdout] 379 | | while self.len() > 0 { [INFO] [stdout] 380 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 384 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:889:1 [INFO] [stdout] | [INFO] [stdout] 889 | / impl Drop for IntoIterPairVec { [INFO] [stdout] 890 | | fn drop(&mut self) { [INFO] [stdout] 891 | | while self.ix != self.ixb { [INFO] [stdout] 892 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 896 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1917:23 [INFO] [stdout] | [INFO] [stdout] 1909 | if let Some(kv) = s.v.next_back() { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1915 | self.bck_stk.pop(); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] 1916 | } else { [INFO] [stdout] 1917 | match self.steal_fwd() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1926 | if let Some(x) = self.fwd_leaf.next_back() { [INFO] [stdout] | ------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1932 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | / impl Drop for ShortVec { [INFO] [stdout] 176 | | fn drop(&mut self) { [INFO] [stdout] 177 | | let mut len = self.len as usize; [INFO] [stdout] 178 | | while len > 0 { [INFO] [stdout] ... | [INFO] [stdout] 187 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:406:1 [INFO] [stdout] | [INFO] [stdout] 406 | / impl Drop for PairVec { [INFO] [stdout] 407 | | fn drop(&mut self) { [INFO] [stdout] 408 | | while self.len != 0 { [INFO] [stdout] 409 | | self.pop(); [INFO] [stdout] ... | [INFO] [stdout] 413 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:377:1 [INFO] [stdout] | [INFO] [stdout] 377 | / impl Drop for IntoIterShortVec { [INFO] [stdout] 378 | | fn drop(&mut self) { [INFO] [stdout] 379 | | while self.len() > 0 { [INFO] [stdout] 380 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 384 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/vecs.rs:889:1 [INFO] [stdout] | [INFO] [stdout] 889 | / impl Drop for IntoIterPairVec { [INFO] [stdout] 890 | | fn drop(&mut self) { [INFO] [stdout] 891 | | while self.ix != self.ixb { [INFO] [stdout] 892 | | self.next(); [INFO] [stdout] ... | [INFO] [stdout] 896 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `btree_experiment` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "2c3d383ddb0c99e23c29cb7c859d91071b08125cdf7c82d4452c88a58860bde7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c3d383ddb0c99e23c29cb7c859d91071b08125cdf7c82d4452c88a58860bde7", kill_on_drop: false }` [INFO] [stdout] 2c3d383ddb0c99e23c29cb7c859d91071b08125cdf7c82d4452c88a58860bde7