[INFO] fetching crate argparsnip 0.1.6... [INFO] building argparsnip-0.1.6 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate argparsnip 0.1.6 into /workspace/builds/worker-2-tc1/source [INFO] validating manifest of crates.io crate argparsnip 0.1.6 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate argparsnip 0.1.6 [INFO] finished tweaking crates.io crate argparsnip 0.1.6 [INFO] tweaked toml for crates.io crate argparsnip 0.1.6 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 137 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.2.1 (available: v1.3.2) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding hashbrown v0.11.2 (available: v0.15.2) [INFO] [stderr] Adding pprof v0.4.5 (available: v0.14.0) [INFO] [stderr] Adding pretty_assertions v0.7.2 (available: v1.4.1) [INFO] [stderr] Adding simple_logger v1.16.0 (available: v5.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded inferno v0.10.12 [INFO] [stderr] Downloaded pprof v0.4.5 [INFO] [stderr] Downloaded symbolic-demangle v8.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1acc832a95887791f8fc9e0e78e26358303796405fdf1c7653be02bd24ff166b [INFO] running `Command { std: "docker" "start" "-a" "1acc832a95887791f8fc9e0e78e26358303796405fdf1c7653be02bd24ff166b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1acc832a95887791f8fc9e0e78e26358303796405fdf1c7653be02bd24ff166b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1acc832a95887791f8fc9e0e78e26358303796405fdf1c7653be02bd24ff166b", kill_on_drop: false }` [INFO] [stdout] 1acc832a95887791f8fc9e0e78e26358303796405fdf1c7653be02bd24ff166b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e1e5bfab285e1bb78fba78d90652fb6dd5448f6965340cbd43dff4d3779b903b [INFO] running `Command { std: "docker" "start" "-a" "e1e5bfab285e1bb78fba78d90652fb6dd5448f6965340cbd43dff4d3779b903b", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling argparsnip v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:338:107 [INFO] [stdout] | [INFO] [stdout] 331 | trait ArgsMethods<'a, R, S: IntoStr, T: Iterator> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 338 | fn update_values(&'a self, arg: &'a Arg, args: &mut Peekable, out: &mut Builder<'a>) -> Result<(), Error>; [INFO] [stdout] | ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:342:101 [INFO] [stdout] | [INFO] [stdout] 331 | trait ArgsMethods<'a, R, S: IntoStr, T: Iterator> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 342 | fn handle_arg(&'a self, arg: &str, args: &mut Peekable, out: &mut Builder<'a>) -> Result<(), Error>; [INFO] [stdout] | ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:344:46 [INFO] [stdout] | [INFO] [stdout] 331 | trait ArgsMethods<'a, R, S: IntoStr, T: Iterator> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 344 | fn apply(&'a self, args: T) -> Result; [INFO] [stdout] | ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:386:107 [INFO] [stdout] | [INFO] [stdout] 347 | impl<'a, R, S: IntoStr, T: Iterator> ArgsMethods<'a, R, S, T> for Args<'a, R> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 386 | fn update_values(&'a self, arg: &'a Arg, args: &mut Peekable, out: &mut Builder<'a>) -> Result<(), Error> { [INFO] [stdout] | ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:434:101 [INFO] [stdout] | [INFO] [stdout] 347 | impl<'a, R, S: IntoStr, T: Iterator> ArgsMethods<'a, R, S, T> for Args<'a, R> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 434 | fn handle_arg(&'a self, arg: &str, args: &mut Peekable, out: &mut Builder<'a>) -> Result<(), Error> { [INFO] [stdout] | ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:476:46 [INFO] [stdout] | [INFO] [stdout] 347 | impl<'a, R, S: IntoStr, T: Iterator> ArgsMethods<'a, R, S, T> for Args<'a, R> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 476 | fn apply(&'a self, args: T) -> Result { [INFO] [stdout] | ^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:486:29 [INFO] [stdout] | [INFO] [stdout] 486 | while let Some(a) = args.next() { [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `a` calls a custom destructor [INFO] [stdout] | `a` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/value.rs:218:52 [INFO] [stdout] | [INFO] [stdout] 218 | Type::Any | Type::String => Value::from(val.clone()), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `argparsnip` (lib) due to 1 previous error; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e1e5bfab285e1bb78fba78d90652fb6dd5448f6965340cbd43dff4d3779b903b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1e5bfab285e1bb78fba78d90652fb6dd5448f6965340cbd43dff4d3779b903b", kill_on_drop: false }` [INFO] [stdout] e1e5bfab285e1bb78fba78d90652fb6dd5448f6965340cbd43dff4d3779b903b