[INFO] fetching crate afire 3.0.0-alpha.3... [INFO] building afire-3.0.0-alpha.3 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate afire 3.0.0-alpha.3 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate afire 3.0.0-alpha.3 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate afire 3.0.0-alpha.3 [INFO] finished tweaking crates.io crate afire 3.0.0-alpha.3 [INFO] tweaked toml for crates.io crate afire 3.0.0-alpha.3 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate crates.io crate afire 3.0.0-alpha.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4cbe78cfdb6ca8c6abd58cf315a11dd869f3e38d2e3d3e119008cb963a908a0 [INFO] running `Command { std: "docker" "start" "-a" "c4cbe78cfdb6ca8c6abd58cf315a11dd869f3e38d2e3d3e119008cb963a908a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4cbe78cfdb6ca8c6abd58cf315a11dd869f3e38d2e3d3e119008cb963a908a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4cbe78cfdb6ca8c6abd58cf315a11dd869f3e38d2e3d3e119008cb963a908a0", kill_on_drop: false }` [INFO] [stdout] c4cbe78cfdb6ca8c6abd58cf315a11dd869f3e38d2e3d3e119008cb963a908a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb873a8c48559df5b3070dc5a4583455e4752a7c6746dc2bcbf9819b9897e1ed [INFO] running `Command { std: "docker" "start" "-a" "cb873a8c48559df5b3070dc5a4583455e4752a7c6746dc2bcbf9819b9897e1ed", kill_on_drop: false }` [INFO] [stderr] Compiling afire v3.0.0-alpha.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> lib/proto/http/multipart.rs:53:67 [INFO] [stdout] | [INFO] [stdout] 46 | impl<'a> MultipartData<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn get_mut(&'a mut self, name: impl AsRef) -> Option<&mut MultipartEntry> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> lib/proto/http/multipart.rs:53:72 [INFO] [stdout] | [INFO] [stdout] 46 | impl<'a> MultipartData<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn get_mut(&'a mut self, name: impl AsRef) -> Option<&mut MultipartEntry> { [INFO] [stdout] | ^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> lib/internal/handle.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | match i.pre_raw(&mut req) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | up until Edition 2021 `#5` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 76 | let req = match req.map(Arc::new) { [INFO] [stdout] | --- ----------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `req` calls a custom destructor [INFO] [stdout] | `req` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut ctx = Context::new(this.clone(), req.clone()); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `ctx` calls a custom destructor [INFO] [stdout] | `ctx` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let result = (route.handler)(&ctx); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | if let Err(e) = result { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | } else if let Err(e) = this [INFO] [stdout] | _________________________________-____- [INFO] [stdout] | | _______________________________|____| [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 126 | | | .clone() [INFO] [stdout] | | | - [INFO] [stdout] | | | | [INFO] [stdout] | | |________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 127 | | .error_handler [INFO] [stdout] 128 | | .handle(&ctx, RouteError::downcast_error(e)) [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |______________________________________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#5` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `req` invokes this custom destructor [INFO] [stdout] --> lib/internal/socket.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / impl Drop for Socket { [INFO] [stdout] 129 | | fn drop(&mut self) { [INFO] [stdout] 130 | | trace!(Level::Debug, "Dropping socket {}", self.id); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> lib/internal/socket.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / impl Drop for Socket { [INFO] [stdout] 129 | | fn drop(&mut self) { [INFO] [stdout] 130 | | trace!(Level::Debug, "Dropping socket {}", self.id); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `ctx` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `ctx` invokes this custom destructor [INFO] [stdout] --> lib/internal/socket.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / impl Drop for Socket { [INFO] [stdout] 129 | | fn drop(&mut self) { [INFO] [stdout] 130 | | trace!(Level::Debug, "Dropping socket {}", self.id); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `ctx` invokes this custom destructor [INFO] [stdout] --> lib/internal/thread_pool.rs:260:1 [INFO] [stdout] | [INFO] [stdout] 260 | / impl Drop for ThreadPool { [INFO] [stdout] 261 | | /// Stops all workers with a kill message, and waits for them to finish. [INFO] [stdout] 262 | | fn drop(&mut self) { [INFO] [stdout] 263 | | trace!( [INFO] [stdout] ... | [INFO] [stdout] 277 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> lib/internal/thread_pool.rs:260:1 [INFO] [stdout] | [INFO] [stdout] 260 | / impl Drop for ThreadPool { [INFO] [stdout] 261 | | /// Stops all workers with a kill message, and waits for them to finish. [INFO] [stdout] 262 | | fn drop(&mut self) { [INFO] [stdout] 263 | | trace!( [INFO] [stdout] ... | [INFO] [stdout] 277 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> lib/internal/handle.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 159 | mut response: Result, [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | `response` calls a custom destructor [INFO] [stdout] | `response` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | match i.post_raw(request.clone(), &mut response) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `response` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `take` is never used [INFO] [stdout] --> lib/response.rs:351:19 [INFO] [stdout] | [INFO] [stdout] 350 | impl ResponseBody { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] 351 | pub(crate) fn take(&mut self) -> ResponseBody { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `afire` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cb873a8c48559df5b3070dc5a4583455e4752a7c6746dc2bcbf9819b9897e1ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb873a8c48559df5b3070dc5a4583455e4752a7c6746dc2bcbf9819b9897e1ed", kill_on_drop: false }` [INFO] [stdout] cb873a8c48559df5b3070dc5a4583455e4752a7c6746dc2bcbf9819b9897e1ed