[INFO] fetching crate afeather 0.0.1... [INFO] building afeather-0.0.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate afeather 0.0.1 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate afeather 0.0.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate afeather 0.0.1 [INFO] finished tweaking crates.io crate afeather 0.0.1 [INFO] tweaked toml for crates.io crate afeather 0.0.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded extend-lifetime v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c2acc538b0a6ba888f018019b88b349f92d693ca47baa363580405ca18b23ec [INFO] running `Command { std: "docker" "start" "-a" "7c2acc538b0a6ba888f018019b88b349f92d693ca47baa363580405ca18b23ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c2acc538b0a6ba888f018019b88b349f92d693ca47baa363580405ca18b23ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c2acc538b0a6ba888f018019b88b349f92d693ca47baa363580405ca18b23ec", kill_on_drop: false }` [INFO] [stdout] 7c2acc538b0a6ba888f018019b88b349f92d693ca47baa363580405ca18b23ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 190e0dd49b1fcfe1e9d474c55c8f370058a635f9a5d8faf6b802d1e834f51f59 [INFO] running `Command { std: "docker" "start" "-a" "190e0dd49b1fcfe1e9d474c55c8f370058a635f9a5d8faf6b802d1e834f51f59", kill_on_drop: false }` [INFO] [stderr] Compiling extend-lifetime v0.2.0 [INFO] [stderr] Compiling afeather v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/world.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | let storage = T::get(&self.globals, &archetype.unwrap().components)?; [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `storage` calls a custom destructor [INFO] [stdout] | `storage` will be dropped later as of Edition 2024 [INFO] [stdout] 52 | storage.borrow().read(slot.entity_index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 53 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/world.rs:123:42 [INFO] [stdout] | [INFO] [stdout] 122 | if let Some(read) = T::Reads::get(&self.globals, &archetype.components) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `read` calls a custom destructor [INFO] [stdout] | `read` will be dropped later as of Edition 2024 [INFO] [stdout] 123 | if let Some(write) = T::Writes::get_mut(archetype) { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `write` calls a custom destructor [INFO] [stdout] | `write` will be dropped later as of Edition 2024 [INFO] [stdout] 124 | let read_borrow = read.borrow(); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `read_borrow` calls a custom destructor [INFO] [stdout] | `read_borrow` will be dropped later as of Edition 2024 [INFO] [stdout] 125 | let mut write_borrow = write.borrow_mut(); [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | `write_borrow` calls a custom destructor [INFO] [stdout] | `write_borrow` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/world.rs:122:37 [INFO] [stdout] | [INFO] [stdout] 122 | if let Some(read) = T::Reads::get(&self.globals, &archetype.components) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `read` calls a custom destructor [INFO] [stdout] | `read` will be dropped later as of Edition 2024 [INFO] [stdout] 123 | if let Some(write) = T::Writes::get_mut(archetype) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `write` calls a custom destructor [INFO] [stdout] | `write` will be dropped later as of Edition 2024 [INFO] [stdout] 124 | let read_borrow = read.borrow(); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | `read_borrow` calls a custom destructor [INFO] [stdout] | `read_borrow` will be dropped later as of Edition 2024 [INFO] [stdout] 125 | let mut write_borrow = write.borrow_mut(); [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | `write_borrow` calls a custom destructor [INFO] [stdout] | `write_borrow` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/update.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | if let Some(storage) = archetype [INFO] [stdout] | _____________________________-------____^ [INFO] [stdout] | | | [INFO] [stdout] | | `storage` calls a custom destructor [INFO] [stdout] | | `storage` will be dropped later as of Edition 2024 [INFO] [stdout] 29 | | .as_ref() [INFO] [stdout] 30 | | .and_then(|a| T::Reads::get(world_storage, &a.components)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |______________________________________________________________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 31 | { [INFO] [stdout] 32 | let borrow = storage.borrow(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `borrow` calls a custom destructor [INFO] [stdout] | `borrow` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `afeather` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "190e0dd49b1fcfe1e9d474c55c8f370058a635f9a5d8faf6b802d1e834f51f59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "190e0dd49b1fcfe1e9d474c55c8f370058a635f9a5d8faf6b802d1e834f51f59", kill_on_drop: false }` [INFO] [stdout] 190e0dd49b1fcfe1e9d474c55c8f370058a635f9a5d8faf6b802d1e834f51f59