[INFO] fetching crate Algod 0.1.1... [INFO] building Algod-0.1.1 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] extracting crate Algod 0.1.1 into /workspace/builds/worker-2-tc1/source [INFO] validating manifest of crates.io crate Algod 0.1.1 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate Algod 0.1.1 [INFO] finished tweaking crates.io crate Algod 0.1.1 [INFO] tweaked toml for crates.io crate Algod 0.1.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5348aecff058261909ffa64dd9a67f2cc5217691be125ab3a24724ed56829ed9 [INFO] running `Command { std: "docker" "start" "-a" "5348aecff058261909ffa64dd9a67f2cc5217691be125ab3a24724ed56829ed9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5348aecff058261909ffa64dd9a67f2cc5217691be125ab3a24724ed56829ed9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5348aecff058261909ffa64dd9a67f2cc5217691be125ab3a24724ed56829ed9", kill_on_drop: false }` [INFO] [stdout] 5348aecff058261909ffa64dd9a67f2cc5217691be125ab3a24724ed56829ed9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24013e210594ddd902b7374569cb73acf3afa84e49184dd5db4d1bf64e47f9af [INFO] running `Command { std: "docker" "start" "-a" "24013e210594ddd902b7374569cb73acf3afa84e49184dd5db4d1bf64e47f9af", kill_on_drop: false }` [INFO] [stderr] Compiling Algod v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/ciphers/sha256.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 135 | chunk[(63 - i)] = len as u8; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - chunk[(63 - i)] = len as u8; [INFO] [stdout] 135 + chunk[63 - i] = len as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/graph/depth_first_search_tic_tac_toe.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | let mut play_actions = opt_play_actions.as_mut().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/string/aho_corasick.rs:35:34 [INFO] [stdout] | [INFO] [stdout] 35 | while let Some(parent) = q.pop_front() { [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | | up until Edition 2021 `#8` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `parent` calls a custom destructor [INFO] [stdout] | `parent` will be dropped later as of Edition 2024 [INFO] [stdout] 36 | let parent = parent.borrow(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut child = child.borrow_mut(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `child` calls a custom destructor [INFO] [stdout] | `child` will be dropped later as of Edition 2024 [INFO] [stdout] 40 | let mut suffix = parent.suffix.upgrade(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `suffix` calls a custom destructor [INFO] [stdout] | `suffix` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | child.lengths.extend(root.borrow().lengths.clone()); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | if node.borrow().trans.contains_key(c) { [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 50 | let node = &node.borrow().trans[c]; [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 51 | child.lengths.extend(node.borrow().lengths.clone()); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | suffix = suffix.unwrap().borrow().suffix.upgrade(); [INFO] [stdout] | ------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `parent` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `child` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `suffix` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/string/aho_corasick.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 73 | let suffix = cur.borrow().suffix.clone(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | `suffix` calls a custom destructor [INFO] [stdout] | `suffix` will be dropped later as of Edition 2024 [INFO] [stdout] 74 | match suffix.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `suffix` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `add_edge`, `neighbours`, `contains`, `nodes`, and `edges` are never used [INFO] [stdout] --> src/data_structures/graph.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 64 | pub trait Graph { [INFO] [stdout] | ----- associated items in this trait [INFO] [stdout] 65 | fn new() -> Self; [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | fn add_edge(&mut self, edge: (&str, &str, i32)) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | fn neighbours(&self, node: &str) -> Result<&Vec<(String, i32)>, NodeNotInGraph> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn contains(&self, node: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | fn nodes(&self) -> HashSet<&String> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | fn edges(&self) -> Vec<(&String, &String, i32)> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `Algod` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `algod` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/data_structures/rb_tree.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | Box::from_raw(node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 218 | let _ = Box::from_raw(node); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `Algod` (lib) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "24013e210594ddd902b7374569cb73acf3afa84e49184dd5db4d1bf64e47f9af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24013e210594ddd902b7374569cb73acf3afa84e49184dd5db4d1bf64e47f9af", kill_on_drop: false }` [INFO] [stdout] 24013e210594ddd902b7374569cb73acf3afa84e49184dd5db4d1bf64e47f9af