[INFO] cloning repository https://github.com/zmack/rust-socks [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zmack/rust-socks" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzmack%2Frust-socks", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzmack%2Frust-socks'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 84d89d46e7eab9a12771376080e981ae84b96e3e [INFO] building zmack/rust-socks against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzmack%2Frust-socks" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zmack/rust-socks on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zmack/rust-socks [INFO] finished tweaking git repo https://github.com/zmack/rust-socks [INFO] tweaked toml for git repo https://github.com/zmack/rust-socks written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/zmack/rust-socks already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 616bb2b245153071c08a080cb5dca8a2afcca6c978c56c900207141f1d52e270 [INFO] running `Command { std: "docker" "start" "-a" "616bb2b245153071c08a080cb5dca8a2afcca6c978c56c900207141f1d52e270", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "616bb2b245153071c08a080cb5dca8a2afcca6c978c56c900207141f1d52e270", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "616bb2b245153071c08a080cb5dca8a2afcca6c978c56c900207141f1d52e270", kill_on_drop: false }` [INFO] [stdout] 616bb2b245153071c08a080cb5dca8a2afcca6c978c56c900207141f1d52e270 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1c8ad25c24f3547a389e4021cc26582f979b11ba3a61da71a1e23d98383db53 [INFO] running `Command { std: "docker" "start" "-a" "f1c8ad25c24f3547a389e4021cc26582f979b11ba3a61da71a1e23d98383db53", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling log v0.3.6 [INFO] [stderr] Compiling byteorder v0.5.3 [INFO] [stderr] Compiling rust-socks v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error[E0432]: unresolved import `std::net::lookup_host` [INFO] [stdout] --> src/dns_cache.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::lookup_host; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ no `lookup_host` in `net` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::os` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::os; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error` and `io` [INFO] [stdout] --> src/main.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use std::{io, error}; [INFO] [stdout] | ^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpStream` [INFO] [stdout] --> src/main.rs:8:29 [INFO] [stdout] | [INFO] [stdout] 8 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ClientTracker` [INFO] [stdout] --> src/main.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | use client_tracker::{ClientTracker, ClientTrackers}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Ipv4Addr` and `SocketAddr` [INFO] [stdout] --> src/configuration.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | use std::net::{IpAddr, Ipv4Addr, SocketAddr}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/client_tracker.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::os` [INFO] [stdout] --> src/server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::os; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error` and `io` [INFO] [stdout] --> src/server.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{io, error}; [INFO] [stdout] | ^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/server.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IpAddr` [INFO] [stdout] --> src/server.rs:9:16 [INFO] [stdout] | [INFO] [stdout] 9 | use std::net::{IpAddr, Ipv4Addr, SocketAddr, SocketAddrV4}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ClientTracker` [INFO] [stdout] --> src/server.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | use client_tracker::{ClientTracker, ClientTrackers}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `configuration::Configuration` [INFO] [stdout] --> src/server.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use configuration::Configuration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LittleEndian` and `WriteBytesExt` [INFO] [stdout] --> src/server.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | use server::byteorder::{BigEndian, LittleEndian, ReadBytesExt, WriteBytesExt}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0635]: unknown feature `lookup_host` [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(lookup_host)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/logger.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 32 | / loop { [INFO] [stdout] 33 | | match rx.recv() { [INFO] [stdout] 34 | | Ok(Msg::Log(message)) => { [INFO] [stdout] 35 | | println!("Got {}", message); [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 41 | file.flush(); [INFO] [stdout] | ^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dns_cache.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let mut cache = DnsCache { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dns_cache.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let mut store = HashMap::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/configuration.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut reader = BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/configuration.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut reader = BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rx` [INFO] [stdout] --> src/client_tracker.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | let (tx, rx) = channel(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let mut outbound = TcpStream::connect(addr).unwrap(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/main.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | let args = std::env::args(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bind_address` [INFO] [stdout] --> src/main.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | let bind_address:&str; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bind_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remote` [INFO] [stdout] --> src/main.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | Ok((stream, remote)) => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_remote` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut listener = TcpListener::bind("127.0.0.1:1090").unwrap(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 54 | let cloned_logger = logger.clone(); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | `cloned_logger` calls a custom destructor [INFO] [stdout] | `cloned_logger` will be dropped later as of Edition 2024 [INFO] [stdout] 55 | let cloned_trackers = trackers.clone(); [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | `cloned_trackers` calls a custom destructor [INFO] [stdout] | `cloned_trackers` will be dropped later as of Edition 2024 [INFO] [stdout] 56 | let cloned_dns = dns.clone(); [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `cloned_dns` calls a custom destructor [INFO] [stdout] | `cloned_dns` will be dropped later as of Edition 2024 [INFO] [stdout] 57 | match listener.accept() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `cloned_logger` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mpmc/mod.rs:620:1 [INFO] [stdout] note: `cloned_trackers` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mpmc/mod.rs:620:1 [INFO] [stdout] note: `cloned_dns` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mpmc/mod.rs:620:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0432, E0635. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0432`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-socks` (bin "rust-socks") due to 3 previous errors; 25 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f1c8ad25c24f3547a389e4021cc26582f979b11ba3a61da71a1e23d98383db53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1c8ad25c24f3547a389e4021cc26582f979b11ba3a61da71a1e23d98383db53", kill_on_drop: false }` [INFO] [stdout] f1c8ad25c24f3547a389e4021cc26582f979b11ba3a61da71a1e23d98383db53