[INFO] cloning repository https://github.com/zenith-john/lox-in-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zenith-john/lox-in-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzenith-john%2Flox-in-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzenith-john%2Flox-in-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ffbfb7299cf27600ee192a37857ce4cd353b56f0 [INFO] building zenith-john/lox-in-rust against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzenith-john%2Flox-in-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zenith-john/lox-in-rust on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zenith-john/lox-in-rust [INFO] finished tweaking git repo https://github.com/zenith-john/lox-in-rust [INFO] tweaked toml for git repo https://github.com/zenith-john/lox-in-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/zenith-john/lox-in-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3aa855370283184e0034030ad56353682c5aba72de5577697cfeab93da6a69fb [INFO] running `Command { std: "docker" "start" "-a" "3aa855370283184e0034030ad56353682c5aba72de5577697cfeab93da6a69fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3aa855370283184e0034030ad56353682c5aba72de5577697cfeab93da6a69fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aa855370283184e0034030ad56353682c5aba72de5577697cfeab93da6a69fb", kill_on_drop: false }` [INFO] [stdout] 3aa855370283184e0034030ad56353682c5aba72de5577697cfeab93da6a69fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3c4812b7501e10d4bdd9db3dc8ad4110cd1a7dd6222db1f6bf497a5064508422 [INFO] running `Command { std: "docker" "start" "-a" "3c4812b7501e10d4bdd9db3dc8ad4110cd1a7dd6222db1f6bf497a5064508422", kill_on_drop: false }` [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling lox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:215:23 [INFO] [stdout] | [INFO] [stdout] 215 | match evaluate(*condition.clone(), env.clone(), table) { [INFO] [stdout] | ^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 216 | None => return Err("Runtime Error"), [INFO] [stdout] 217 | Some(val) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `val` calls a custom destructor [INFO] [stdout] | `val` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `val` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:254:23 [INFO] [stdout] | [INFO] [stdout] 253 | for expr in arguments { [INFO] [stdout] | ---- --------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `expr` calls a custom destructor [INFO] [stdout] | `expr` will be dropped later as of Edition 2024 [INFO] [stdout] 254 | match evaluate(*expr, env.clone(), table) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `expr` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:288:27 [INFO] [stdout] | [INFO] [stdout] 283 | let mut klass = val.clone().borrow_mut().klass.clone(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `klass` calls a custom destructor [INFO] [stdout] | `klass` will be dropped later as of Edition 2024 [INFO] [stdout] 284 | loop { [INFO] [stdout] 285 | if let Some(method) = klass.find_method(st.clone()) { [INFO] [stdout] | ----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | match klass.superclass() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 295 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `klass` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:389:23 [INFO] [stdout] | [INFO] [stdout] 384 | let mut klass = superclass.clone(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `klass` calls a custom destructor [INFO] [stdout] | `klass` will be dropped later as of Edition 2024 [INFO] [stdout] 385 | loop { [INFO] [stdout] 386 | if let Some(method) = klass.find_method(st.clone()) { [INFO] [stdout] | ----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 389 | match klass.superclass() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `klass` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:340:30 [INFO] [stdout] | [INFO] [stdout] 339 | let ob = evaluate(*object, env.clone(), table)?; [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `ob` calls a custom destructor [INFO] [stdout] | `ob` will be dropped later as of Edition 2024 [INFO] [stdout] 340 | if let Ok(val) = ob.clone().downcast::>() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `ob` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:273:30 [INFO] [stdout] | [INFO] [stdout] 272 | let ob = evaluate(*object, env, table)?; [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `ob` calls a custom destructor [INFO] [stdout] | `ob` will be dropped later as of Edition 2024 [INFO] [stdout] 273 | if let Ok(val) = ob.clone().downcast::>() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `ob` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/interpreter.rs:259:30 [INFO] [stdout] | [INFO] [stdout] 248 | let callee_evaluated = match evaluate(*callee, env.clone(), table) { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | `callee_evaluated` calls a custom destructor [INFO] [stdout] | `callee_evaluated` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let mut args: LinkedList> = LinkedList::new(); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `args` calls a custom destructor [INFO] [stdout] | `args` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | if let Ok(val) = callee_evaluated.clone().downcast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `callee_evaluated` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `args` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/resolver.rs:263:28 [INFO] [stdout] | [INFO] [stdout] 262 | for token in params { [INFO] [stdout] | ----- ------ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `token` calls a custom destructor [INFO] [stdout] | `token` will be dropped later as of Edition 2024 [INFO] [stdout] 263 | if let Some(key) = token.lexeme.unwrap().as_ref().downcast_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `token` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/callable.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 92 | pub struct LoxClass { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 93 | name: Token, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoxClass` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox` (bin "lox") due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3c4812b7501e10d4bdd9db3dc8ad4110cd1a7dd6222db1f6bf497a5064508422", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c4812b7501e10d4bdd9db3dc8ad4110cd1a7dd6222db1f6bf497a5064508422", kill_on_drop: false }` [INFO] [stdout] 3c4812b7501e10d4bdd9db3dc8ad4110cd1a7dd6222db1f6bf497a5064508422