[INFO] cloning repository https://github.com/sandreim/epolly [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sandreim/epolly" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsandreim%2Fepolly", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsandreim%2Fepolly'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e20a54f4eeddc64e7897c46fd28bc56f9dea078e [INFO] building sandreim/epolly against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsandreim%2Fepolly" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/sandreim/epolly on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/sandreim/epolly [INFO] finished tweaking git repo https://github.com/sandreim/epolly [INFO] tweaked toml for git repo https://github.com/sandreim/epolly written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/sandreim/epolly already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-0-tc1/source/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitflags v1.2.0 [INFO] [stderr] Downloaded epoll v4.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93382b30265f8ee82f88d28ca82eb7952d29d5340393df71723e0ab7916fd2e2 [INFO] running `Command { std: "docker" "start" "-a" "93382b30265f8ee82f88d28ca82eb7952d29d5340393df71723e0ab7916fd2e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93382b30265f8ee82f88d28ca82eb7952d29d5340393df71723e0ab7916fd2e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93382b30265f8ee82f88d28ca82eb7952d29d5340393df71723e0ab7916fd2e2", kill_on_drop: false }` [INFO] [stdout] 93382b30265f8ee82f88d28ca82eb7952d29d5340393df71723e0ab7916fd2e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90f34172e031de28112389ed23238213ccc9d4b3289ec662355063ee7929ac49 [INFO] running `Command { std: "docker" "start" "-a" "90f34172e031de28112389ed23238213ccc9d4b3289ec662355063ee7929ac49", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling libc v0.1.12 [INFO] [stderr] Compiling epoll v4.1.0 [INFO] [stderr] Compiling epolly v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `RawFd` [INFO] [stdout] --> src/main.rs:18:34 [INFO] [stdout] | [INFO] [stdout] 18 | use std::os::unix::io::{AsRawFd, RawFd}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `wrapped_em2` [INFO] [stdout] --> src/main.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | let wrapped_em2 = em.register(em2); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_wrapped_em2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/event_manager.rs:324:27 [INFO] [stdout] | [INFO] [stdout] 321 | let mut delete_handler = None; [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | `delete_handler` calls a custom destructor [INFO] [stdout] | `delete_handler` will be dropped later as of Edition 2024 [INFO] [stdout] 322 | if let Some(event_handler_data) = self.handlers.get(&(event_data as i32)) { [INFO] [stdout] | ------------------ --------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `event_handler_data` calls a custom destructor [INFO] [stdout] | `event_handler_data` will be dropped later as of Edition 2024 [INFO] [stdout] 323 | if let Some(handler) = event_handler_data.handler.upgrade() { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `handler` calls a custom destructor [INFO] [stdout] | `handler` will be dropped later as of Edition 2024 [INFO] [stdout] 324 | match handler.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 325 | Ok(handler_ref) => { [INFO] [stdout] 326 | / self.dispatch_event( [INFO] [stdout] 327 | | event_handler_data.data.0.clone(), [INFO] [stdout] 328 | | evset, [INFO] [stdout] 329 | | handler_ref, [INFO] [stdout] 330 | | event_handler_data.handler, [INFO] [stdout] 331 | | )?; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |______________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | } else { [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 344 | self.unregister(handler)?; [INFO] [stdout] | ------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `delete_handler` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `event_handler_data` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `event_handler_data` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `handler` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/event_manager.rs:323:40 [INFO] [stdout] | [INFO] [stdout] 321 | let mut delete_handler = None; [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | `delete_handler` calls a custom destructor [INFO] [stdout] | `delete_handler` will be dropped later as of Edition 2024 [INFO] [stdout] 322 | if let Some(event_handler_data) = self.handlers.get(&(event_data as i32)) { [INFO] [stdout] | ------------------ --------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `event_handler_data` calls a custom destructor [INFO] [stdout] | `event_handler_data` will be dropped later as of Edition 2024 [INFO] [stdout] 323 | if let Some(handler) = event_handler_data.handler.upgrade() { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `handler` calls a custom destructor [INFO] [stdout] | `handler` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | / self.dispatch_event( [INFO] [stdout] 327 | | event_handler_data.data.0.clone(), [INFO] [stdout] 328 | | evset, [INFO] [stdout] 329 | | handler_ref, [INFO] [stdout] 330 | | event_handler_data.handler, [INFO] [stdout] 331 | | )?; [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |______________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 344 | self.unregister(handler)?; [INFO] [stdout] | ------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `delete_handler` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `event_handler_data` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `event_handler_data` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `handler` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> src/pollable.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl Drop for OwnedFD { [INFO] [stdout] 61 | | fn drop(&mut self) { [INFO] [stdout] 62 | | unsafe { libc::close(self._fd) }; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `update` and `run` are never used [INFO] [stdout] --> src/event_manager.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 131 | impl EventManager { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 194 | pub fn update( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 351 | pub fn run(&mut self) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Update` is never constructed [INFO] [stdout] --> src/pollable.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub enum PollableOp { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 79 | Update(EventRegistrationData), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `writeable` and `update` are never used [INFO] [stdout] --> src/pollable.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 118 | impl PollableOpBuilder { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn writeable<'a>(&'a mut self) -> &'a mut PollableOpBuilder { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 149 | pub fn update(&self) -> PollableOp { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | tcp_server.set_nonblocking(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 68 | let _ = tcp_server.set_nonblocking(true); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:139:25 [INFO] [stdout] | [INFO] [stdout] 139 | client.write(message.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 139 | let _ = client.write(message.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `epolly` (bin "epolly") due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "90f34172e031de28112389ed23238213ccc9d4b3289ec662355063ee7929ac49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90f34172e031de28112389ed23238213ccc9d4b3289ec662355063ee7929ac49", kill_on_drop: false }` [INFO] [stdout] 90f34172e031de28112389ed23238213ccc9d4b3289ec662355063ee7929ac49