[INFO] cloning repository https://github.com/saitunc/naive_ecc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/saitunc/naive_ecc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaitunc%2Fnaive_ecc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaitunc%2Fnaive_ecc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 53bd9739452c01c2db22c36a5ee214f86c077b88 [INFO] building saitunc/naive_ecc against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaitunc%2Fnaive_ecc" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/saitunc/naive_ecc on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/saitunc/naive_ecc [INFO] finished tweaking git repo https://github.com/saitunc/naive_ecc [INFO] tweaked toml for git repo https://github.com/saitunc/naive_ecc written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/saitunc/naive_ecc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6a3e60bef0b04fd44444fbf75ac296b655274eceacb0baf9d02111fa767d356 [INFO] running `Command { std: "docker" "start" "-a" "c6a3e60bef0b04fd44444fbf75ac296b655274eceacb0baf9d02111fa767d356", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6a3e60bef0b04fd44444fbf75ac296b655274eceacb0baf9d02111fa767d356", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6a3e60bef0b04fd44444fbf75ac296b655274eceacb0baf9d02111fa767d356", kill_on_drop: false }` [INFO] [stdout] c6a3e60bef0b04fd44444fbf75ac296b655274eceacb0baf9d02111fa767d356 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e0ff86e629ab931fe51e206ae62dd63b0885dcdf3e3c01b4f4123d25ce7991c4 [INFO] running `Command { std: "docker" "start" "-a" "e0ff86e629ab931fe51e206ae62dd63b0885dcdf3e3c01b4f4123d25ce7991c4", kill_on_drop: false }` [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling naive_ecc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ToBigInt` [INFO] [stdout] --> src/elliptic_curve/field.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | use num_bigint::{BigInt, ToBigInt}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/field.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | a = (&a % &m); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - a = (&a % &m); [INFO] [stdout] 65 + a = &a % &m; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToBigInt` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use num_bigint::{ToBigInt, BigInt}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | x = (z.modinv() * x); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - x = (z.modinv() * x); [INFO] [stdout] 60 + x = z.modinv() * x; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | y = (z.modinv() * y); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - y = (z.modinv() * y); [INFO] [stdout] 61 + y = z.modinv() * y; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let x = (self.get_x().clone() * z_inv.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - let x = (self.get_x().clone() * z_inv.clone()); [INFO] [stdout] 104 + let x = self.get_x().clone() * z_inv.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | let y = (self.get_y().clone() * z_inv); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - let y = (self.get_y().clone() * z_inv); [INFO] [stdout] 106 + let y = self.get_y().clone() * z_inv; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/elliptic_curve/point/point.rs:184:11 [INFO] [stdout] | [INFO] [stdout] 184 | if(self.get_x().get_number() == &BigInt::from(0) && self.get_y().get_number() == &BigInt::from(0) ){ [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 184 - if(self.get_x().get_number() == &BigInt::from(0) && self.get_y().get_number() == &BigInt::from(0) ){ [INFO] [stdout] 184 + if self.get_x().get_number() == &BigInt::from(0) && self.get_y().get_number() == &BigInt::from(0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/elliptic_curve/point/point.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 190 - else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] 190 + else if self.get_x() == other.get_x() && self.get_y() == other.get_y() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/elliptic_curve/point/point.rs:223:17 [INFO] [stdout] | [INFO] [stdout] 223 | else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 223 - else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] 223 + else if self.get_x() == other.get_x() && self.get_y() == other.get_y() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PointAffine` and `PointProjective` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:1:43 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::elliptic_curve::point::point::{PointAffine,PointProjective}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::elliptic_curve::field::FieldElement` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::elliptic_curve::field::FieldElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_bigint::BigInt` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num_bigint::BigInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `One` and `Zero` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use num_traits::{Zero,One}; [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::elliptic_curve::field_traits::FieldElementTraits` [INFO] [stdout] --> src/elliptic_curve/curve.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::elliptic_curve::field_traits::FieldElementTraits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_bigint::BigInt` [INFO] [stdout] --> src/elliptic_curve/curve.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num_bigint::BigInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `One` and `Zero` [INFO] [stdout] --> src/elliptic_curve/curve.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use num_traits::{Zero,One}; [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Add` and `Sub` [INFO] [stdout] --> src/elliptic_curve/curve.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::ops::{Add,Sub}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `format` [INFO] [stdout] --> src/polynomials/polynomial.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use std::fmt::{self, format}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polynomials/polynomial.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | result.coefficients[i] = (result.coefficients[i].clone() + self.coefficients[i].clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 30 - result.coefficients[i] = (result.coefficients[i].clone() + self.coefficients[i].clone()); [INFO] [stdout] 30 + result.coefficients[i] = result.coefficients[i].clone() + self.coefficients[i].clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polynomials/polynomial.rs:34:38 [INFO] [stdout] | [INFO] [stdout] 34 | result.coefficients[i] = (&result.coefficients[i] + &other.coefficients[i]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - result.coefficients[i] = (&result.coefficients[i] + &other.coefficients[i]); [INFO] [stdout] 34 + result.coefficients[i] = &result.coefficients[i] + &other.coefficients[i]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::{One, Zero}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Zero` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::{One, Zero}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `element` is never read [INFO] [stdout] --> src/elliptic_curve/curve.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct CurveElement{ [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 13 | element: FieldElement, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CurveElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `pointTraits` should have a snake case name [INFO] [stdout] --> src/elliptic_curve/point/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod pointTraits; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `point_traits` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Q` should have a snake case name [INFO] [stdout] --> src/elliptic_curve/point/point.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | let mut Q = self.clone(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `q` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/elliptic_curve/point/point.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | let mut R = PointAffine{ [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.01s [INFO] running `Command { std: "docker" "inspect" "e0ff86e629ab931fe51e206ae62dd63b0885dcdf3e3c01b4f4123d25ce7991c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0ff86e629ab931fe51e206ae62dd63b0885dcdf3e3c01b4f4123d25ce7991c4", kill_on_drop: false }` [INFO] [stdout] e0ff86e629ab931fe51e206ae62dd63b0885dcdf3e3c01b4f4123d25ce7991c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 36b788434abbc266859044dcec9677590f15568cadb64656f06020a806f838d9 [INFO] running `Command { std: "docker" "start" "-a" "36b788434abbc266859044dcec9677590f15568cadb64656f06020a806f838d9", kill_on_drop: false }` [INFO] [stderr] Compiling naive_ecc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ToBigInt` [INFO] [stdout] --> src/elliptic_curve/field.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | use num_bigint::{BigInt, ToBigInt}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/field.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | a = (&a % &m); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - a = (&a % &m); [INFO] [stdout] 65 + a = &a % &m; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToBigInt` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use num_bigint::{ToBigInt, BigInt}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | x = (z.modinv() * x); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - x = (z.modinv() * x); [INFO] [stdout] 60 + x = z.modinv() * x; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | y = (z.modinv() * y); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - y = (z.modinv() * y); [INFO] [stdout] 61 + y = z.modinv() * y; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let x = (self.get_x().clone() * z_inv.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - let x = (self.get_x().clone() * z_inv.clone()); [INFO] [stdout] 104 + let x = self.get_x().clone() * z_inv.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/elliptic_curve/point/point.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | let y = (self.get_y().clone() * z_inv); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - let y = (self.get_y().clone() * z_inv); [INFO] [stdout] 106 + let y = self.get_y().clone() * z_inv; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/elliptic_curve/point/point.rs:184:11 [INFO] [stdout] | [INFO] [stdout] 184 | if(self.get_x().get_number() == &BigInt::from(0) && self.get_y().get_number() == &BigInt::from(0) ){ [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 184 - if(self.get_x().get_number() == &BigInt::from(0) && self.get_y().get_number() == &BigInt::from(0) ){ [INFO] [stdout] 184 + if self.get_x().get_number() == &BigInt::from(0) && self.get_y().get_number() == &BigInt::from(0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/elliptic_curve/point/point.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 190 - else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] 190 + else if self.get_x() == other.get_x() && self.get_y() == other.get_y() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/elliptic_curve/point/point.rs:223:17 [INFO] [stdout] | [INFO] [stdout] 223 | else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 223 - else if (self.get_x() == other.get_x() && self.get_y() == other.get_y()){ [INFO] [stdout] 223 + else if self.get_x() == other.get_x() && self.get_y() == other.get_y() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PointAffine` and `PointProjective` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:1:43 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::elliptic_curve::point::point::{PointAffine,PointProjective}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::elliptic_curve::field::FieldElement` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::elliptic_curve::field::FieldElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_bigint::BigInt` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num_bigint::BigInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `One` and `Zero` [INFO] [stdout] --> src/elliptic_curve/point/pointTraits.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use num_traits::{Zero,One}; [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::elliptic_curve::field_traits::FieldElementTraits` [INFO] [stdout] --> src/elliptic_curve/curve.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::elliptic_curve::field_traits::FieldElementTraits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_bigint::BigInt` [INFO] [stdout] --> src/elliptic_curve/curve.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num_bigint::BigInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `One` and `Zero` [INFO] [stdout] --> src/elliptic_curve/curve.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use num_traits::{Zero,One}; [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Add` and `Sub` [INFO] [stdout] --> src/elliptic_curve/curve.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::ops::{Add,Sub}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `format` [INFO] [stdout] --> src/polynomials/polynomial.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use std::fmt::{self, format}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polynomials/polynomial.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | result.coefficients[i] = (result.coefficients[i].clone() + self.coefficients[i].clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 30 - result.coefficients[i] = (result.coefficients[i].clone() + self.coefficients[i].clone()); [INFO] [stdout] 30 + result.coefficients[i] = result.coefficients[i].clone() + self.coefficients[i].clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/polynomials/polynomial.rs:34:38 [INFO] [stdout] | [INFO] [stdout] 34 | result.coefficients[i] = (&result.coefficients[i] + &other.coefficients[i]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - result.coefficients[i] = (&result.coefficients[i] + &other.coefficients[i]); [INFO] [stdout] 34 + result.coefficients[i] = &result.coefficients[i] + &other.coefficients[i]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::{One, Zero}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Zero` [INFO] [stdout] --> src/elliptic_curve/point/point.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::{One, Zero}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `element` is never read [INFO] [stdout] --> src/elliptic_curve/curve.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct CurveElement{ [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 13 | element: FieldElement, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CurveElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `pointTraits` should have a snake case name [INFO] [stdout] --> src/elliptic_curve/point/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod pointTraits; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `point_traits` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Q` should have a snake case name [INFO] [stdout] --> src/elliptic_curve/point/point.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | let mut Q = self.clone(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `q` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/elliptic_curve/point/point.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | let mut R = PointAffine{ [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `Command { std: "docker" "inspect" "36b788434abbc266859044dcec9677590f15568cadb64656f06020a806f838d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36b788434abbc266859044dcec9677590f15568cadb64656f06020a806f838d9", kill_on_drop: false }` [INFO] [stdout] 36b788434abbc266859044dcec9677590f15568cadb64656f06020a806f838d9