[INFO] cloning repository https://github.com/saintech/asteroids [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/saintech/asteroids" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaintech%2Fasteroids", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaintech%2Fasteroids'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] afe87cb8824bcb4eb91125feff0ac9a4c8e9ead7 [INFO] building saintech/asteroids/afe87cb8824bcb4eb91125feff0ac9a4c8e9ead7 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaintech%2Fasteroids" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/saintech/asteroids on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/saintech/asteroids [INFO] finished tweaking git repo https://github.com/saintech/asteroids [INFO] tweaked toml for git repo https://github.com/saintech/asteroids written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/saintech/asteroids already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded macroquad-particles v0.1.1 [INFO] [stderr] Downloaded ogg v0.7.1 [INFO] [stderr] Downloaded hound v3.4.0 [INFO] [stderr] Downloaded macroquad_macro v0.1.7 [INFO] [stderr] Downloaded quad-rand v0.2.1 [INFO] [stderr] Downloaded macroquad-canvas v0.3.0 [INFO] [stderr] Downloaded audir-sles v0.1.0 [INFO] [stderr] Downloaded sapp-wasm v0.1.26 [INFO] [stderr] Downloaded quad-alsa-sys v0.3.2 [INFO] [stderr] Downloaded sapp-windows v0.2.19 [INFO] [stderr] Downloaded sapp-android v0.1.10 [INFO] [stderr] Downloaded sapp-dummy v0.1.5 [INFO] [stderr] Downloaded sapp-darwin v0.1.8 [INFO] [stderr] Downloaded sapp-ios v0.1.2 [INFO] [stderr] Downloaded lewton v0.9.4 [INFO] [stderr] Downloaded fontdue v0.5.2 [INFO] [stderr] Downloaded sapp-linux v0.1.14 [INFO] [stderr] Downloaded miniquad v0.3.0-alpha.45 [INFO] [stderr] Downloaded audrey v0.3.0 [INFO] [stderr] Downloaded macroquad v0.3.15 [INFO] [stderr] Downloaded quad-snd v0.2.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc5e49740fbd9583149fe23d2b939a69123c22249e876ad1eac17a36f8a10caf [INFO] running `Command { std: "docker" "start" "-a" "fc5e49740fbd9583149fe23d2b939a69123c22249e876ad1eac17a36f8a10caf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc5e49740fbd9583149fe23d2b939a69123c22249e876ad1eac17a36f8a10caf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc5e49740fbd9583149fe23d2b939a69123c22249e876ad1eac17a36f8a10caf", kill_on_drop: false }` [INFO] [stdout] fc5e49740fbd9583149fe23d2b939a69123c22249e876ad1eac17a36f8a10caf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 552318a525eb7fa28bccb34ee4e45ce9803708902d7a2b069a1bd3d42918725d [INFO] running `Command { std: "docker" "start" "-a" "552318a525eb7fa28bccb34ee4e45ce9803708902d7a2b069a1bd3d42918725d", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling quad-alsa-sys v0.3.2 [INFO] [stderr] Compiling ogg v0.7.1 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling sapp-linux v0.1.14 [INFO] [stderr] Compiling dasp_sample v0.11.0 [INFO] [stderr] Compiling quad-snd v0.2.3 [INFO] [stderr] Compiling hound v3.4.0 [INFO] [stderr] Compiling miniz_oxide v0.3.7 [INFO] [stderr] Compiling deflate v0.8.6 [INFO] [stderr] Compiling color_quant v1.1.0 [INFO] [stderr] Compiling bytemuck v1.8.0 [INFO] [stderr] Compiling ttf-parser v0.12.3 [INFO] [stderr] Compiling glam v0.14.0 [INFO] [stderr] Compiling macroquad_macro v0.1.7 [INFO] [stderr] Compiling bumpalo v3.9.1 [INFO] [stderr] Compiling quad-rand v0.2.1 [INFO] [stderr] Compiling dasp_frame v0.11.0 [INFO] [stderr] Compiling smallvec v0.6.14 [INFO] [stderr] Compiling png v0.16.8 [INFO] [stderr] Compiling lewton v0.9.4 [INFO] [stderr] Compiling fontdue v0.5.2 [INFO] [stderr] Compiling audrey v0.3.0 [INFO] [stderr] Compiling image v0.23.14 [INFO] [stderr] Compiling miniquad v0.3.0-alpha.45 [INFO] [stderr] Compiling macroquad v0.3.15 [INFO] [stderr] Compiling macroquad-canvas v0.3.0 [INFO] [stderr] Compiling macroquad-particles v0.1.1 [INFO] [stderr] Compiling asteroids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/collision.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | for ship in &mut game.ship { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 8 | while let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 8 | if let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/collision.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | for ship in &mut game.ship { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 13 | while let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 13 | if let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/collision.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | for ship in &mut game.ship { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 57 | while let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 57 | if let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/draw.rs:21:71 [INFO] [stdout] | [INFO] [stdout] 21 | for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 21 | while let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.35s [INFO] running `Command { std: "docker" "inspect" "552318a525eb7fa28bccb34ee4e45ce9803708902d7a2b069a1bd3d42918725d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "552318a525eb7fa28bccb34ee4e45ce9803708902d7a2b069a1bd3d42918725d", kill_on_drop: false }` [INFO] [stdout] 552318a525eb7fa28bccb34ee4e45ce9803708902d7a2b069a1bd3d42918725d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26501caf48aab807156d3b38a8ab5d02af34c6d3d35c071c4f8ccbae91ef5779 [INFO] running `Command { std: "docker" "start" "-a" "26501caf48aab807156d3b38a8ab5d02af34c6d3d35c071c4f8ccbae91ef5779", kill_on_drop: false }` [INFO] [stderr] Compiling asteroids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/collision.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | for ship in &mut game.ship { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 8 | while let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 8 | if let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/collision.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | for ship in &mut game.ship { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 13 | while let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 13 | if let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/collision.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | for ship in &mut game.ship { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 57 | while let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 57 | if let Some(ship) = &mut game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/systems/draw.rs:21:71 [INFO] [stdout] | [INFO] [stdout] 21 | for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 21 | while let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "26501caf48aab807156d3b38a8ab5d02af34c6d3d35c071c4f8ccbae91ef5779", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26501caf48aab807156d3b38a8ab5d02af34c6d3d35c071c4f8ccbae91ef5779", kill_on_drop: false }` [INFO] [stdout] 26501caf48aab807156d3b38a8ab5d02af34c6d3d35c071c4f8ccbae91ef5779