[INFO] cloning repository https://github.com/pulpdrew/rlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pulpdrew/rlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpulpdrew%2Frlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpulpdrew%2Frlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e913d17b798989ad5a2c062ce7cf63ea3da6360b [INFO] building pulpdrew/rlox against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpulpdrew%2Frlox" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pulpdrew/rlox on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pulpdrew/rlox [INFO] finished tweaking git repo https://github.com/pulpdrew/rlox [INFO] tweaked toml for git repo https://github.com/pulpdrew/rlox written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/pulpdrew/rlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98d79ae3cdb28689396cc8bc52008060751867e4d7b1ab0070e54bfb5e878895 [INFO] running `Command { std: "docker" "start" "-a" "98d79ae3cdb28689396cc8bc52008060751867e4d7b1ab0070e54bfb5e878895", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98d79ae3cdb28689396cc8bc52008060751867e4d7b1ab0070e54bfb5e878895", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98d79ae3cdb28689396cc8bc52008060751867e4d7b1ab0070e54bfb5e878895", kill_on_drop: false }` [INFO] [stdout] 98d79ae3cdb28689396cc8bc52008060751867e4d7b1ab0070e54bfb5e878895 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bccca46326f8a1c384d72450e43f35426c2af33e9363883755df575ba0b50804 [INFO] running `Command { std: "docker" "start" "-a" "bccca46326f8a1c384d72450e43f35426c2af33e9363883755df575ba0b50804", kill_on_drop: false }` [INFO] [stderr] Compiling rlox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/vm.rs:209:47 [INFO] [stdout] | [INFO] [stdout] 190 | self.push(closure.upvalues.borrow().get(index).unwrap().value.clone()); [INFO] [stdout] | ------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | if let Some(method) = instance.class.methods.borrow().get(name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | up until Edition 2021 `#8` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | } else if let Some(v) = instance.fields.borrow().get(name) { [INFO] [stdout] | ------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | } else { [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 247 | / instance [INFO] [stdout] 248 | | .fields [INFO] [stdout] 249 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | OpCode::SetUpvalue(index) => closure [INFO] [stdout] | ______________________________________________- [INFO] [stdout] | |______________________________________________| [INFO] [stdout] 260 | | .upvalues [INFO] [stdout] 261 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | | class.methods.borrow_mut().insert( [INFO] [stdout] | | -------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 289 | | for (method_name, method) in superclass.methods.borrow().iter() { [INFO] [stdout] | | --------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] 290 | / class [INFO] [stdout] 291 | | .methods [INFO] [stdout] 292 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | |_________________________________________| [INFO] [stdout] | |_________________________________________this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/vm.rs:311:47 [INFO] [stdout] | [INFO] [stdout] 190 | self.push(closure.upvalues.borrow().get(index).unwrap().value.clone()); [INFO] [stdout] | ------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | } else if let Some(v) = instance.fields.borrow().get(name) { [INFO] [stdout] | ------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | / instance [INFO] [stdout] 248 | | .fields [INFO] [stdout] 249 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | OpCode::SetUpvalue(index) => closure [INFO] [stdout] | ______________________________________________- [INFO] [stdout] | |______________________________________________| [INFO] [stdout] 260 | | .upvalues [INFO] [stdout] 261 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | | class.methods.borrow_mut().insert( [INFO] [stdout] | | -------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 289 | | for (method_name, method) in superclass.methods.borrow().iter() { [INFO] [stdout] | | --------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] 290 | / class [INFO] [stdout] 291 | | .methods [INFO] [stdout] 292 | | .borrow_mut() [INFO] [stdout] | | - [INFO] [stdout] | |_________________________________________| [INFO] [stdout] | |_________________________________________this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | | if let Some(method) = class.methods.borrow().get(method_name) { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | | up until Edition 2021 `#8` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 329 | | } else { [INFO] [stdout] | | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlox` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "bccca46326f8a1c384d72450e43f35426c2af33e9363883755df575ba0b50804", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bccca46326f8a1c384d72450e43f35426c2af33e9363883755df575ba0b50804", kill_on_drop: false }` [INFO] [stdout] bccca46326f8a1c384d72450e43f35426c2af33e9363883755df575ba0b50804