[INFO] cloning repository https://github.com/parkerpierpont/lox-lang [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/parkerpierpont/lox-lang" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fparkerpierpont%2Flox-lang", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fparkerpierpont%2Flox-lang'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 887acab323ff928b33e19792e240dad32be6aa63 [INFO] building parkerpierpont/lox-lang against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fparkerpierpont%2Flox-lang" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/parkerpierpont/lox-lang on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/parkerpierpont/lox-lang [INFO] finished tweaking git repo https://github.com/parkerpierpont/lox-lang [INFO] tweaked toml for git repo https://github.com/parkerpierpont/lox-lang written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/parkerpierpont/lox-lang already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c0ea42cc2d75ac316727618bee72de3816673850cc42964abb89bdc98871833 [INFO] running `Command { std: "docker" "start" "-a" "6c0ea42cc2d75ac316727618bee72de3816673850cc42964abb89bdc98871833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c0ea42cc2d75ac316727618bee72de3816673850cc42964abb89bdc98871833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c0ea42cc2d75ac316727618bee72de3816673850cc42964abb89bdc98871833", kill_on_drop: false }` [INFO] [stdout] 6c0ea42cc2d75ac316727618bee72de3816673850cc42964abb89bdc98871833 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 390ad08ea5d639c7b5c09e9a2f24a6e41f30959ad44106b9fc3908648818774d [INFO] running `Command { std: "docker" "start" "-a" "390ad08ea5d639c7b5c09e9a2f24a6e41f30959ad44106b9fc3908648818774d", kill_on_drop: false }` [INFO] [stderr] Compiling downcast v0.11.0 [INFO] [stderr] Compiling vm v0.1.0 (/opt/rustwide/workdir/vm) [INFO] [stderr] Compiling lox-interpreted v0.1.0 (/opt/rustwide/workdir/interpreted) [INFO] [stdout] warning: unused import: `object::LoxNil` [INFO] [stdout] --> interpreted/src/parser.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | object::LoxNil, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `once_cell` has been stable since 1.70.0 and no longer requires an attribute to enable [INFO] [stdout] --> interpreted/src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(once_cell)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> interpreted/src/parser.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 292 | _ => Ok(ReturnStmt::new(keyword, value)), [INFO] [stdout] | - matches any value [INFO] [stdout] 293 | Err(parse_error) => return Err(parse_error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> interpreted/src/environment.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 100 | let mut ret = None; [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `ret` calls a custom destructor [INFO] [stdout] | `ret` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | if let Ok(env) = v.try_write() { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `env` calls a custom destructor [INFO] [stdout] | `env` will be dropped later as of Edition 2024 [INFO] [stdout] 106 | match env.get(name) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `ret` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `env` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/rwlock.rs:828:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox-interpreted` (bin "lox-interpreted") due to 5 previous errors; 3 warnings emitted [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> interpreted/src/environment.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 100 | let mut ret = None; [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `ret` calls a custom destructor [INFO] [stdout] | `ret` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | if let Ok(env) = v.try_write() { [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `env` calls a custom destructor [INFO] [stdout] | `env` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/rwlock.rs:828:1 [INFO] [stdout] = note: `ret` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `env` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/rwlock.rs:828:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> interpreted/src/environment.rs:135:38 [INFO] [stdout] | [INFO] [stdout] 135 | if let Ok(mut env) = v.try_write() { [INFO] [stdout] | ------- ^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `env` calls a custom destructor [INFO] [stdout] | `env` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/rwlock.rs:828:1 [INFO] [stdout] note: `env` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/rwlock.rs:828:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> interpreted/src/interpreter.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 29 | for stmt in statements { [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 30 | match self.execute(stmt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> interpreted/src/interpreter.rs:355:19 [INFO] [stdout] | [INFO] [stdout] 349 | while match self.evaluate(&stmt.condition) { [INFO] [stdout] | ------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 350 | // This is our evaluation of conditional's truthiness [INFO] [stdout] 351 | Ok(condition) => condition.is_truthy(), [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `condition` calls a custom destructor [INFO] [stdout] | `condition` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | match self.execute(stmt.body.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `condition` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "390ad08ea5d639c7b5c09e9a2f24a6e41f30959ad44106b9fc3908648818774d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "390ad08ea5d639c7b5c09e9a2f24a6e41f30959ad44106b9fc3908648818774d", kill_on_drop: false }` [INFO] [stdout] 390ad08ea5d639c7b5c09e9a2f24a6e41f30959ad44106b9fc3908648818774d