[INFO] cloning repository https://github.com/noprofessional/RustFlv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/noprofessional/RustFlv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoprofessional%2FRustFlv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoprofessional%2FRustFlv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7ebf64f2d66032695cf25c3c28ce8a4359ba0400 [INFO] building noprofessional/RustFlv against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoprofessional%2FRustFlv" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/noprofessional/RustFlv on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/noprofessional/RustFlv [INFO] finished tweaking git repo https://github.com/noprofessional/RustFlv [INFO] tweaked toml for git repo https://github.com/noprofessional/RustFlv written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/noprofessional/RustFlv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5bf76059dd4f8b8b1a14b53f5c2283ee058e648c9042eb6e1941bf3c4c0a7eff [INFO] running `Command { std: "docker" "start" "-a" "5bf76059dd4f8b8b1a14b53f5c2283ee058e648c9042eb6e1941bf3c4c0a7eff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5bf76059dd4f8b8b1a14b53f5c2283ee058e648c9042eb6e1941bf3c4c0a7eff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bf76059dd4f8b8b1a14b53f5c2283ee058e648c9042eb6e1941bf3c4c0a7eff", kill_on_drop: false }` [INFO] [stdout] 5bf76059dd4f8b8b1a14b53f5c2283ee058e648c9042eb6e1941bf3c4c0a7eff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd7d0035d9b4d700bc9f2bbeed6bf1859099a6822aa3e40d877dc20e3d4c468b [INFO] running `Command { std: "docker" "start" "-a" "cd7d0035d9b4d700bc9f2bbeed6bf1859099a6822aa3e40d877dc20e3d4c468b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling flv-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/epoller.rs:77:45 [INFO] [stdout] | [INFO] [stdout] 77 | if let Some(mut boxed_handle) = self.fd_to_handle.remove(&raw_fd) { [INFO] [stdout] | ---------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `boxed_handle` calls a custom destructor [INFO] [stdout] | `boxed_handle` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | self.fd_to_handle.insert(raw_fd, boxed_handle); [INFO] [stdout] | ---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 111 | } [INFO] [stdout] 112 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `boxed_handle` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/http_conn.rs:21:54 [INFO] [stdout] | [INFO] [stdout] 12 | for stream in self.incoming() { [INFO] [stdout] | ------ --------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `stream` calls a custom destructor [INFO] [stdout] | `stream` will be dropped later as of Edition 2024 [INFO] [stdout] 13 | match stream { [INFO] [stdout] 14 | Ok(s) => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `s` calls a custom destructor [INFO] [stdout] | `s` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | if let Err((s, wait_read_err)) = epoller.wait_read(s) { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `stream` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `s` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/http_conn.rs:118:57 [INFO] [stdout] | [INFO] [stdout] 109 | for stream in self.listener.incoming() { [INFO] [stdout] | ------ ------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `stream` calls a custom destructor [INFO] [stdout] | `stream` will be dropped later as of Edition 2024 [INFO] [stdout] 110 | match stream { [INFO] [stdout] 111 | Ok(s) => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `s` calls a custom destructor [INFO] [stdout] | `s` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | if let Err((conn, wait_read_err)) = epoller.wait_read(HttpStream::new(s)) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `conn` calls a custom destructor [INFO] [stdout] | `conn` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `stream` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `s` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] note: `conn` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/os/fd/owned.rs:172:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flv-server` (bin "flv-server") due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "cd7d0035d9b4d700bc9f2bbeed6bf1859099a6822aa3e40d877dc20e3d4c468b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd7d0035d9b4d700bc9f2bbeed6bf1859099a6822aa3e40d877dc20e3d4c468b", kill_on_drop: false }` [INFO] [stdout] cd7d0035d9b4d700bc9f2bbeed6bf1859099a6822aa3e40d877dc20e3d4c468b