[INFO] cloning repository https://github.com/merwaaan/chip8-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/merwaaan/chip8-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmerwaaan%2Fchip8-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmerwaaan%2Fchip8-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c15c55282d1f03463fb539c876d191579948df47 [INFO] building merwaaan/chip8-rust against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmerwaaan%2Fchip8-rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/merwaaan/chip8-rust on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/merwaaan/chip8-rust [INFO] finished tweaking git repo https://github.com/merwaaan/chip8-rust [INFO] tweaked toml for git repo https://github.com/merwaaan/chip8-rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/merwaaan/chip8-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded orbclient v0.3.23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1bc1a086d9baf3fdcea49752fbbd5362128b3d19a02edd84357afe8e346f53a4 [INFO] running `Command { std: "docker" "start" "-a" "1bc1a086d9baf3fdcea49752fbbd5362128b3d19a02edd84357afe8e346f53a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1bc1a086d9baf3fdcea49752fbbd5362128b3d19a02edd84357afe8e346f53a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bc1a086d9baf3fdcea49752fbbd5362128b3d19a02edd84357afe8e346f53a4", kill_on_drop: false }` [INFO] [stdout] 1bc1a086d9baf3fdcea49752fbbd5362128b3d19a02edd84357afe8e346f53a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 171c812e93983bc90d550aedad156610938b80ce56553e2458f7b701c099d00a [INFO] running `Command { std: "docker" "start" "-a" "171c812e93983bc90d550aedad156610938b80ce56553e2458f7b701c099d00a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.59 [INFO] [stderr] Compiling spin v0.5.0 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling ppv-lite86 v0.2.5 [INFO] [stderr] Compiling lazy_static v0.2.11 [INFO] [stderr] Compiling lazy_static v1.3.0 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling rand_chacha v0.2.0 [INFO] [stderr] Compiling c2-chacha v0.2.2 [INFO] [stderr] Compiling getrandom v0.1.6 [INFO] [stderr] Compiling time v0.1.42 [INFO] [stderr] Compiling rand_core v0.5.0 [INFO] [stderr] Compiling minifb v0.11.2 [INFO] [stderr] Compiling rand v0.7.0 [INFO] [stderr] Compiling chip8-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let mut program_mem = &mut self.mem[0x200 .. 0x200 + program.len()]; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | let mut font_mem = &mut self.mem[0 .. FONT.len()]; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/core.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | [8, x, y, 6] => // SHR Vx , Vy [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/core.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | [8, x, y, 0xE] => // SHL Vx, Vy [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/core.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 261 | [0xF, x, 0x0, 0xA] => // LD Vx, K [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let mut buffer: Vec = vec![BLACK; WIDTH * HEIGHT]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `press` and `release` are never used [INFO] [stdout] --> src/keyboard.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Keyboard [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn press(&mut self, key: u8) [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn release(&mut self, key: u8) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Map` that must be used [INFO] [stdout] --> src/display.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | self.buffer.iter_mut().map(|x| *x = BLACK); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 72 | let _ = self.buffer.iter_mut().map(|x| *x = BLACK); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Iterator::map` call that discard the iterator's values [INFO] [stdout] --> src/display.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | self.buffer.iter_mut().map(|x| *x = BLACK); [INFO] [stdout] | ^^^^--------------^ [INFO] [stdout] | | | [INFO] [stdout] | | this function returns `()`, which is likely not what you wanted [INFO] [stdout] | | called `Iterator::map` with callable that returns `()` [INFO] [stdout] | after this call to map, the resulting iterator is `impl Iterator`, which means the only information carried by the iterator is the number of items [INFO] [stdout] | [INFO] [stdout] = note: `Iterator::map`, like many of the methods on `Iterator`, gets executed lazily, meaning that its effects won't be visible until it is iterated [INFO] [stdout] = note: `#[warn(map_unit_fn)]` on by default [INFO] [stdout] help: you might have meant to use `Iterator::for_each` [INFO] [stdout] | [INFO] [stdout] 72 | self.buffer.iter_mut().for_each(|x| *x = BLACK); [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.43s [INFO] running `Command { std: "docker" "inspect" "171c812e93983bc90d550aedad156610938b80ce56553e2458f7b701c099d00a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "171c812e93983bc90d550aedad156610938b80ce56553e2458f7b701c099d00a", kill_on_drop: false }` [INFO] [stdout] 171c812e93983bc90d550aedad156610938b80ce56553e2458f7b701c099d00a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb4713b5fec20bdf891c9fca8b6cf04c91bc27fb35b3d7e53084310762004f44 [INFO] running `Command { std: "docker" "start" "-a" "bb4713b5fec20bdf891c9fca8b6cf04c91bc27fb35b3d7e53084310762004f44", kill_on_drop: false }` [INFO] [stderr] Compiling chip8-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let mut program_mem = &mut self.mem[0x200 .. 0x200 + program.len()]; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | let mut font_mem = &mut self.mem[0 .. FONT.len()]; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/core.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | [8, x, y, 6] => // SHR Vx , Vy [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/core.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | [8, x, y, 0xE] => // SHL Vx, Vy [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/core.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 261 | [0xF, x, 0x0, 0xA] => // LD Vx, K [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let mut buffer: Vec = vec![BLACK; WIDTH * HEIGHT]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `press` and `release` are never used [INFO] [stdout] --> src/keyboard.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Keyboard [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn press(&mut self, key: u8) [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn release(&mut self, key: u8) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Map` that must be used [INFO] [stdout] --> src/display.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | self.buffer.iter_mut().map(|x| *x = BLACK); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 72 | let _ = self.buffer.iter_mut().map(|x| *x = BLACK); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Iterator::map` call that discard the iterator's values [INFO] [stdout] --> src/display.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | self.buffer.iter_mut().map(|x| *x = BLACK); [INFO] [stdout] | ^^^^--------------^ [INFO] [stdout] | | | [INFO] [stdout] | | this function returns `()`, which is likely not what you wanted [INFO] [stdout] | | called `Iterator::map` with callable that returns `()` [INFO] [stdout] | after this call to map, the resulting iterator is `impl Iterator`, which means the only information carried by the iterator is the number of items [INFO] [stdout] | [INFO] [stdout] = note: `Iterator::map`, like many of the methods on `Iterator`, gets executed lazily, meaning that its effects won't be visible until it is iterated [INFO] [stdout] = note: `#[warn(map_unit_fn)]` on by default [INFO] [stdout] help: you might have meant to use `Iterator::for_each` [INFO] [stdout] | [INFO] [stdout] 72 | self.buffer.iter_mut().for_each(|x| *x = BLACK); [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.17s [INFO] running `Command { std: "docker" "inspect" "bb4713b5fec20bdf891c9fca8b6cf04c91bc27fb35b3d7e53084310762004f44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4713b5fec20bdf891c9fca8b6cf04c91bc27fb35b3d7e53084310762004f44", kill_on_drop: false }` [INFO] [stdout] bb4713b5fec20bdf891c9fca8b6cf04c91bc27fb35b3d7e53084310762004f44