[INFO] cloning repository https://github.com/linkfy/LGB [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/linkfy/LGB" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinkfy%2FLGB", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinkfy%2FLGB'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] caeb28f2e5ee59dd6e691a12df4854eb9f9cf02c [INFO] building linkfy/LGB against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinkfy%2FLGB" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/linkfy/LGB on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/linkfy/LGB [INFO] finished tweaking git repo https://github.com/linkfy/LGB [INFO] tweaked toml for git repo https://github.com/linkfy/LGB written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/linkfy/LGB already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wayland-scanner v0.24.1 [INFO] [stderr] Downloaded json v0.12.1 [INFO] [stderr] Downloaded wayland-sys v0.24.1 [INFO] [stderr] Downloaded wayland-client v0.24.1 [INFO] [stderr] Downloaded wayland-commons v0.24.1 [INFO] [stderr] Downloaded minifb v0.15.3 [INFO] [stderr] Downloaded wayland-protocols v0.24.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 657443f725ec97858dbb0f2b56ae9a920320799ac29b608d7215ea3dc6e72ad1 [INFO] running `Command { std: "docker" "start" "-a" "657443f725ec97858dbb0f2b56ae9a920320799ac29b608d7215ea3dc6e72ad1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "657443f725ec97858dbb0f2b56ae9a920320799ac29b608d7215ea3dc6e72ad1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "657443f725ec97858dbb0f2b56ae9a920320799ac29b608d7215ea3dc6e72ad1", kill_on_drop: false }` [INFO] [stdout] 657443f725ec97858dbb0f2b56ae9a920320799ac29b608d7215ea3dc6e72ad1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c2fa38d68ff98aa68bbb01ce7ad9cc312bd1e767b9366d9b55d1f5109d36865 [INFO] running `Command { std: "docker" "start" "-a" "0c2fa38d68ff98aa68bbb01ce7ad9cc312bd1e767b9366d9b55d1f5109d36865", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.6 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling wayland-sys v0.24.1 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling downcast-rs v1.1.1 [INFO] [stderr] Compiling remove_dir_all v0.5.2 [INFO] [stderr] Compiling json v0.12.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling x11-dl v2.18.4 [INFO] [stderr] Compiling smallvec v0.6.13 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling c2-chacha v0.2.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling wayland-scanner v0.24.1 [INFO] [stderr] Compiling minifb v0.15.3 [INFO] [stderr] Compiling raw-window-handle v0.3.3 [INFO] [stderr] Compiling time v0.1.42 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.2.1 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling wayland-client v0.24.1 [INFO] [stderr] Compiling wayland-protocols v0.24.1 [INFO] [stderr] Compiling tempfile v3.1.0 [INFO] [stderr] Compiling wayland-commons v0.24.1 [INFO] [stderr] Compiling LGB v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{self, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/registers.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | let result = (register_f & bit); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - let result = (register_f & bit); [INFO] [stdout] 46 + let result = register_f & bit; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/registers.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 55 | if(result != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - if(result != 0) { [INFO] [stdout] 55 + if result != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu.rs:143:11 [INFO] [stdout] | [INFO] [stdout] 143 | if(result_operation == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 143 - if(result_operation == 0) { [INFO] [stdout] 143 + if result_operation == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/rom.rs:27:11 [INFO] [stdout] | [INFO] [stdout] 27 | if(file.metadata().unwrap().len() >= 32768) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - if(file.metadata().unwrap().len() >= 32768) { [INFO] [stdout] 27 + if file.metadata().unwrap().len() >= 32768 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | 0x01 ... 0x03 => {mbc = Mbc::Mbc1}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | 0x05 ... 0x06 => {mbc = Mbc::Mbc2}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | 0x0F ... 0x13 => {mbc = Mbc::Mbc3}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | 0x15 ... 0x17 => {mbc = Mbc::Mbc4}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | 0x19 ... 0x1E => {mbc = Mbc::Mbc5}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_bus.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | 0x0000...0x7FFF => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/memory_bus.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | if(self.boot_mode) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - if(self.boot_mode) { [INFO] [stdout] 57 + if self.boot_mode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rom::Rom` [INFO] [stdout] --> src/main.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | use rom::Rom; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/registers.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | let mut register_f = self.get("0"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/registers.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let mut real_register_F: u8 = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut flags = [flag1, flag2, flag3, flag4]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu.rs:99:46 [INFO] [stdout] | [INFO] [stdout] 99 | fn execute_prefix_instruction(&mut self, mem: &mut Memory) -> i32{ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu.rs:134:53 [INFO] [stdout] | [INFO] [stdout] 134 | fn XOR(&mut self, instruction: InstructionData, mem: &mut Memory) ->i32 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stdin` [INFO] [stdout] --> src/main.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | let stdin = io::stdin().read_line(&mut read_enter); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_stdin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_Z` is never used [INFO] [stdout] --> src/instructions.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | pub const FLAG_Z:u8 = 7; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_N` is never used [INFO] [stdout] --> src/instructions.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const FLAG_N:u8 = 6; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_H` is never used [INFO] [stdout] --> src/instructions.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | pub const FLAG_H:u8 = 5; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_C` is never used [INFO] [stdout] --> src/instructions.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub const FLAG_C:u8 = 4; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mnemonic`, `length`, `flags`, and `addr` are never read [INFO] [stdout] --> src/cpu.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct InstructionData { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 12 | pub mnemonic: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 13 | pub length: i32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | pub cycles: Vec, [INFO] [stdout] 15 | pub flags: [char; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] 16 | pub addr: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InstructionData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BOOT_SIZE` is never used [INFO] [stdout] --> src/memory_bus.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | const BOOT_SIZE: usize = 256; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setBackground` should have a snake case name [INFO] [stdout] --> src/main.rs:119:4 [INFO] [stdout] | [INFO] [stdout] 119 | fn setBackground(buffer: &mut Vec, window: &mut Window) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `set_background` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | let mut real_register_F: u8 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_Z)<<7); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_N)<<6); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_H)<<5); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_C)<<4); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `LD` should have a snake case name [INFO] [stdout] --> src/cpu.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | fn LD(&mut self, instruction: InstructionData, mem: &mut Memory) -> i32{ [INFO] [stdout] | ^^ help: convert the identifier to snake case: `ld` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `byteJoin` should have a snake case name [INFO] [stdout] --> src/cpu.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | let byteJoin: u16 = (byte2 as u16) << 8 | byte1 as u16; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `byte_join` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `XOR` should have a snake case name [INFO] [stdout] --> src/cpu.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | fn XOR(&mut self, instruction: InstructionData, mem: &mut Memory) ->i32 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `xor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `register_A` should have a snake case name [INFO] [stdout] --> src/cpu.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let register_A = self.registers.get("A"); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `register_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/memory_bus.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | &mem.raw_memory[0..32768].copy_from_slice(&mem.raw_rom.buffer[0..32768]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 43 | let _ = &mem.raw_memory[0..32768].copy_from_slice(&mem.raw_rom.buffer[0..32768]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.36s [INFO] running `Command { std: "docker" "inspect" "0c2fa38d68ff98aa68bbb01ce7ad9cc312bd1e767b9366d9b55d1f5109d36865", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c2fa38d68ff98aa68bbb01ce7ad9cc312bd1e767b9366d9b55d1f5109d36865", kill_on_drop: false }` [INFO] [stdout] 0c2fa38d68ff98aa68bbb01ce7ad9cc312bd1e767b9366d9b55d1f5109d36865 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b819d27fca66e2c9bc98f64fbc3121d7f76bb53e4c84680d738dd3d5be4ad173 [INFO] running `Command { std: "docker" "start" "-a" "b819d27fca66e2c9bc98f64fbc3121d7f76bb53e4c84680d738dd3d5be4ad173", kill_on_drop: false }` [INFO] [stderr] Compiling LGB v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{self, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/registers.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | let result = (register_f & bit); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - let result = (register_f & bit); [INFO] [stdout] 46 + let result = register_f & bit; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/registers.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 55 | if(result != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - if(result != 0) { [INFO] [stdout] 55 + if result != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu.rs:143:11 [INFO] [stdout] | [INFO] [stdout] 143 | if(result_operation == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 143 - if(result_operation == 0) { [INFO] [stdout] 143 + if result_operation == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/rom.rs:27:11 [INFO] [stdout] | [INFO] [stdout] 27 | if(file.metadata().unwrap().len() >= 32768) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - if(file.metadata().unwrap().len() >= 32768) { [INFO] [stdout] 27 + if file.metadata().unwrap().len() >= 32768 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | 0x01 ... 0x03 => {mbc = Mbc::Mbc1}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | 0x05 ... 0x06 => {mbc = Mbc::Mbc2}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | 0x0F ... 0x13 => {mbc = Mbc::Mbc3}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | 0x15 ... 0x17 => {mbc = Mbc::Mbc4}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rom.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | 0x19 ... 0x1E => {mbc = Mbc::Mbc5}, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_bus.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | 0x0000...0x7FFF => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/memory_bus.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | if(self.boot_mode) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - if(self.boot_mode) { [INFO] [stdout] 57 + if self.boot_mode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rom::Rom` [INFO] [stdout] --> src/main.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | use rom::Rom; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/registers.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | let mut register_f = self.get("0"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/registers.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let mut real_register_F: u8 = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut flags = [flag1, flag2, flag3, flag4]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu.rs:99:46 [INFO] [stdout] | [INFO] [stdout] 99 | fn execute_prefix_instruction(&mut self, mem: &mut Memory) -> i32{ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu.rs:134:53 [INFO] [stdout] | [INFO] [stdout] 134 | fn XOR(&mut self, instruction: InstructionData, mem: &mut Memory) ->i32 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stdin` [INFO] [stdout] --> src/main.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | let stdin = io::stdin().read_line(&mut read_enter); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_stdin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_Z` is never used [INFO] [stdout] --> src/instructions.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | pub const FLAG_Z:u8 = 7; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_N` is never used [INFO] [stdout] --> src/instructions.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const FLAG_N:u8 = 6; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_H` is never used [INFO] [stdout] --> src/instructions.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | pub const FLAG_H:u8 = 5; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FLAG_C` is never used [INFO] [stdout] --> src/instructions.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub const FLAG_C:u8 = 4; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mnemonic`, `length`, `flags`, and `addr` are never read [INFO] [stdout] --> src/cpu.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct InstructionData { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 12 | pub mnemonic: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 13 | pub length: i32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | pub cycles: Vec, [INFO] [stdout] 15 | pub flags: [char; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] 16 | pub addr: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InstructionData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BOOT_SIZE` is never used [INFO] [stdout] --> src/memory_bus.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | const BOOT_SIZE: usize = 256; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setBackground` should have a snake case name [INFO] [stdout] --> src/main.rs:119:4 [INFO] [stdout] | [INFO] [stdout] 119 | fn setBackground(buffer: &mut Vec, window: &mut Window) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `set_background` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | let mut real_register_F: u8 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_Z)<<7); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_N)<<6); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_H)<<5); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `real_register_F` should have a snake case name [INFO] [stdout] --> src/registers.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | let real_register_F = real_register_F | (self.get_flag_bit(FLAG_C)<<4); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `real_register_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `LD` should have a snake case name [INFO] [stdout] --> src/cpu.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | fn LD(&mut self, instruction: InstructionData, mem: &mut Memory) -> i32{ [INFO] [stdout] | ^^ help: convert the identifier to snake case: `ld` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `byteJoin` should have a snake case name [INFO] [stdout] --> src/cpu.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | let byteJoin: u16 = (byte2 as u16) << 8 | byte1 as u16; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `byte_join` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `XOR` should have a snake case name [INFO] [stdout] --> src/cpu.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | fn XOR(&mut self, instruction: InstructionData, mem: &mut Memory) ->i32 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `xor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `register_A` should have a snake case name [INFO] [stdout] --> src/cpu.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let register_A = self.registers.get("A"); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `register_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/memory_bus.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | &mem.raw_memory[0..32768].copy_from_slice(&mem.raw_rom.buffer[0..32768]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 43 | let _ = &mem.raw_memory[0..32768].copy_from_slice(&mem.raw_rom.buffer[0..32768]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.38s [INFO] running `Command { std: "docker" "inspect" "b819d27fca66e2c9bc98f64fbc3121d7f76bb53e4c84680d738dd3d5be4ad173", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b819d27fca66e2c9bc98f64fbc3121d7f76bb53e4c84680d738dd3d5be4ad173", kill_on_drop: false }` [INFO] [stdout] b819d27fca66e2c9bc98f64fbc3121d7f76bb53e4c84680d738dd3d5be4ad173