[INFO] cloning repository https://github.com/jordan4ibanez/boom [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jordan4ibanez/boom" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjordan4ibanez%2Fboom", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjordan4ibanez%2Fboom'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8f3d6b8c80776dc4b266516afb92557d8abf066a [INFO] building jordan4ibanez/boom against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjordan4ibanez%2Fboom" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jordan4ibanez/boom on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/jordan4ibanez/boom [INFO] finished tweaking git repo https://github.com/jordan4ibanez/boom [INFO] tweaked toml for git repo https://github.com/jordan4ibanez/boom written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jordan4ibanez/boom already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 259481f9555ca6fc942129640bea28cf247f7d54f3c92b06ac847a20454acca7 [INFO] running `Command { std: "docker" "start" "-a" "259481f9555ca6fc942129640bea28cf247f7d54f3c92b06ac847a20454acca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "259481f9555ca6fc942129640bea28cf247f7d54f3c92b06ac847a20454acca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "259481f9555ca6fc942129640bea28cf247f7d54f3c92b06ac847a20454acca7", kill_on_drop: false }` [INFO] [stdout] 259481f9555ca6fc942129640bea28cf247f7d54f3c92b06ac847a20454acca7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6cee2b0ad1ce582012539dc53f5328cd54034fe77e666c7b3054cd6fd3c94af0 [INFO] running `Command { std: "docker" "start" "-a" "6cee2b0ad1ce582012539dc53f5328cd54034fe77e666c7b3054cd6fd3c94af0", kill_on_drop: false }` [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling simd-adler32 v0.3.7 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling glam v0.25.0 [INFO] [stderr] Compiling spin_sleep v1.1.1 [INFO] [stderr] Compiling miniz_oxide v0.7.1 [INFO] [stderr] Compiling fdeflate v0.3.3 [INFO] [stderr] Compiling crossbeam-epoch v0.9.17 [INFO] [stderr] Compiling flate2 v1.0.28 [INFO] [stderr] Compiling getrandom v0.2.11 [INFO] [stderr] Compiling crossbeam-deque v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling png v0.17.10 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling rayon v1.8.0 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Compiling boom v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:124:32 [INFO] [stdout] | [INFO] [stdout] 124 | let deltaDistX: f64 = if (rayDirX == 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 124 - let deltaDistX: f64 = if (rayDirX == 0.0) { [INFO] [stdout] 124 + let deltaDistX: f64 = if rayDirX == 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:129:32 [INFO] [stdout] | [INFO] [stdout] 129 | let deltaDistY: f64 = if (rayDirY == 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 129 - let deltaDistY: f64 = if (rayDirY == 0.0) { [INFO] [stdout] 129 + let deltaDistY: f64 = if rayDirY == 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:144:10 [INFO] [stdout] | [INFO] [stdout] 144 | if (rayDirX < 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - if (rayDirX < 0.0) { [INFO] [stdout] 144 + if rayDirX < 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:151:10 [INFO] [stdout] | [INFO] [stdout] 151 | if (rayDirY < 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if (rayDirY < 0.0) { [INFO] [stdout] 151 + if rayDirY < 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/boom/renderer.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 159 | while (hit == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 159 - while (hit == 0) { [INFO] [stdout] 159 + while hit == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if (sideDistX < sideDistY) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 161 - if (sideDistX < sideDistY) { [INFO] [stdout] 161 + if sideDistX < sideDistY { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 171 | if (worldMap[mapX as usize][mapY as usize] > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - if (worldMap[mapX as usize][mapY as usize] > 0) { [INFO] [stdout] 171 + if worldMap[mapX as usize][mapY as usize] > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/boom/renderer.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | perpWallDist = (sideDistX - deltaDistX) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - perpWallDist = (sideDistX - deltaDistX) [INFO] [stdout] 182 + perpWallDist = sideDistX - deltaDistX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/boom/renderer.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | perpWallDist = (sideDistY - deltaDistY) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 184 - perpWallDist = (sideDistY - deltaDistY) [INFO] [stdout] 184 + perpWallDist = sideDistY - deltaDistY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:192:10 [INFO] [stdout] | [INFO] [stdout] 192 | if (drawStart < 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - if (drawStart < 0) { [INFO] [stdout] 192 + if drawStart < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:196:10 [INFO] [stdout] | [INFO] [stdout] 196 | if (drawEnd >= h) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 196 - if (drawEnd >= h) { [INFO] [stdout] 196 + if drawEnd >= h { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/boom/renderer.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | match (worldMap[mapX as usize][mapY as usize]) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 205 - match (worldMap[mapX as usize][mapY as usize]) { [INFO] [stdout] 205 + match worldMap[mapX as usize][mapY as usize] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:222:10 [INFO] [stdout] | [INFO] [stdout] 222 | if (side == 1) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 222 - if (side == 1) { [INFO] [stdout] 222 + if side == 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/boom/renderer.rs:204:11 [INFO] [stdout] | [INFO] [stdout] 204 | let mut a: u8 = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:204:7 [INFO] [stdout] | [INFO] [stdout] 204 | moving = true [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:221:7 [INFO] [stdout] | [INFO] [stdout] 221 | moving = true; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:237:7 [INFO] [stdout] | [INFO] [stdout] 237 | moving = true; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:253:7 [INFO] [stdout] | [INFO] [stdout] 253 | moving = true; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dirX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | let dirX = dir.x; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dir_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dirY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let dirY = dir.y; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dir_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `planeX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | let planeX = plane.x; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `plane_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `planeY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | let planeY = plane.y; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `plane_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `posX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | let posX = pos.x; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `pos_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `posY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | let posY = pos.y; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `pos_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `worldMap` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | let worldMap = world.map.data; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `world_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `cameraX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | let cameraX: f64 = 2.0 * (x as f64) / (w as f64) - 1.0; //x-coordinate in camera space [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `camera_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayDirX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 103 | let rayDirX: f64 = dirX + planeX * cameraX; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ray_dir_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayDirY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:104:11 [INFO] [stdout] | [INFO] [stdout] 104 | let rayDirY = dirY + planeY * cameraX; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ray_dir_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `mapX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 106 | let mut mapX: i32 = (posX) as i32; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `map_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `mapY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 107 | let mut mapY: i32 = (posY) as i32; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `map_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `sideDistX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:110:15 [INFO] [stdout] | [INFO] [stdout] 110 | let mut sideDistX: f64; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `side_dist_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `sideDistY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:111:15 [INFO] [stdout] | [INFO] [stdout] 111 | let mut sideDistY: f64; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `side_dist_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `deltaDistX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 124 | let deltaDistX: f64 = if (rayDirX == 0.0) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delta_dist_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `deltaDistY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 129 | let deltaDistY: f64 = if (rayDirY == 0.0) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delta_dist_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `perpWallDist` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:135:11 [INFO] [stdout] | [INFO] [stdout] 135 | let perpWallDist: f64; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `perp_wall_dist` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `stepX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:138:11 [INFO] [stdout] | [INFO] [stdout] 138 | let stepX: i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `step_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `stepY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:139:11 [INFO] [stdout] | [INFO] [stdout] 139 | let stepY: i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `step_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `lineHeight` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:188:11 [INFO] [stdout] | [INFO] [stdout] 188 | let lineHeight: i32 = ((h as f64) / perpWallDist) as i32; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `line_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `drawStart` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:191:15 [INFO] [stdout] | [INFO] [stdout] 191 | let mut drawStart: i32 = -lineHeight / 2 + h / 2; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `draw_start` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `drawEnd` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:195:15 [INFO] [stdout] | [INFO] [stdout] 195 | let mut drawEnd: i32 = lineHeight / 2 + h / 2; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `draw_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 58.35s [INFO] running `Command { std: "docker" "inspect" "6cee2b0ad1ce582012539dc53f5328cd54034fe77e666c7b3054cd6fd3c94af0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cee2b0ad1ce582012539dc53f5328cd54034fe77e666c7b3054cd6fd3c94af0", kill_on_drop: false }` [INFO] [stdout] 6cee2b0ad1ce582012539dc53f5328cd54034fe77e666c7b3054cd6fd3c94af0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 005f407f009a11beb81e2bdaa23e53fabd6bd29cacc5f3c224bbab5764f70516 [INFO] running `Command { std: "docker" "start" "-a" "005f407f009a11beb81e2bdaa23e53fabd6bd29cacc5f3c224bbab5764f70516", kill_on_drop: false }` [INFO] [stderr] Compiling boom v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:124:32 [INFO] [stdout] | [INFO] [stdout] 124 | let deltaDistX: f64 = if (rayDirX == 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 124 - let deltaDistX: f64 = if (rayDirX == 0.0) { [INFO] [stdout] 124 + let deltaDistX: f64 = if rayDirX == 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:129:32 [INFO] [stdout] | [INFO] [stdout] 129 | let deltaDistY: f64 = if (rayDirY == 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 129 - let deltaDistY: f64 = if (rayDirY == 0.0) { [INFO] [stdout] 129 + let deltaDistY: f64 = if rayDirY == 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:144:10 [INFO] [stdout] | [INFO] [stdout] 144 | if (rayDirX < 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - if (rayDirX < 0.0) { [INFO] [stdout] 144 + if rayDirX < 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:151:10 [INFO] [stdout] | [INFO] [stdout] 151 | if (rayDirY < 0.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if (rayDirY < 0.0) { [INFO] [stdout] 151 + if rayDirY < 0.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/boom/renderer.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 159 | while (hit == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 159 - while (hit == 0) { [INFO] [stdout] 159 + while hit == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if (sideDistX < sideDistY) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 161 - if (sideDistX < sideDistY) { [INFO] [stdout] 161 + if sideDistX < sideDistY { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 171 | if (worldMap[mapX as usize][mapY as usize] > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - if (worldMap[mapX as usize][mapY as usize] > 0) { [INFO] [stdout] 171 + if worldMap[mapX as usize][mapY as usize] > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/boom/renderer.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | perpWallDist = (sideDistX - deltaDistX) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - perpWallDist = (sideDistX - deltaDistX) [INFO] [stdout] 182 + perpWallDist = sideDistX - deltaDistX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/boom/renderer.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | perpWallDist = (sideDistY - deltaDistY) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 184 - perpWallDist = (sideDistY - deltaDistY) [INFO] [stdout] 184 + perpWallDist = sideDistY - deltaDistY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:192:10 [INFO] [stdout] | [INFO] [stdout] 192 | if (drawStart < 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - if (drawStart < 0) { [INFO] [stdout] 192 + if drawStart < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:196:10 [INFO] [stdout] | [INFO] [stdout] 196 | if (drawEnd >= h) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 196 - if (drawEnd >= h) { [INFO] [stdout] 196 + if drawEnd >= h { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/boom/renderer.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | match (worldMap[mapX as usize][mapY as usize]) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 205 - match (worldMap[mapX as usize][mapY as usize]) { [INFO] [stdout] 205 + match worldMap[mapX as usize][mapY as usize] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/boom/renderer.rs:222:10 [INFO] [stdout] | [INFO] [stdout] 222 | if (side == 1) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 222 - if (side == 1) { [INFO] [stdout] 222 + if side == 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/boom/renderer.rs:204:11 [INFO] [stdout] | [INFO] [stdout] 204 | let mut a: u8 = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:204:7 [INFO] [stdout] | [INFO] [stdout] 204 | moving = true [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:221:7 [INFO] [stdout] | [INFO] [stdout] 221 | moving = true; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:237:7 [INFO] [stdout] | [INFO] [stdout] 237 | moving = true; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `moving` is never read [INFO] [stdout] --> src/boom/world.rs:253:7 [INFO] [stdout] | [INFO] [stdout] 253 | moving = true; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dirX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | let dirX = dir.x; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dir_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dirY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let dirY = dir.y; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dir_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `planeX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | let planeX = plane.x; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `plane_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `planeY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | let planeY = plane.y; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `plane_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `posX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | let posX = pos.x; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `pos_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `posY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | let posY = pos.y; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `pos_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `worldMap` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | let worldMap = world.map.data; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `world_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `cameraX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | let cameraX: f64 = 2.0 * (x as f64) / (w as f64) - 1.0; //x-coordinate in camera space [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `camera_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayDirX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 103 | let rayDirX: f64 = dirX + planeX * cameraX; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ray_dir_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayDirY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:104:11 [INFO] [stdout] | [INFO] [stdout] 104 | let rayDirY = dirY + planeY * cameraX; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ray_dir_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `mapX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 106 | let mut mapX: i32 = (posX) as i32; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `map_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `mapY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 107 | let mut mapY: i32 = (posY) as i32; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `map_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `sideDistX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:110:15 [INFO] [stdout] | [INFO] [stdout] 110 | let mut sideDistX: f64; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `side_dist_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `sideDistY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:111:15 [INFO] [stdout] | [INFO] [stdout] 111 | let mut sideDistY: f64; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `side_dist_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `deltaDistX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 124 | let deltaDistX: f64 = if (rayDirX == 0.0) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delta_dist_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `deltaDistY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 129 | let deltaDistY: f64 = if (rayDirY == 0.0) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delta_dist_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `perpWallDist` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:135:11 [INFO] [stdout] | [INFO] [stdout] 135 | let perpWallDist: f64; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `perp_wall_dist` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `stepX` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:138:11 [INFO] [stdout] | [INFO] [stdout] 138 | let stepX: i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `step_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `stepY` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:139:11 [INFO] [stdout] | [INFO] [stdout] 139 | let stepY: i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `step_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `lineHeight` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:188:11 [INFO] [stdout] | [INFO] [stdout] 188 | let lineHeight: i32 = ((h as f64) / perpWallDist) as i32; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `line_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `drawStart` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:191:15 [INFO] [stdout] | [INFO] [stdout] 191 | let mut drawStart: i32 = -lineHeight / 2 + h / 2; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `draw_start` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `drawEnd` should have a snake case name [INFO] [stdout] --> src/boom/renderer.rs:195:15 [INFO] [stdout] | [INFO] [stdout] 195 | let mut drawEnd: i32 = lineHeight / 2 + h / 2; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `draw_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.30s [INFO] running `Command { std: "docker" "inspect" "005f407f009a11beb81e2bdaa23e53fabd6bd29cacc5f3c224bbab5764f70516", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "005f407f009a11beb81e2bdaa23e53fabd6bd29cacc5f3c224bbab5764f70516", kill_on_drop: false }` [INFO] [stdout] 005f407f009a11beb81e2bdaa23e53fabd6bd29cacc5f3c224bbab5764f70516