[INFO] cloning repository https://github.com/johnward/bft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/johnward/bft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjohnward%2Fbft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjohnward%2Fbft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c167d9a66aece1c6c434135eb96da1e202ac5bc1 [INFO] building johnward/bft against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjohnward%2Fbft" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/johnward/bft on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/johnward/bft [INFO] finished tweaking git repo https://github.com/johnward/bft [INFO] tweaked toml for git repo https://github.com/johnward/bft written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/johnward/bft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fecd133f40f236b6c03b3415c054208cf24e7caacfda7773c5d0c627c547cc5c [INFO] running `Command { std: "docker" "start" "-a" "fecd133f40f236b6c03b3415c054208cf24e7caacfda7773c5d0c627c547cc5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fecd133f40f236b6c03b3415c054208cf24e7caacfda7773c5d0c627c547cc5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fecd133f40f236b6c03b3415c054208cf24e7caacfda7773c5d0c627c547cc5c", kill_on_drop: false }` [INFO] [stdout] fecd133f40f236b6c03b3415c054208cf24e7caacfda7773c5d0c627c547cc5c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e27deb0bd23ba56425d2cff543a4ac5339787fa796dfaec12741cdeebc69394c [INFO] running `Command { std: "docker" "start" "-a" "e27deb0bd23ba56425d2cff543a4ac5339787fa796dfaec12741cdeebc69394c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling unicode-width v0.1.6 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling bft_types v0.1.0 (/opt/rustwide/workdir/bft_types) [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling bft_interp v0.1.0 (/opt/rustwide/workdir/bft_interp) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> bft_interp/src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | (number_to_add - ((u8::max_value() - current_number) + 1)) // + 1 to take into account the zero [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - (number_to_add - ((u8::max_value() - current_number) + 1)) // + 1 to take into account the zero [INFO] [stdout] 50 + number_to_add - ((u8::max_value() - current_number) + 1) // + 1 to take into account the zero [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> bft_interp/src/lib.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | (u8::max_value() - ((number_to_sub - current_number) - 1)) // - 1 to take into account the zero [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - (u8::max_value() - ((number_to_sub - current_number) - 1)) // - 1 to take into account the zero [INFO] [stdout] 59 + u8::max_value() - ((number_to_sub - current_number) - 1) // - 1 to take into account the zero [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `can_grow` is never read [INFO] [stdout] --> bft_interp/src/lib.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 99 | pub struct BFVirtualMachine<'a, T> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 103 | can_grow: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BFVirtualMachine` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling atty v0.2.13 [INFO] [stderr] Compiling clap v2.33.0 [INFO] [stderr] Compiling bft v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.35s [INFO] running `Command { std: "docker" "inspect" "e27deb0bd23ba56425d2cff543a4ac5339787fa796dfaec12741cdeebc69394c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e27deb0bd23ba56425d2cff543a4ac5339787fa796dfaec12741cdeebc69394c", kill_on_drop: false }` [INFO] [stdout] e27deb0bd23ba56425d2cff543a4ac5339787fa796dfaec12741cdeebc69394c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af8f0c0f594cbe86d9b076cf20756ba1877c35ffca8de5e511d50ea7feed2d8f [INFO] running `Command { std: "docker" "start" "-a" "af8f0c0f594cbe86d9b076cf20756ba1877c35ffca8de5e511d50ea7feed2d8f", kill_on_drop: false }` [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> bft_interp/src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | (number_to_add - ((u8::max_value() - current_number) + 1)) // + 1 to take into account the zero [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - (number_to_add - ((u8::max_value() - current_number) + 1)) // + 1 to take into account the zero [INFO] [stdout] 50 + number_to_add - ((u8::max_value() - current_number) + 1) // + 1 to take into account the zero [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> bft_interp/src/lib.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | (u8::max_value() - ((number_to_sub - current_number) - 1)) // - 1 to take into account the zero [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - (u8::max_value() - ((number_to_sub - current_number) - 1)) // - 1 to take into account the zero [INFO] [stdout] 59 + u8::max_value() - ((number_to_sub - current_number) - 1) // - 1 to take into account the zero [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `can_grow` is never read [INFO] [stdout] --> bft_interp/src/lib.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 99 | pub struct BFVirtualMachine<'a, T> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 103 | can_grow: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BFVirtualMachine` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling bft v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "af8f0c0f594cbe86d9b076cf20756ba1877c35ffca8de5e511d50ea7feed2d8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af8f0c0f594cbe86d9b076cf20756ba1877c35ffca8de5e511d50ea7feed2d8f", kill_on_drop: false }` [INFO] [stdout] af8f0c0f594cbe86d9b076cf20756ba1877c35ffca8de5e511d50ea7feed2d8f