[INFO] cloning repository https://github.com/jinbijin/advent-of-code-2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jinbijin/advent-of-code-2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjinbijin%2Fadvent-of-code-2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjinbijin%2Fadvent-of-code-2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f7c87dc2f92db793f54bc78a64941f9bf3df0ac [INFO] building jinbijin/advent-of-code-2022 against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjinbijin%2Fadvent-of-code-2022" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jinbijin/advent-of-code-2022 on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jinbijin/advent-of-code-2022 [INFO] finished tweaking git repo https://github.com/jinbijin/advent-of-code-2022 [INFO] tweaked toml for git repo https://github.com/jinbijin/advent-of-code-2022 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jinbijin/advent-of-code-2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.83 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.83 [INFO] [stderr] Downloaded unicode-ident v1.0.5 [INFO] [stderr] Downloaded serde-wasm-bindgen v0.4.5 [INFO] [stderr] Downloaded serde_derive v1.0.151 [INFO] [stderr] Downloaded js-sys v0.3.60 [INFO] [stderr] Downloaded serde v1.0.151 [INFO] [stderr] Downloaded bumpalo v3.11.1 [INFO] [stderr] Downloaded log v0.4.17 [INFO] [stderr] Downloaded once_cell v1.16.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.47 [INFO] [stderr] Downloaded quote v1.0.21 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.83 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.83 [INFO] [stderr] Downloaded syn v1.0.105 [INFO] [stderr] Downloaded wasm-bindgen v0.2.83 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85cce9c80364dcffca53062e09530d2f590a76994ce0257d4ce0a8dfda580562 [INFO] running `Command { std: "docker" "start" "-a" "85cce9c80364dcffca53062e09530d2f590a76994ce0257d4ce0a8dfda580562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85cce9c80364dcffca53062e09530d2f590a76994ce0257d4ce0a8dfda580562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85cce9c80364dcffca53062e09530d2f590a76994ce0257d4ce0a8dfda580562", kill_on_drop: false }` [INFO] [stdout] 85cce9c80364dcffca53062e09530d2f590a76994ce0257d4ce0a8dfda580562 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64c29f66dd5fc46054dbbae3650ca5318d020196eea6b9bf1b08c080e19741b7 [INFO] running `Command { std: "docker" "start" "-a" "64c29f66dd5fc46054dbbae3650ca5318d020196eea6b9bf1b08c080e19741b7", kill_on_drop: false }` [INFO] [stderr] Compiling advent-of-code-2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/puzzles/grove_positioning_system/mill.rs:44:42 [INFO] [stdout] | [INFO] [stdout] 40 | let mut node = self.nodes.borrow()[index].clone(); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `node` calls a custom destructor [INFO] [stdout] | `node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | if let Some(next_node) = next_node.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `node` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/puzzles/grove_positioning_system/mill.rs:43:40 [INFO] [stdout] | [INFO] [stdout] 40 | let mut node = self.nodes.borrow()[index].clone(); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `node` calls a custom destructor [INFO] [stdout] | `node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | if let Some(next_node) = &*node.clone().next.borrow() { [INFO] [stdout] | ------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `node` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/puzzles/grove_positioning_system/mill.rs:108:47 [INFO] [stdout] | [INFO] [stdout] 102 | let mut previous_node = previous_node; [INFO] [stdout] | ----------------- [INFO] [stdout] | | [INFO] [stdout] | `previous_node` calls a custom destructor [INFO] [stdout] | `previous_node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | if let Some(next_next_node) = next_next_node.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `previous_node` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/puzzles/grove_positioning_system/mill.rs:107:45 [INFO] [stdout] | [INFO] [stdout] 102 | let mut previous_node = previous_node; [INFO] [stdout] | ----------------- [INFO] [stdout] | | [INFO] [stdout] | `previous_node` calls a custom destructor [INFO] [stdout] | `previous_node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | if let Some(next_next_node) = &*next_node.clone().next.borrow() { [INFO] [stdout] | -----------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `previous_node` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/puzzles/grove_positioning_system/mill.rs:161:55 [INFO] [stdout] | [INFO] [stdout] 156 | let mut next_node = next_node; [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | `next_node` calls a custom destructor [INFO] [stdout] | `next_node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | if let Some(previous_previous_node) = previous_previous_node.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `next_node` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/puzzles/grove_positioning_system/mill.rs:160:53 [INFO] [stdout] | [INFO] [stdout] 156 | let mut next_node = next_node; [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | `next_node` calls a custom destructor [INFO] [stdout] | `next_node` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | if let Some(previous_previous_node) = &*previous_node.clone().previous.borrow() { [INFO] [stdout] | ---------------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] note: `next_node` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/alloc/src/rc.rs:3426:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start` and `end` are never read [INFO] [stdout] --> src/common/interval.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | EndBeforeStart { start: T, end: T }, [INFO] [stdout] | -------------- ^^^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `BuildIntervalError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/parse/chars.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct ByChars(pub Vec); [INFO] [stdout] | ------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/parse/sections.rs:54:14 [INFO] [stdout] | [INFO] [stdout] 54 | Continue(char), [INFO] [stdout] | -------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ContentSectionCharIterationResult` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 54 | Continue(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/puzzles/no_space_left_on_device/file_tree.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct File { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 7 | pub size: usize, [INFO] [stdout] 8 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `File` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opponent_choice` is never read [INFO] [stdout] --> src/puzzles/rock_paper_scissors/rps_match.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct RpsMatch { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 13 | pub opponent_choice: RpsType, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `required` is never read [INFO] [stdout] --> src/puzzles/rock_paper_scissors/strategy.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | Empty { [INFO] [stdout] | ----- field in this variant [INFO] [stdout] 112 | required: True, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseRpsStrategyError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code-2022` (lib) due to 6 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "64c29f66dd5fc46054dbbae3650ca5318d020196eea6b9bf1b08c080e19741b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64c29f66dd5fc46054dbbae3650ca5318d020196eea6b9bf1b08c080e19741b7", kill_on_drop: false }` [INFO] [stdout] 64c29f66dd5fc46054dbbae3650ca5318d020196eea6b9bf1b08c080e19741b7