[INFO] cloning repository https://github.com/hansihe/rust_iterative_json_parser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hansihe/rust_iterative_json_parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhansihe%2Frust_iterative_json_parser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhansihe%2Frust_iterative_json_parser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f0ffa48024c44cdc26d65118cdc1114ca8900bd [INFO] building hansihe/rust_iterative_json_parser against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhansihe%2Frust_iterative_json_parser" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/hansihe/rust_iterative_json_parser on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/hansihe/rust_iterative_json_parser [INFO] finished tweaking git repo https://github.com/hansihe/rust_iterative_json_parser [INFO] tweaked toml for git repo https://github.com/hansihe/rust_iterative_json_parser written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/hansihe/rust_iterative_json_parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: unused manifest key: lib.src [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded simd v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a550933bf682da5faa337e1c8882032250d294c99c355ba0e80544052e0f91be [INFO] running `Command { std: "docker" "start" "-a" "a550933bf682da5faa337e1c8882032250d294c99c355ba0e80544052e0f91be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a550933bf682da5faa337e1c8882032250d294c99c355ba0e80544052e0f91be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a550933bf682da5faa337e1c8882032250d294c99c355ba0e80544052e0f91be", kill_on_drop: false }` [INFO] [stdout] a550933bf682da5faa337e1c8882032250d294c99c355ba0e80544052e0f91be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be1ad2308ca2708b616abb1df8ce6fa507de3ce94186f1faff6444cdde4f6221 [INFO] running `Command { std: "docker" "start" "-a" "be1ad2308ca2708b616abb1df8ce6fa507de3ce94186f1faff6444cdde4f6221", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: unused manifest key: lib.src [INFO] [stderr] Compiling iterative_json_parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused macro definition: `lift_bail` [INFO] [stdout] --> src/parser.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | macro_rules! lift_bail { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/tokenizer.rs:272:29 [INFO] [stdout] | [INFO] [stdout] 272 | b'A'...b'F' => *codepoint |= (byte - b'A' + 10) as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/tokenizer.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | b'a'...b'f' => *codepoint |= (byte - b'a' + 10) as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/tokenizer.rs:274:29 [INFO] [stdout] | [INFO] [stdout] 274 | b'0'...b'9' => *codepoint |= (byte - b'0') as u32, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/tokenizer.rs:319:36 [INFO] [stdout] | [INFO] [stdout] 319 | PeekResult::Ok(b'0'...b'9') => ss.skip(1), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/tokenizer.rs:368:29 [INFO] [stdout] | [INFO] [stdout] 368 | b'0'...b'9' => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/sink/into_enum.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 29 | impl<'a> EnumSink<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 30 | pub fn new(source: &'a [u8]) -> EnumSink { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/sink/into_enum.rs:38:45 [INFO] [stdout] | [INFO] [stdout] 29 | impl<'a> EnumSink<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn new_bailing(source: &'a [u8]) -> EnumSink { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `::PResult` [INFO] [stdout] --> src/source/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use ::PResult; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `token` [INFO] [stdout] --> src/parser.rs:136:14 [INFO] [stdout] | [INFO] [stdout] 136 | fn log_token(token: &str) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_token` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tokenizer.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | match (self.string_state, ss.peek_char()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | up until Edition 2021 `#6` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | self.parser.token_string_range(ss, range)?; [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | self.parser.token_string_range(ss, range)?; [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | self.parser.token_string_single(ss, escaped)?; [INFO] [stdout] | --------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | self.parser.token_string_codepoint(ss, character)?; [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | self.parser.token_string_codepoint(ss, character)?; [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Decoder` is never constructed [INFO] [stdout] --> src/decoder.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Decoder { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/decoder.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | impl Decoder { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 10 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iterative_json_parser` (lib) due to 1 previous error; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "be1ad2308ca2708b616abb1df8ce6fa507de3ce94186f1faff6444cdde4f6221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be1ad2308ca2708b616abb1df8ce6fa507de3ce94186f1faff6444cdde4f6221", kill_on_drop: false }` [INFO] [stdout] be1ad2308ca2708b616abb1df8ce6fa507de3ce94186f1faff6444cdde4f6221