[INFO] cloning repository https://github.com/drpacman/nand2tetris [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/drpacman/nand2tetris" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrpacman%2Fnand2tetris", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrpacman%2Fnand2tetris'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 40ba9ff3c2631c6a9daeef804ff6489f9961a25e [INFO] building drpacman/nand2tetris against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrpacman%2Fnand2tetris" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/drpacman/nand2tetris on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/drpacman/nand2tetris [INFO] finished tweaking git repo https://github.com/drpacman/nand2tetris [INFO] tweaked toml for git repo https://github.com/drpacman/nand2tetris written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/drpacman/nand2tetris already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 669cf8e9688d3c2a8dd1512ab6b8c20fb5f9b3eb872100aa28b33079440b111a [INFO] running `Command { std: "docker" "start" "-a" "669cf8e9688d3c2a8dd1512ab6b8c20fb5f9b3eb872100aa28b33079440b111a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "669cf8e9688d3c2a8dd1512ab6b8c20fb5f9b3eb872100aa28b33079440b111a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "669cf8e9688d3c2a8dd1512ab6b8c20fb5f9b3eb872100aa28b33079440b111a", kill_on_drop: false }` [INFO] [stdout] 669cf8e9688d3c2a8dd1512ab6b8c20fb5f9b3eb872100aa28b33079440b111a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2185646f40feca1cbfae340d589c72b0db6e933867906aaaf7a82eca43e3a07 [INFO] running `Command { std: "docker" "start" "-a" "c2185646f40feca1cbfae340d589c72b0db6e933867906aaaf7a82eca43e3a07", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling assembler v0.1.0 (/opt/rustwide/workdir/projects/assembler) [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling aho-corasick v0.7.20 [INFO] [stderr] Compiling regex v1.7.3 [INFO] [stderr] Compiling vmtranslator v0.1.0 (/opt/rustwide/workdir/projects/vmtranslator) [INFO] [stderr] Compiling compiler v0.1.0 (/opt/rustwide/workdir/projects/compiler) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> projects/compiler/src/vmcompiler.rs:520:76 [INFO] [stdout] | [INFO] [stdout] 520 | let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SymbolTableEntry` does not implement `Clone`, so calling `clone` on `&SymbolTableEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 520 - let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] 520 + let symbol_entry = self.lookup_symbol(&id).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SymbolTableEntry`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 135 + #[derive(Clone)] [INFO] [stdout] 136 | struct SymbolTableEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> projects/compiler/src/vmcompiler.rs:586:76 [INFO] [stdout] | [INFO] [stdout] 586 | let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SymbolTableEntry` does not implement `Clone`, so calling `clone` on `&SymbolTableEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 586 - let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] 586 + let symbol_entry = self.lookup_symbol(&id).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SymbolTableEntry`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 135 + #[derive(Clone)] [INFO] [stdout] 136 | struct SymbolTableEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.84s [INFO] running `Command { std: "docker" "inspect" "c2185646f40feca1cbfae340d589c72b0db6e933867906aaaf7a82eca43e3a07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2185646f40feca1cbfae340d589c72b0db6e933867906aaaf7a82eca43e3a07", kill_on_drop: false }` [INFO] [stdout] c2185646f40feca1cbfae340d589c72b0db6e933867906aaaf7a82eca43e3a07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb366e24e964ed2b7be9ed0ee96ee95aecef50f4174a181fc76b589d90dd5769 [INFO] running `Command { std: "docker" "start" "-a" "bb366e24e964ed2b7be9ed0ee96ee95aecef50f4174a181fc76b589d90dd5769", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling assembler v0.1.0 (/opt/rustwide/workdir/projects/assembler) [INFO] [stderr] Compiling vmtranslator v0.1.0 (/opt/rustwide/workdir/projects/vmtranslator) [INFO] [stderr] Compiling compiler v0.1.0 (/opt/rustwide/workdir/projects/compiler) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> projects/compiler/src/vmcompiler.rs:520:76 [INFO] [stdout] | [INFO] [stdout] 520 | let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SymbolTableEntry` does not implement `Clone`, so calling `clone` on `&SymbolTableEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 520 - let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] 520 + let symbol_entry = self.lookup_symbol(&id).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SymbolTableEntry`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 135 + #[derive(Clone)] [INFO] [stdout] 136 | struct SymbolTableEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> projects/compiler/src/vmcompiler.rs:586:76 [INFO] [stdout] | [INFO] [stdout] 586 | let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SymbolTableEntry` does not implement `Clone`, so calling `clone` on `&SymbolTableEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 586 - let symbol_entry = self.lookup_symbol(&id).unwrap().clone(); [INFO] [stdout] 586 + let symbol_entry = self.lookup_symbol(&id).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SymbolTableEntry`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 135 + #[derive(Clone)] [INFO] [stdout] 136 | struct SymbolTableEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "bb366e24e964ed2b7be9ed0ee96ee95aecef50f4174a181fc76b589d90dd5769", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb366e24e964ed2b7be9ed0ee96ee95aecef50f4174a181fc76b589d90dd5769", kill_on_drop: false }` [INFO] [stdout] bb366e24e964ed2b7be9ed0ee96ee95aecef50f4174a181fc76b589d90dd5769