[INFO] cloning repository https://github.com/droidengineer/battledroids [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/droidengineer/battledroids" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdroidengineer%2Fbattledroids", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdroidengineer%2Fbattledroids'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8b471e44ee3075bb2c86d23fa4d3ba3e11815b34 [INFO] building droidengineer/battledroids against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdroidengineer%2Fbattledroids" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/droidengineer/battledroids on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/droidengineer/battledroids [INFO] finished tweaking git repo https://github.com/droidengineer/battledroids [INFO] tweaked toml for git repo https://github.com/droidengineer/battledroids written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/droidengineer/battledroids already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d06ed5b0b14b3f0cfb275921a5b863183aa111190647c91fda9c64dee3f40db9 [INFO] running `Command { std: "docker" "start" "-a" "d06ed5b0b14b3f0cfb275921a5b863183aa111190647c91fda9c64dee3f40db9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d06ed5b0b14b3f0cfb275921a5b863183aa111190647c91fda9c64dee3f40db9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d06ed5b0b14b3f0cfb275921a5b863183aa111190647c91fda9c64dee3f40db9", kill_on_drop: false }` [INFO] [stdout] d06ed5b0b14b3f0cfb275921a5b863183aa111190647c91fda9c64dee3f40db9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96ddeaa8591f530479f320eb5c2647068215d89106ce3a1250241175ec1ae332 [INFO] running `Command { std: "docker" "start" "-a" "96ddeaa8591f530479f320eb5c2647068215d89106ce3a1250241175ec1ae332", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling regex-syntax v0.6.28 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling termcolor v1.1.3 [INFO] [stderr] Compiling paste v1.0.9 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling aho-corasick v0.7.20 [INFO] [stderr] Compiling getrandom v0.2.8 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling rmp v0.8.11 [INFO] [stderr] Compiling enum_primitive v0.1.1 [INFO] [stderr] Compiling regex v1.7.0 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Compiling pretty_env_logger v0.4.0 [INFO] [stderr] Compiling battledroids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Deref` [INFO] [stdout] --> src/emu/cpu/register.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::{Index, IndexMut, Deref}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToPrimitive` [INFO] [stdout] --> src/emu/cpu/register.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | use num_traits::{FromPrimitive, ToPrimitive}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `SREG_MASK` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum SREG_MASK { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `SregMask` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PE_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `PeId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CU_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `CuId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CG_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `CgId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DEVICE_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:26 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `DeviceId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FromPrimitive` and `ToPrimitive` [INFO] [stdout] --> src/emu/cpu/isa.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | use num_traits::{FromPrimitive, ToPrimitive}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `types` [INFO] [stdout] --> src/emu/cpu/isa.rs:121:62 [INFO] [stdout] | [INFO] [stdout] 121 | use crate::{emu::{Register, isa::{valid_u16, valid_u8}}, types}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `code` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/isa.rs:128:14 [INFO] [stdout] | [INFO] [stdout] 128 | pub enum code { [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/emu/cpu/isa.rs:367:39 [INFO] [stdout] | [INFO] [stdout] 367 | use std::{collections::HashMap, fmt::{Error, Display}, str::FromStr}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex::internal::Inst` [INFO] [stdout] --> src/emu/cpu/pe.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use regex::internal::Inst; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FLASH_MAX` [INFO] [stdout] --> src/emu/cpu/pe.rs:14:60 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::emu::{INSTRUCTIONS_MAX, SRAM_MAX, L2_CACHE_MAX, FLASH_MAX}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MASK_EXT`, `MASK_OP`, `MASK_RD`, `MASK_RS`, and `MASK_XD` [INFO] [stdout] --> src/emu/cpu/pe.rs:20:52 [INFO] [stdout] | [INFO] [stdout] 20 | use super::isa::{ISA, Instruction, Instruction::*, MASK_OP, MASK_RD, MASK_RS, MASK_EXT, MASK_XD, op, }; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ ^^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `addr_t` [INFO] [stdout] --> src/emu/code.rs:12:83 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::types::{from_byte_code::FromByteCode,to_byte_code::ToByteCode, code_t, addr_t, table::Table}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/isa.rs:177:38 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn to_instruction(&self, args: &[u16]) -> Instruction { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/emu/cpu/isa.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | _ => Instruction::UnknownOp(args[0].parse::().unwrap()), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/emu/cpu/isa.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 184 | code::ADD => Instruction::ADD(Register::from(args[1]), Register::from(args[2])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 185 | code::ADDI => Instruction::ADDI(Register::from(args[1]), valid_u16(args[2])), [INFO] [stdout] | ---------- matches some of the same values [INFO] [stdout] 186 | code::AND => Instruction::AND(Register::from(args[1]), Register::from(args[2])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 187 | code::ASR => Instruction::ASR(Register::from(args[1])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 240 | _ => Instruction::UnknownOp(args[0].parse::().unwrap()), [INFO] [stdout] | ^ ...and 51 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/isa.rs:594:17 [INFO] [stdout] | [INFO] [stdout] 594 | CPI(rd, i) => todo!(), [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/emu/cpu/isa.rs:594:21 [INFO] [stdout] | [INFO] [stdout] 594 | CPI(rd, i) => todo!(), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/emu/cpu/isa.rs:829:13 [INFO] [stdout] | [INFO] [stdout] 829 | _ => format!("??") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/emu/cpu/isa.rs:829:13 [INFO] [stdout] | [INFO] [stdout] 773 | Instruction::ADD(rd,rs) => format!("ADD {:?}, {:?}",rd,rs), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 774 | Instruction::ADDI(rd,imm) => format!("ADDI {:?}, {imm}",rd), [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] 775 | Instruction::AND(rd,rs) => format!("AND {:?}, {:?}",rd,rs), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 776 | Instruction::ASR(rd) => format!("ASR {:?}", rd), [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 829 | _ => format!("??") [INFO] [stdout] | ^ ...and 52 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/isa.rs:919:30 [INFO] [stdout] | [INFO] [stdout] 919 | pub fn insert(&mut self, instr: Instruction) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/isa.rs:929:17 [INFO] [stdout] | [INFO] [stdout] 929 | let instr = &self.0[key]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/isa.rs:927:13 [INFO] [stdout] | [INFO] [stdout] 927 | let mut result = vec![]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `instr` is never read [INFO] [stdout] --> src/emu/cpu/pe.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let mut instr = Instruction::UnknownOp(code); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/pe.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | let mut code = &mut builder.instructions.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/pe.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | let mut data = &mut builder.data.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/pe.rs:285:22 [INFO] [stdout] | [INFO] [stdout] 285 | fn encode(&self, instr: Instruction) -> code_t { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/emu/cpu/pe.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let opcode = self.get_opcode(instr); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:326:18 [INFO] [stdout] | [INFO] [stdout] 326 | BREQ(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:327:18 [INFO] [stdout] | [INFO] [stdout] 327 | BRGE(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 329 | BRLO(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:330:18 [INFO] [stdout] | [INFO] [stdout] 330 | BRLT(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:331:18 [INFO] [stdout] | [INFO] [stdout] 331 | BRNE(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:332:18 [INFO] [stdout] | [INFO] [stdout] 332 | BRSH(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/emu/cpu/pe.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | CBIO(addr,bit) => { todo!() }, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bit` [INFO] [stdout] --> src/emu/cpu/pe.rs:345:23 [INFO] [stdout] | [INFO] [stdout] 345 | CBIO(addr,bit) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | CBR(r,v) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/emu/cpu/pe.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 346 | CBR(r,v) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 347 | CLR(r) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:353:17 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `K` [INFO] [stdout] --> src/emu/cpu/pe.rs:353:19 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_K` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 354 | CPSE(rd,rs) => { todo!() }, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rs` [INFO] [stdout] --> src/emu/cpu/pe.rs:354:21 [INFO] [stdout] | [INFO] [stdout] 354 | CPSE(rd,rs) => { todo!() }, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:377:16 [INFO] [stdout] | [INFO] [stdout] 377 | IN(rd, imm) => { todo!()}, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:377:20 [INFO] [stdout] | [INFO] [stdout] 377 | IN(rd, imm) => { todo!()}, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:466:19 [INFO] [stdout] | [INFO] [stdout] 466 | RCALL(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:471:18 [INFO] [stdout] | [INFO] [stdout] 471 | RJMP(imm) => { todo!(); }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/emu/cpu/pe.rs:472:18 [INFO] [stdout] | [INFO] [stdout] 472 | SBIO(addr, bit) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bit` [INFO] [stdout] --> src/emu/cpu/pe.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 472 | SBIO(addr, bit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:480:17 [INFO] [stdout] | [INFO] [stdout] 480 | SET(rd) => {todo!();}, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:515:20 [INFO] [stdout] | [INFO] [stdout] 515 | fn halt(&self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:518:19 [INFO] [stdout] | [INFO] [stdout] 518 | fn brk(&self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:529:13 [INFO] [stdout] | [INFO] [stdout] 529 | let rd = Register::from_u16(args[0]).unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:547:24 [INFO] [stdout] | [INFO] [stdout] 547 | fn call(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:551:24 [INFO] [stdout] | [INFO] [stdout] 551 | fn cbio(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:561:13 [INFO] [stdout] | [INFO] [stdout] 561 | let rd = Register::from_u16(args[0]).unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:588:23 [INFO] [stdout] | [INFO] [stdout] 588 | fn jmp(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:637:23 [INFO] [stdout] | [INFO] [stdout] 637 | fn nor(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:641:23 [INFO] [stdout] | [INFO] [stdout] 641 | fn ret(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:645:24 [INFO] [stdout] | [INFO] [stdout] 645 | fn sbio(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:649:23 [INFO] [stdout] | [INFO] [stdout] 649 | fn sbr(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:653:22 [INFO] [stdout] | [INFO] [stdout] 653 | fn st(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:657:23 [INFO] [stdout] | [INFO] [stdout] 657 | fn std(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:661:23 [INFO] [stdout] | [INFO] [stdout] 661 | fn stp(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:695:23 [INFO] [stdout] | [INFO] [stdout] 695 | fn nop(&mut self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:701:23 [INFO] [stdout] | [INFO] [stdout] 701 | fn cli(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:706:23 [INFO] [stdout] | [INFO] [stdout] 706 | fn sei(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/emu/cpu/cu.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn assign_work(&mut self, code: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/cmp.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | let mut cg = ComputeGroup::new(CPU_CORES,Rc::clone(&cache),t,(id, n as u16)); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/emu/code.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | let opcode = self.code[ip]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `symbol` [INFO] [stdout] --> src/emu/code.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | for symbol in self.symbols() { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_symbol` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf` [INFO] [stdout] --> src/emu/builder.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | fn to_byte_code(&self, mut buf: &mut dyn Write) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_buf` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/builder.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | fn to_byte_code(&self, mut buf: &mut dyn Write) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/asm/mod.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn assemble_to_file(code: &str) -> OsString { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GPIO_REG_MAX` is never used [INFO] [stdout] --> src/emu/cpu/register.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const GPIO_REG_MAX: usize = 16; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `iter` and `next_invalid` are never read [INFO] [stdout] --> src/emu/cpu/isa.rs:941:52 [INFO] [stdout] | [INFO] [stdout] 941 | pub struct DecodedIterator> { iter: T, next_invalid: bool } [INFO] [stdout] | --------------- fields in this struct ^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `pid` is never used [INFO] [stdout] --> src/emu/cpu/pe.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | static mut pid: u16 = 1; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `pc`, `mp`, `bp`, and `sreg` are never used [INFO] [stdout] --> src/emu/cpu/pe.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 60 | impl ProcessingElement { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 240 | fn pc(&self) -> addr_t { self.registers[Register::PC] } [INFO] [stdout] | ^^ [INFO] [stdout] 241 | #[inline(always)] [INFO] [stdout] 242 | fn mp(&self) -> addr_t { self.registers[Register::MP] } [INFO] [stdout] | ^^ [INFO] [stdout] 243 | #[inline(always)] [INFO] [stdout] 244 | fn bp(&self) -> addr_t { self.registers[Register::BP] } [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 248 | fn sreg(&mut self) -> &mut register_t { &mut self.registers[Register::SREG] } [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_string` is never used [INFO] [stdout] --> src/emu/code.rs:244:4 [INFO] [stdout] | [INFO] [stdout] 244 | fn read_string(mut buf: &mut dyn Read) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push_data` is never used [INFO] [stdout] --> src/emu/builder.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Builder { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | fn push_data(&mut self, data: addr_t) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `device_count` should have an upper case name [INFO] [stdout] --> src/emu/cpu/mod.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | static mut device_count: u16 = 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `DEVICE_COUNT` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `pid` should have an upper case name [INFO] [stdout] --> src/emu/cpu/pe.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | static mut pid: u16 = 1; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `PID` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `pid` should have an upper case name [INFO] [stdout] --> src/emu/cpu/pe.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | static mut pid: u16 = 0; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `PID` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `K` should have a snake case name [INFO] [stdout] --> src/emu/cpu/pe.rs:353:19 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `InstructionTable`, `InstructionType`, and `types::Value` [INFO] [stdout] --> src/bin/bdvm.rs:5:103 [INFO] [stdout] | [INFO] [stdout] 5 | ..., emu::cpu::{Register, isa::{Instruction, InstructionTable, InstructionType}}, types::Value}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.50s [INFO] running `Command { std: "docker" "inspect" "96ddeaa8591f530479f320eb5c2647068215d89106ce3a1250241175ec1ae332", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96ddeaa8591f530479f320eb5c2647068215d89106ce3a1250241175ec1ae332", kill_on_drop: false }` [INFO] [stdout] 96ddeaa8591f530479f320eb5c2647068215d89106ce3a1250241175ec1ae332 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3520334141b05f90327827f352e00ca131195cfd94df1bb6cf0c1838090c74e6 [INFO] running `Command { std: "docker" "start" "-a" "3520334141b05f90327827f352e00ca131195cfd94df1bb6cf0c1838090c74e6", kill_on_drop: false }` [INFO] [stdout] warning: unused import: `Deref` [INFO] [stdout] --> src/emu/cpu/register.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::{Index, IndexMut, Deref}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToPrimitive` [INFO] [stdout] --> src/emu/cpu/register.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | use num_traits::{FromPrimitive, ToPrimitive}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `SREG_MASK` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum SREG_MASK { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `SregMask` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PE_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `PeId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CU_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `CuId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CG_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `CgId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DEVICE_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:26 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `DeviceId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FromPrimitive` and `ToPrimitive` [INFO] [stdout] --> src/emu/cpu/isa.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | use num_traits::{FromPrimitive, ToPrimitive}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `types` [INFO] [stdout] --> src/emu/cpu/isa.rs:121:62 [INFO] [stdout] | [INFO] [stdout] 121 | use crate::{emu::{Register, isa::{valid_u16, valid_u8}}, types}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `code` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/isa.rs:128:14 [INFO] [stdout] | [INFO] [stdout] 128 | pub enum code { [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/emu/cpu/isa.rs:367:39 [INFO] [stdout] | [INFO] [stdout] 367 | use std::{collections::HashMap, fmt::{Error, Display}, str::FromStr}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex::internal::Inst` [INFO] [stdout] --> src/emu/cpu/pe.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use regex::internal::Inst; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FLASH_MAX` [INFO] [stdout] --> src/emu/cpu/pe.rs:14:60 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::emu::{INSTRUCTIONS_MAX, SRAM_MAX, L2_CACHE_MAX, FLASH_MAX}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MASK_EXT`, `MASK_OP`, `MASK_RD`, `MASK_RS`, and `MASK_XD` [INFO] [stdout] --> src/emu/cpu/pe.rs:20:52 [INFO] [stdout] | [INFO] [stdout] 20 | use super::isa::{ISA, Instruction, Instruction::*, MASK_OP, MASK_RD, MASK_RS, MASK_EXT, MASK_XD, op, }; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ ^^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `addr_t` [INFO] [stdout] --> src/emu/code.rs:12:83 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::types::{from_byte_code::FromByteCode,to_byte_code::ToByteCode, code_t, addr_t, table::Table}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/isa.rs:177:38 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn to_instruction(&self, args: &[u16]) -> Instruction { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/emu/cpu/isa.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | _ => Instruction::UnknownOp(args[0].parse::().unwrap()), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/emu/cpu/isa.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 184 | code::ADD => Instruction::ADD(Register::from(args[1]), Register::from(args[2])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 185 | code::ADDI => Instruction::ADDI(Register::from(args[1]), valid_u16(args[2])), [INFO] [stdout] | ---------- matches some of the same values [INFO] [stdout] 186 | code::AND => Instruction::AND(Register::from(args[1]), Register::from(args[2])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 187 | code::ASR => Instruction::ASR(Register::from(args[1])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 240 | _ => Instruction::UnknownOp(args[0].parse::().unwrap()), [INFO] [stdout] | ^ ...and 51 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/isa.rs:594:17 [INFO] [stdout] | [INFO] [stdout] 594 | CPI(rd, i) => todo!(), [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/emu/cpu/isa.rs:594:21 [INFO] [stdout] | [INFO] [stdout] 594 | CPI(rd, i) => todo!(), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/emu/cpu/isa.rs:829:13 [INFO] [stdout] | [INFO] [stdout] 829 | _ => format!("??") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/emu/cpu/isa.rs:829:13 [INFO] [stdout] | [INFO] [stdout] 773 | Instruction::ADD(rd,rs) => format!("ADD {:?}, {:?}",rd,rs), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 774 | Instruction::ADDI(rd,imm) => format!("ADDI {:?}, {imm}",rd), [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] 775 | Instruction::AND(rd,rs) => format!("AND {:?}, {:?}",rd,rs), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 776 | Instruction::ASR(rd) => format!("ASR {:?}", rd), [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 829 | _ => format!("??") [INFO] [stdout] | ^ ...and 52 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/isa.rs:919:30 [INFO] [stdout] | [INFO] [stdout] 919 | pub fn insert(&mut self, instr: Instruction) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/isa.rs:929:17 [INFO] [stdout] | [INFO] [stdout] 929 | let instr = &self.0[key]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/isa.rs:927:13 [INFO] [stdout] | [INFO] [stdout] 927 | let mut result = vec![]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `instr` is never read [INFO] [stdout] --> src/emu/cpu/pe.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let mut instr = Instruction::UnknownOp(code); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/pe.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | let mut code = &mut builder.instructions.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/pe.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | let mut data = &mut builder.data.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/pe.rs:285:22 [INFO] [stdout] | [INFO] [stdout] 285 | fn encode(&self, instr: Instruction) -> code_t { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/emu/cpu/pe.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let opcode = self.get_opcode(instr); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:326:18 [INFO] [stdout] | [INFO] [stdout] 326 | BREQ(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:327:18 [INFO] [stdout] | [INFO] [stdout] 327 | BRGE(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 329 | BRLO(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:330:18 [INFO] [stdout] | [INFO] [stdout] 330 | BRLT(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:331:18 [INFO] [stdout] | [INFO] [stdout] 331 | BRNE(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:332:18 [INFO] [stdout] | [INFO] [stdout] 332 | BRSH(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/emu/cpu/pe.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | CBIO(addr,bit) => { todo!() }, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bit` [INFO] [stdout] --> src/emu/cpu/pe.rs:345:23 [INFO] [stdout] | [INFO] [stdout] 345 | CBIO(addr,bit) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | CBR(r,v) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/emu/cpu/pe.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 346 | CBR(r,v) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 347 | CLR(r) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:353:17 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `K` [INFO] [stdout] --> src/emu/cpu/pe.rs:353:19 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_K` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 354 | CPSE(rd,rs) => { todo!() }, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rs` [INFO] [stdout] --> src/emu/cpu/pe.rs:354:21 [INFO] [stdout] | [INFO] [stdout] 354 | CPSE(rd,rs) => { todo!() }, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:377:16 [INFO] [stdout] | [INFO] [stdout] 377 | IN(rd, imm) => { todo!()}, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:377:20 [INFO] [stdout] | [INFO] [stdout] 377 | IN(rd, imm) => { todo!()}, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:466:19 [INFO] [stdout] | [INFO] [stdout] 466 | RCALL(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:471:18 [INFO] [stdout] | [INFO] [stdout] 471 | RJMP(imm) => { todo!(); }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/emu/cpu/pe.rs:472:18 [INFO] [stdout] | [INFO] [stdout] 472 | SBIO(addr, bit) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bit` [INFO] [stdout] --> src/emu/cpu/pe.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 472 | SBIO(addr, bit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:480:17 [INFO] [stdout] | [INFO] [stdout] 480 | SET(rd) => {todo!();}, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:515:20 [INFO] [stdout] | [INFO] [stdout] 515 | fn halt(&self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:518:19 [INFO] [stdout] | [INFO] [stdout] 518 | fn brk(&self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:529:13 [INFO] [stdout] | [INFO] [stdout] 529 | let rd = Register::from_u16(args[0]).unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:547:24 [INFO] [stdout] | [INFO] [stdout] 547 | fn call(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:551:24 [INFO] [stdout] | [INFO] [stdout] 551 | fn cbio(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:561:13 [INFO] [stdout] | [INFO] [stdout] 561 | let rd = Register::from_u16(args[0]).unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:588:23 [INFO] [stdout] | [INFO] [stdout] 588 | fn jmp(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:637:23 [INFO] [stdout] | [INFO] [stdout] 637 | fn nor(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:641:23 [INFO] [stdout] | [INFO] [stdout] 641 | fn ret(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:645:24 [INFO] [stdout] | [INFO] [stdout] 645 | fn sbio(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:649:23 [INFO] [stdout] | [INFO] [stdout] 649 | fn sbr(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:653:22 [INFO] [stdout] | [INFO] [stdout] 653 | fn st(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:657:23 [INFO] [stdout] | [INFO] [stdout] 657 | fn std(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:661:23 [INFO] [stdout] | [INFO] [stdout] 661 | fn stp(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:695:23 [INFO] [stdout] | [INFO] [stdout] 695 | fn nop(&mut self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:701:23 [INFO] [stdout] | [INFO] [stdout] 701 | fn cli(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:706:23 [INFO] [stdout] | [INFO] [stdout] 706 | fn sei(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/emu/cpu/cu.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn assign_work(&mut self, code: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/cmp.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | let mut cg = ComputeGroup::new(CPU_CORES,Rc::clone(&cache),t,(id, n as u16)); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/emu/code.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | let opcode = self.code[ip]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `symbol` [INFO] [stdout] --> src/emu/code.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | for symbol in self.symbols() { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_symbol` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf` [INFO] [stdout] --> src/emu/builder.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | fn to_byte_code(&self, mut buf: &mut dyn Write) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_buf` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/builder.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | fn to_byte_code(&self, mut buf: &mut dyn Write) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/asm/mod.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn assemble_to_file(code: &str) -> OsString { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GPIO_REG_MAX` is never used [INFO] [stdout] --> src/emu/cpu/register.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const GPIO_REG_MAX: usize = 16; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `iter` and `next_invalid` are never read [INFO] [stdout] --> src/emu/cpu/isa.rs:941:52 [INFO] [stdout] | [INFO] [stdout] 941 | pub struct DecodedIterator> { iter: T, next_invalid: bool } [INFO] [stdout] | --------------- fields in this struct ^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `pid` is never used [INFO] [stdout] --> src/emu/cpu/pe.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | static mut pid: u16 = 1; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `pc`, `mp`, `bp`, and `sreg` are never used [INFO] [stdout] --> src/emu/cpu/pe.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 60 | impl ProcessingElement { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 240 | fn pc(&self) -> addr_t { self.registers[Register::PC] } [INFO] [stdout] | ^^ [INFO] [stdout] 241 | #[inline(always)] [INFO] [stdout] 242 | fn mp(&self) -> addr_t { self.registers[Register::MP] } [INFO] [stdout] | ^^ [INFO] [stdout] 243 | #[inline(always)] [INFO] [stdout] 244 | fn bp(&self) -> addr_t { self.registers[Register::BP] } [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 248 | fn sreg(&mut self) -> &mut register_t { &mut self.registers[Register::SREG] } [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_string` is never used [INFO] [stdout] --> src/emu/code.rs:244:4 [INFO] [stdout] | [INFO] [stdout] 244 | fn read_string(mut buf: &mut dyn Read) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push_data` is never used [INFO] [stdout] --> src/emu/builder.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Builder { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | fn push_data(&mut self, data: addr_t) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `device_count` should have an upper case name [INFO] [stdout] --> src/emu/cpu/mod.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | static mut device_count: u16 = 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `DEVICE_COUNT` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `pid` should have an upper case name [INFO] [stdout] --> src/emu/cpu/pe.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | static mut pid: u16 = 1; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `PID` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling battledroids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: static variable `pid` should have an upper case name [INFO] [stdout] --> src/emu/cpu/pe.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | static mut pid: u16 = 0; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `PID` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `K` should have a snake case name [INFO] [stdout] --> src/emu/cpu/pe.rs:353:19 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `InstructionTable`, `InstructionType`, and `types::Value` [INFO] [stdout] --> src/bin/bdvm.rs:5:103 [INFO] [stdout] | [INFO] [stdout] 5 | ..., emu::cpu::{Register, isa::{Instruction, InstructionTable, InstructionType}}, types::Value}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deref` [INFO] [stdout] --> src/emu/cpu/register.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::{Index, IndexMut, Deref}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToPrimitive` [INFO] [stdout] --> src/emu/cpu/register.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | use num_traits::{FromPrimitive, ToPrimitive}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `SREG_MASK` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub enum SREG_MASK { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `SregMask` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PE_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `PeId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CU_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `CuId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CG_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `CgId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DEVICE_ID` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/register.rs:68:26 [INFO] [stdout] | [INFO] [stdout] 68 | PE_ID, CU_ID, CG_ID, DEVICE_ID, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `DeviceId` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FromPrimitive` and `ToPrimitive` [INFO] [stdout] --> src/emu/cpu/isa.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | use num_traits::{FromPrimitive, ToPrimitive}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `types` [INFO] [stdout] --> src/emu/cpu/isa.rs:121:62 [INFO] [stdout] | [INFO] [stdout] 121 | use crate::{emu::{Register, isa::{valid_u16, valid_u8}}, types}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `code` should have an upper camel case name [INFO] [stdout] --> src/emu/cpu/isa.rs:128:14 [INFO] [stdout] | [INFO] [stdout] 128 | pub enum code { [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/emu/cpu/isa.rs:367:39 [INFO] [stdout] | [INFO] [stdout] 367 | use std::{collections::HashMap, fmt::{Error, Display}, str::FromStr}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex::internal::Inst` [INFO] [stdout] --> src/emu/cpu/pe.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use regex::internal::Inst; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FLASH_MAX` [INFO] [stdout] --> src/emu/cpu/pe.rs:14:60 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::emu::{INSTRUCTIONS_MAX, SRAM_MAX, L2_CACHE_MAX, FLASH_MAX}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MASK_EXT`, `MASK_OP`, `MASK_RD`, `MASK_RS`, and `MASK_XD` [INFO] [stdout] --> src/emu/cpu/pe.rs:20:52 [INFO] [stdout] | [INFO] [stdout] 20 | use super::isa::{ISA, Instruction, Instruction::*, MASK_OP, MASK_RD, MASK_RS, MASK_EXT, MASK_XD, op, }; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ ^^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `addr_t` [INFO] [stdout] --> src/emu/code.rs:12:83 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::types::{from_byte_code::FromByteCode,to_byte_code::ToByteCode, code_t, addr_t, table::Table}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead` and `BufReader` [INFO] [stdout] --> src/emu/builder.rs:140:26 [INFO] [stdout] | [INFO] [stdout] 140 | use std::io::{Write, BufReader, BufRead, Error}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/isa.rs:177:38 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn to_instruction(&self, args: &[u16]) -> Instruction { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/emu/cpu/isa.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | _ => Instruction::UnknownOp(args[0].parse::().unwrap()), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/emu/cpu/isa.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 184 | code::ADD => Instruction::ADD(Register::from(args[1]), Register::from(args[2])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 185 | code::ADDI => Instruction::ADDI(Register::from(args[1]), valid_u16(args[2])), [INFO] [stdout] | ---------- matches some of the same values [INFO] [stdout] 186 | code::AND => Instruction::AND(Register::from(args[1]), Register::from(args[2])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 187 | code::ASR => Instruction::ASR(Register::from(args[1])), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 240 | _ => Instruction::UnknownOp(args[0].parse::().unwrap()), [INFO] [stdout] | ^ ...and 51 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/isa.rs:594:17 [INFO] [stdout] | [INFO] [stdout] 594 | CPI(rd, i) => todo!(), [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/emu/cpu/isa.rs:594:21 [INFO] [stdout] | [INFO] [stdout] 594 | CPI(rd, i) => todo!(), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/emu/cpu/isa.rs:829:13 [INFO] [stdout] | [INFO] [stdout] 829 | _ => format!("??") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/emu/cpu/isa.rs:829:13 [INFO] [stdout] | [INFO] [stdout] 773 | Instruction::ADD(rd,rs) => format!("ADD {:?}, {:?}",rd,rs), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 774 | Instruction::ADDI(rd,imm) => format!("ADDI {:?}, {imm}",rd), [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] 775 | Instruction::AND(rd,rs) => format!("AND {:?}, {:?}",rd,rs), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 776 | Instruction::ASR(rd) => format!("ASR {:?}", rd), [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 829 | _ => format!("??") [INFO] [stdout] | ^ ...and 52 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/isa.rs:919:30 [INFO] [stdout] | [INFO] [stdout] 919 | pub fn insert(&mut self, instr: Instruction) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/isa.rs:929:17 [INFO] [stdout] | [INFO] [stdout] 929 | let instr = &self.0[key]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/isa.rs:927:13 [INFO] [stdout] | [INFO] [stdout] 927 | let mut result = vec![]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `instr` is never read [INFO] [stdout] --> src/emu/cpu/pe.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let mut instr = Instruction::UnknownOp(code); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/pe.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | let mut code = &mut builder.instructions.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/pe.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | let mut data = &mut builder.data.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instr` [INFO] [stdout] --> src/emu/cpu/pe.rs:285:22 [INFO] [stdout] | [INFO] [stdout] 285 | fn encode(&self, instr: Instruction) -> code_t { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_instr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/emu/cpu/pe.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let opcode = self.get_opcode(instr); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:326:18 [INFO] [stdout] | [INFO] [stdout] 326 | BREQ(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:327:18 [INFO] [stdout] | [INFO] [stdout] 327 | BRGE(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 329 | BRLO(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:330:18 [INFO] [stdout] | [INFO] [stdout] 330 | BRLT(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:331:18 [INFO] [stdout] | [INFO] [stdout] 331 | BRNE(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:332:18 [INFO] [stdout] | [INFO] [stdout] 332 | BRSH(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/emu/cpu/pe.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | CBIO(addr,bit) => { todo!() }, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bit` [INFO] [stdout] --> src/emu/cpu/pe.rs:345:23 [INFO] [stdout] | [INFO] [stdout] 345 | CBIO(addr,bit) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | CBR(r,v) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/emu/cpu/pe.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 346 | CBR(r,v) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 347 | CLR(r) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/emu/cpu/pe.rs:353:17 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `K` [INFO] [stdout] --> src/emu/cpu/pe.rs:353:19 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_K` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 354 | CPSE(rd,rs) => { todo!() }, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rs` [INFO] [stdout] --> src/emu/cpu/pe.rs:354:21 [INFO] [stdout] | [INFO] [stdout] 354 | CPSE(rd,rs) => { todo!() }, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:377:16 [INFO] [stdout] | [INFO] [stdout] 377 | IN(rd, imm) => { todo!()}, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:377:20 [INFO] [stdout] | [INFO] [stdout] 377 | IN(rd, imm) => { todo!()}, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:466:19 [INFO] [stdout] | [INFO] [stdout] 466 | RCALL(imm) => { todo!() }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `imm` [INFO] [stdout] --> src/emu/cpu/pe.rs:471:18 [INFO] [stdout] | [INFO] [stdout] 471 | RJMP(imm) => { todo!(); }, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_imm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/emu/cpu/pe.rs:472:18 [INFO] [stdout] | [INFO] [stdout] 472 | SBIO(addr, bit) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bit` [INFO] [stdout] --> src/emu/cpu/pe.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 472 | SBIO(addr, bit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:480:17 [INFO] [stdout] | [INFO] [stdout] 480 | SET(rd) => {todo!();}, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:515:20 [INFO] [stdout] | [INFO] [stdout] 515 | fn halt(&self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:518:19 [INFO] [stdout] | [INFO] [stdout] 518 | fn brk(&self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:529:13 [INFO] [stdout] | [INFO] [stdout] 529 | let rd = Register::from_u16(args[0]).unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:547:24 [INFO] [stdout] | [INFO] [stdout] 547 | fn call(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:551:24 [INFO] [stdout] | [INFO] [stdout] 551 | fn cbio(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rd` [INFO] [stdout] --> src/emu/cpu/pe.rs:561:13 [INFO] [stdout] | [INFO] [stdout] 561 | let rd = Register::from_u16(args[0]).unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:588:23 [INFO] [stdout] | [INFO] [stdout] 588 | fn jmp(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:637:23 [INFO] [stdout] | [INFO] [stdout] 637 | fn nor(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:641:23 [INFO] [stdout] | [INFO] [stdout] 641 | fn ret(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:645:24 [INFO] [stdout] | [INFO] [stdout] 645 | fn sbio(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:649:23 [INFO] [stdout] | [INFO] [stdout] 649 | fn sbr(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:653:22 [INFO] [stdout] | [INFO] [stdout] 653 | fn st(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:657:23 [INFO] [stdout] | [INFO] [stdout] 657 | fn std(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:661:23 [INFO] [stdout] | [INFO] [stdout] 661 | fn stp(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:695:23 [INFO] [stdout] | [INFO] [stdout] 695 | fn nop(&mut self, args: &[u16]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:701:23 [INFO] [stdout] | [INFO] [stdout] 701 | fn cli(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/emu/cpu/pe.rs:706:23 [INFO] [stdout] | [INFO] [stdout] 706 | fn sei(&mut self, args: &[code_t]) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/emu/cpu/cu.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn assign_work(&mut self, code: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/cpu/cmp.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | let mut cg = ComputeGroup::new(CPU_CORES,Rc::clone(&cache),t,(id, n as u16)); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/emu/code.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | let opcode = self.code[ip]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `symbol` [INFO] [stdout] --> src/emu/code.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | for symbol in self.symbols() { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_symbol` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf` [INFO] [stdout] --> src/emu/builder.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | fn to_byte_code(&self, mut buf: &mut dyn Write) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_buf` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/emu/builder.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | fn to_byte_code(&self, mut buf: &mut dyn Write) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/asm/mod.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn assemble_to_file(code: &str) -> OsString { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GPIO_REG_MAX` is never used [INFO] [stdout] --> src/emu/cpu/register.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const GPIO_REG_MAX: usize = 16; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `iter` and `next_invalid` are never read [INFO] [stdout] --> src/emu/cpu/isa.rs:941:52 [INFO] [stdout] | [INFO] [stdout] 941 | pub struct DecodedIterator> { iter: T, next_invalid: bool } [INFO] [stdout] | --------------- fields in this struct ^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `pid` is never used [INFO] [stdout] --> src/emu/cpu/pe.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | static mut pid: u16 = 1; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `pc`, `mp`, `bp`, and `sreg` are never used [INFO] [stdout] --> src/emu/cpu/pe.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 60 | impl ProcessingElement { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 240 | fn pc(&self) -> addr_t { self.registers[Register::PC] } [INFO] [stdout] | ^^ [INFO] [stdout] 241 | #[inline(always)] [INFO] [stdout] 242 | fn mp(&self) -> addr_t { self.registers[Register::MP] } [INFO] [stdout] | ^^ [INFO] [stdout] 243 | #[inline(always)] [INFO] [stdout] 244 | fn bp(&self) -> addr_t { self.registers[Register::BP] } [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 248 | fn sreg(&mut self) -> &mut register_t { &mut self.registers[Register::SREG] } [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_string` is never used [INFO] [stdout] --> src/emu/code.rs:244:4 [INFO] [stdout] | [INFO] [stdout] 244 | fn read_string(mut buf: &mut dyn Read) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push_data` is never used [INFO] [stdout] --> src/emu/builder.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Builder { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | fn push_data(&mut self, data: addr_t) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `device_count` should have an upper case name [INFO] [stdout] --> src/emu/cpu/mod.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | static mut device_count: u16 = 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `DEVICE_COUNT` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `pid` should have an upper case name [INFO] [stdout] --> src/emu/cpu/pe.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | static mut pid: u16 = 1; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `PID` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `pid` should have an upper case name [INFO] [stdout] --> src/emu/cpu/pe.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | static mut pid: u16 = 0; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `PID` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `K` should have a snake case name [INFO] [stdout] --> src/emu/cpu/pe.rs:353:19 [INFO] [stdout] | [INFO] [stdout] 353 | CPI(r,K) => { todo!() }, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/emu/builder.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | write!(fl, "LDI R0, 100\nLDI R1, 23\nADD R0, R1"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 1.96s [INFO] running `Command { std: "docker" "inspect" "3520334141b05f90327827f352e00ca131195cfd94df1bb6cf0c1838090c74e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3520334141b05f90327827f352e00ca131195cfd94df1bb6cf0c1838090c74e6", kill_on_drop: false }` [INFO] [stdout] 3520334141b05f90327827f352e00ca131195cfd94df1bb6cf0c1838090c74e6