[INFO] cloning repository https://github.com/dragonblade316/rust_chip8_emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dragonblade316/rust_chip8_emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdragonblade316%2Frust_chip8_emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdragonblade316%2Frust_chip8_emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6edbc175be7ae453d554e177d43d4a9c073777af [INFO] building dragonblade316/rust_chip8_emulator against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdragonblade316%2Frust_chip8_emulator" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dragonblade316/rust_chip8_emulator on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dragonblade316/rust_chip8_emulator [INFO] finished tweaking git repo https://github.com/dragonblade316/rust_chip8_emulator [INFO] tweaked toml for git repo https://github.com/dragonblade316/rust_chip8_emulator written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/dragonblade316/rust_chip8_emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ccc84949eac3ec5d74ac310513b5341bf2315b31e26f4d034b76e85fd3aa7ab [INFO] running `Command { std: "docker" "start" "-a" "4ccc84949eac3ec5d74ac310513b5341bf2315b31e26f4d034b76e85fd3aa7ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ccc84949eac3ec5d74ac310513b5341bf2315b31e26f4d034b76e85fd3aa7ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ccc84949eac3ec5d74ac310513b5341bf2315b31e26f4d034b76e85fd3aa7ab", kill_on_drop: false }` [INFO] [stdout] 4ccc84949eac3ec5d74ac310513b5341bf2315b31e26f4d034b76e85fd3aa7ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65ea717c8f991f7497de598001ccfd50c4f07cae71423ea32ff9e7cbbf0f115f [INFO] running `Command { std: "docker" "start" "-a" "65ea717c8f991f7497de598001ccfd50c4f07cae71423ea32ff9e7cbbf0f115f", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Compiling rust_chip8_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/processor.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:423:12 [INFO] [stdout] | [INFO] [stdout] 423 | if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 == (opcode) & (0x00FF)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 423 - if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 == (opcode) & (0x00FF)) { [INFO] [stdout] 423 + if self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 == (opcode) & (0x00FF) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 431 | if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 != (opcode) & (0x00FF)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 431 - if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 != (opcode) & (0x00FF)) { [INFO] [stdout] 431 + if self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 != (opcode) & (0x00FF) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:439:12 [INFO] [stdout] | [INFO] [stdout] 439 | if (self.registers[(opcode & 0x0F00 >> 8) as usize] == self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 439 - if (self.registers[(opcode & 0x0F00 >> 8) as usize] == self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 439 + if self.registers[(opcode & 0x0F00 >> 8) as usize] == self.registers[((opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/processor.rs:469:59 [INFO] [stdout] | [INFO] [stdout] 469 | self.registers[(opcode & 0x0F00 >> 8) as usize] = (self.registers [INFO] [stdout] | ^ [INFO] [stdout] 470 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 471 | | self.registers[((opcode & 0x00F0) >> 4) as usize]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 469 ~ self.registers[(opcode & 0x0F00 >> 8) as usize] = self.registers [INFO] [stdout] 470 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 471 ~ | self.registers[((opcode & 0x00F0) >> 4) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/processor.rs:476:59 [INFO] [stdout] | [INFO] [stdout] 476 | self.registers[(opcode & 0x0F00 >> 8) as usize] = (self.registers [INFO] [stdout] | ^ [INFO] [stdout] 477 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 478 | & self.registers[((opcode & 0x00F0) >> 4) as usize]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 476 ~ self.registers[(opcode & 0x0F00 >> 8) as usize] = self.registers [INFO] [stdout] 477 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 478 ~ & self.registers[((opcode & 0x00F0) >> 4) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/processor.rs:483:59 [INFO] [stdout] | [INFO] [stdout] 483 | self.registers[(opcode & 0x0F00 >> 8) as usize] = (self.registers [INFO] [stdout] | ^ [INFO] [stdout] 484 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 485 | ^ self.registers[((opcode & 0x00F0) >> 4) as usize]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 483 ~ self.registers[(opcode & 0x0F00 >> 8) as usize] = self.registers [INFO] [stdout] 484 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 485 ~ ^ self.registers[((opcode & 0x00F0) >> 4) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:492:12 [INFO] [stdout] | [INFO] [stdout] 492 | if (self.registers[((opcode & 0x00F0) >> 4) as usize] > (0xFF - self.registers[((opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 492 - if (self.registers[((opcode & 0x00F0) >> 4) as usize] > (0xFF - self.registers[((opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] 492 + if self.registers[((opcode & 0x00F0) >> 4) as usize] > (0xFF - self.registers[((opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:503:12 [INFO] [stdout] | [INFO] [stdout] 503 | if (self.registers[((opcode & 0x00F0) >> 4) as usize] > self.registers[((opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 503 - if (self.registers[((opcode & 0x00F0) >> 4) as usize] > self.registers[((opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] 503 + if self.registers[((opcode & 0x00F0) >> 4) as usize] > self.registers[((opcode & 0x0F00) >> 8) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:523:12 [INFO] [stdout] | [INFO] [stdout] 523 | if (self.registers[((opcode & 0x0F00) >> 8) as usize] > self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 523 - if (self.registers[((opcode & 0x0F00) >> 8) as usize] > self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 523 + if self.registers[((opcode & 0x0F00) >> 8) as usize] > self.registers[((opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 542 | if (self.registers[(opcode & 0x0F00 >> 8) as usize] != self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if (self.registers[(opcode & 0x0F00 >> 8) as usize] != self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 542 + if self.registers[(opcode & 0x0F00 >> 8) as usize] != self.registers[((opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 577 | if (x > 64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 577 - if (x > 64) { [INFO] [stdout] 577 + if x > 64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 580 | if (y > 32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 580 - if (y > 32) { [INFO] [stdout] 580 + if y > 32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | while (true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - while (true) { [INFO] [stdout] 25 + while true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | while (true) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/processor.rs:396:27 [INFO] [stdout] | [INFO] [stdout] 396 | fn op_00e0(&mut self, opcode: &u16) -> PcState { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/processor.rs:401:27 [INFO] [stdout] | [INFO] [stdout] 401 | fn op_00ee(&mut self, opcode: &u16) -> PcState { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sprite_height_processed` [INFO] [stdout] --> src/processor.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 584 | let sprite_height_processed = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sprite_height_processed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/processor.rs:598:17 [INFO] [stdout] | [INFO] [stdout] 598 | for j in 0..7 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sdl_context` is never read [INFO] [stdout] --> src/processor.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 155 | struct IO { [INFO] [stdout] | -- field in this struct [INFO] [stdout] 156 | sdl_context: Sdl, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/processor.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 271 | pub struct Processor { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 280 | opcode: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `offsetX` should have a snake case name [INFO] [stdout] --> src/processor.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | let mut offsetX = 0; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `offset_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.38s [INFO] running `Command { std: "docker" "inspect" "65ea717c8f991f7497de598001ccfd50c4f07cae71423ea32ff9e7cbbf0f115f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65ea717c8f991f7497de598001ccfd50c4f07cae71423ea32ff9e7cbbf0f115f", kill_on_drop: false }` [INFO] [stdout] 65ea717c8f991f7497de598001ccfd50c4f07cae71423ea32ff9e7cbbf0f115f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 975c29b847ba67f94a5384a380d3304a3d71e2e80def3ad1228b0b1950d5eba3 [INFO] running `Command { std: "docker" "start" "-a" "975c29b847ba67f94a5384a380d3304a3d71e2e80def3ad1228b0b1950d5eba3", kill_on_drop: false }` [INFO] [stderr] Compiling rust_chip8_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/processor.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:423:12 [INFO] [stdout] | [INFO] [stdout] 423 | if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 == (opcode) & (0x00FF)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 423 - if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 == (opcode) & (0x00FF)) { [INFO] [stdout] 423 + if self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 == (opcode) & (0x00FF) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 431 | if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 != (opcode) & (0x00FF)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 431 - if (self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 != (opcode) & (0x00FF)) { [INFO] [stdout] 431 + if self.registers[((opcode & 0x0F00) >> 8) as usize] as u16 != (opcode) & (0x00FF) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:439:12 [INFO] [stdout] | [INFO] [stdout] 439 | if (self.registers[(opcode & 0x0F00 >> 8) as usize] == self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 439 - if (self.registers[(opcode & 0x0F00 >> 8) as usize] == self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 439 + if self.registers[(opcode & 0x0F00 >> 8) as usize] == self.registers[((opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/processor.rs:469:59 [INFO] [stdout] | [INFO] [stdout] 469 | self.registers[(opcode & 0x0F00 >> 8) as usize] = (self.registers [INFO] [stdout] | ^ [INFO] [stdout] 470 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 471 | | self.registers[((opcode & 0x00F0) >> 4) as usize]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 469 ~ self.registers[(opcode & 0x0F00 >> 8) as usize] = self.registers [INFO] [stdout] 470 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 471 ~ | self.registers[((opcode & 0x00F0) >> 4) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/processor.rs:476:59 [INFO] [stdout] | [INFO] [stdout] 476 | self.registers[(opcode & 0x0F00 >> 8) as usize] = (self.registers [INFO] [stdout] | ^ [INFO] [stdout] 477 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 478 | & self.registers[((opcode & 0x00F0) >> 4) as usize]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 476 ~ self.registers[(opcode & 0x0F00 >> 8) as usize] = self.registers [INFO] [stdout] 477 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 478 ~ & self.registers[((opcode & 0x00F0) >> 4) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/processor.rs:483:59 [INFO] [stdout] | [INFO] [stdout] 483 | self.registers[(opcode & 0x0F00 >> 8) as usize] = (self.registers [INFO] [stdout] | ^ [INFO] [stdout] 484 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 485 | ^ self.registers[((opcode & 0x00F0) >> 4) as usize]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 483 ~ self.registers[(opcode & 0x0F00 >> 8) as usize] = self.registers [INFO] [stdout] 484 | [(opcode & 0x0F00 >> 8) as usize] [INFO] [stdout] 485 ~ ^ self.registers[((opcode & 0x00F0) >> 4) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:492:12 [INFO] [stdout] | [INFO] [stdout] 492 | if (self.registers[((opcode & 0x00F0) >> 4) as usize] > (0xFF - self.registers[((opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 492 - if (self.registers[((opcode & 0x00F0) >> 4) as usize] > (0xFF - self.registers[((opcode & 0x0F00) >> 8) as usize])) [INFO] [stdout] 492 + if self.registers[((opcode & 0x00F0) >> 4) as usize] > (0xFF - self.registers[((opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:503:12 [INFO] [stdout] | [INFO] [stdout] 503 | if (self.registers[((opcode & 0x00F0) >> 4) as usize] > self.registers[((opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 503 - if (self.registers[((opcode & 0x00F0) >> 4) as usize] > self.registers[((opcode & 0x0F00) >> 8) as usize]) [INFO] [stdout] 503 + if self.registers[((opcode & 0x00F0) >> 4) as usize] > self.registers[((opcode & 0x0F00) >> 8) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:523:12 [INFO] [stdout] | [INFO] [stdout] 523 | if (self.registers[((opcode & 0x0F00) >> 8) as usize] > self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 523 - if (self.registers[((opcode & 0x0F00) >> 8) as usize] > self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 523 + if self.registers[((opcode & 0x0F00) >> 8) as usize] > self.registers[((opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 542 | if (self.registers[(opcode & 0x0F00 >> 8) as usize] != self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if (self.registers[(opcode & 0x0F00 >> 8) as usize] != self.registers[((opcode & 0x00F0) >> 4) as usize]) [INFO] [stdout] 542 + if self.registers[(opcode & 0x0F00 >> 8) as usize] != self.registers[((opcode & 0x00F0) >> 4) as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 577 | if (x > 64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 577 - if (x > 64) { [INFO] [stdout] 577 + if x > 64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/processor.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 580 | if (y > 32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 580 - if (y > 32) { [INFO] [stdout] 580 + if y > 32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | while (true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - while (true) { [INFO] [stdout] 25 + while true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | while (true) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/processor.rs:396:27 [INFO] [stdout] | [INFO] [stdout] 396 | fn op_00e0(&mut self, opcode: &u16) -> PcState { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/processor.rs:401:27 [INFO] [stdout] | [INFO] [stdout] 401 | fn op_00ee(&mut self, opcode: &u16) -> PcState { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sprite_height_processed` [INFO] [stdout] --> src/processor.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 584 | let sprite_height_processed = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sprite_height_processed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/processor.rs:598:17 [INFO] [stdout] | [INFO] [stdout] 598 | for j in 0..7 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sdl_context` is never read [INFO] [stdout] --> src/processor.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 155 | struct IO { [INFO] [stdout] | -- field in this struct [INFO] [stdout] 156 | sdl_context: Sdl, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/processor.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 271 | pub struct Processor { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 280 | opcode: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `offsetX` should have a snake case name [INFO] [stdout] --> src/processor.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | let mut offsetX = 0; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `offset_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `Command { std: "docker" "inspect" "975c29b847ba67f94a5384a380d3304a3d71e2e80def3ad1228b0b1950d5eba3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "975c29b847ba67f94a5384a380d3304a3d71e2e80def3ad1228b0b1950d5eba3", kill_on_drop: false }` [INFO] [stdout] 975c29b847ba67f94a5384a380d3304a3d71e2e80def3ad1228b0b1950d5eba3