[INFO] cloning repository https://github.com/dove-lang/dove [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dove-lang/dove" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdove-lang%2Fdove", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdove-lang%2Fdove'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 641ac4899c7b4c31148f6560ec377ccab7146331 [INFO] building dove-lang/dove against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdove-lang%2Fdove" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dove-lang/dove on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dove-lang/dove [INFO] finished tweaking git repo https://github.com/dove-lang/dove [INFO] tweaked toml for git repo https://github.com/dove-lang/dove written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/dove-lang/dove already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded colour v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bba57afae2964a16c628235fe223c4141b6c4a185a5c23a60ed1c5ee52de7963 [INFO] running `Command { std: "docker" "start" "-a" "bba57afae2964a16c628235fe223c4141b6c4a185a5c23a60ed1c5ee52de7963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bba57afae2964a16c628235fe223c4141b6c4a185a5c23a60ed1c5ee52de7963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bba57afae2964a16c628235fe223c4141b6c4a185a5c23a60ed1c5ee52de7963", kill_on_drop: false }` [INFO] [stdout] bba57afae2964a16c628235fe223c4141b6c4a185a5c23a60ed1c5ee52de7963 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a66b8f409bb1867d6d52ba4f988787c49cb767a10882ed2d264d45016508006 [INFO] running `Command { std: "docker" "start" "-a" "7a66b8f409bb1867d6d52ba4f988787c49cb767a10882ed2d264d45016508006", kill_on_drop: false }` [INFO] [stderr] Compiling dove-core v0.1.0 (/opt/rustwide/workdir/dove-core) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/interpreter.rs:434:23 [INFO] [stdout] | [INFO] [stdout] 432 | let expr = self.visit_expr(object)?; [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `expr` calls a custom destructor [INFO] [stdout] | `expr` will be dropped later as of Edition 2024 [INFO] [stdout] 433 | [INFO] [stdout] 434 | match expr.as_object().get_property(&name.lexeme) { [INFO] [stdout] | ----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `expr` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/interpreter.rs:586:23 [INFO] [stdout] | [INFO] [stdout] 583 | let expr = self.visit_expr(object)?; [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `expr` calls a custom destructor [INFO] [stdout] | `expr` will be dropped later as of Edition 2024 [INFO] [stdout] 584 | let value = self.visit_expr(value)?; [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `value` calls a custom destructor [INFO] [stdout] | `value` will be dropped later as of Edition 2024 [INFO] [stdout] 585 | [INFO] [stdout] 586 | match expr.as_object().set_property(&name.lexeme, value.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | }, [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `expr` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `value` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/interpreter.rs:854:28 [INFO] [stdout] | [INFO] [stdout] 853 | while is_truthy(&self.evaluate(condition).unwrap()) { [INFO] [stdout] | --------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 854 | match self.execute(body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 855 | Ok(_) => {}, [INFO] [stdout] 856 | Err(interrupt) => { [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `interrupt` calls a custom destructor [INFO] [stdout] | `interrupt` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 864 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `interrupt` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:62:38 [INFO] [stdout] | [INFO] [stdout] 62 | if let Some(statement) = self.declaration() { [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `statement` calls a custom destructor [INFO] [stdout] | `statement` will be dropped later as of Edition 2024 [INFO] [stdout] 63 | if self.consume_newline().is_ok() { [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `statement` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:227:38 [INFO] [stdout] | [INFO] [stdout] 227 | if let Some(statement) = self.declaration() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | if self.consume_newline().is_err() { [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:386:30 [INFO] [stdout] | [INFO] [stdout] 386 | while let Some(op) = self.match_token(&[TokenType::OR]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `op` calls a custom destructor [INFO] [stdout] | `op` will be dropped later as of Edition 2024 [INFO] [stdout] 387 | let right = self.logic_and()?; [INFO] [stdout] | ----------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 388 | left = Expr::Binary(Box::new(left), op, Box::new(right)); [INFO] [stdout] 389 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `op` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:397:30 [INFO] [stdout] | [INFO] [stdout] 397 | while let Some(op) = self.match_token(&[TokenType::PLUS, TokenType::AND]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `op` calls a custom destructor [INFO] [stdout] | `op` will be dropped later as of Edition 2024 [INFO] [stdout] 398 | let right = self.equality()?; [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 399 | left = Expr::Binary(Box::new(left), op, Box::new(right)); [INFO] [stdout] 400 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `op` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:408:30 [INFO] [stdout] | [INFO] [stdout] 408 | while let Some(op) = self.match_token(&[TokenType::EQUAL_EQUAL, TokenType::BANG_EQUAL]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `op` calls a custom destructor [INFO] [stdout] | `op` will be dropped later as of Edition 2024 [INFO] [stdout] 409 | let right = self.comparison()?; [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 410 | left = Expr::Binary(Box::new(left), op, Box::new(right)); [INFO] [stdout] 411 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `op` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:419:30 [INFO] [stdout] | [INFO] [stdout] 419 | while let Some(op) = self.match_token(&[ [INFO] [stdout] | ________________________--____^ [INFO] [stdout] | | | [INFO] [stdout] | | `op` calls a custom destructor [INFO] [stdout] | | `op` will be dropped later as of Edition 2024 [INFO] [stdout] 420 | | TokenType::LESS, [INFO] [stdout] 421 | | TokenType::GREATER, [INFO] [stdout] 422 | | TokenType::LESS_EQUAL, [INFO] [stdout] 423 | | TokenType::GREATER_EQUAL, [INFO] [stdout] 424 | | ]) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |__________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 425 | let right = self.range()?; [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 426 | left = Expr::Binary(Box::new(left), op, Box::new(right)); [INFO] [stdout] 427 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `op` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:435:30 [INFO] [stdout] | [INFO] [stdout] 433 | let left = self.addition()?; [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `left` calls a custom destructor [INFO] [stdout] | `left` will be dropped later as of Edition 2024 [INFO] [stdout] 434 | [INFO] [stdout] 435 | if let Some(token) = self.match_token(&[TokenType::DOT_DOT, TokenType::DOT_DOT_DOT]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `left` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:446:30 [INFO] [stdout] | [INFO] [stdout] 446 | while let Some(op) = self.match_token(&[TokenType::PLUS, TokenType::MINUS]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `op` calls a custom destructor [INFO] [stdout] | `op` will be dropped later as of Edition 2024 [INFO] [stdout] 447 | let right = self.multiplication()?; [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 448 | left = Expr::Binary(Box::new(left), op, Box::new(right)); [INFO] [stdout] 449 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `op` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:457:30 [INFO] [stdout] | [INFO] [stdout] 457 | while let Some(op) = self.match_token(&[TokenType::STAR, [INFO] [stdout] | ________________________--____^ [INFO] [stdout] | | | [INFO] [stdout] | | `op` calls a custom destructor [INFO] [stdout] | | `op` will be dropped later as of Edition 2024 [INFO] [stdout] 458 | | TokenType::SLASH, TokenType::SLASH_LESS, TokenType::SLASH_GREATER, [INFO] [stdout] 459 | | TokenType::PERCENT]) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_______________________________________________________________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 460 | let right = self.unary()?; [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 461 | left = Expr::Binary(Box::new(left), op, Box::new(right)); [INFO] [stdout] 462 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `op` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/parser.rs:487:32 [INFO] [stdout] | [INFO] [stdout] 487 | if let Ok(paren) = self.consume(TokenType::LEFT_PAREN) { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#13` [INFO] [stdout] | | up until Edition 2021 `#13` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `paren` calls a custom destructor [INFO] [stdout] | `paren` will be dropped later as of Edition 2024 [INFO] [stdout] 488 | let prev = self.set_ignore_newline(true); [INFO] [stdout] 489 | let args = self.arguments()?; [INFO] [stdout] | ---- ----------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | `args` calls a custom destructor [INFO] [stdout] | `args` will be dropped later as of Edition 2024 [INFO] [stdout] 490 | self.set_ignore_newline(prev); [INFO] [stdout] 491 | self.consume(TokenType::RIGHT_PAREN)?; [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | } else if self.consume(TokenType::LEFT_BRACKET).is_ok() { [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 495 | let prev = self.set_ignore_newline(true); [INFO] [stdout] 496 | let index = self.expression()?; [INFO] [stdout] | ----- ------------------ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] | `index` calls a custom destructor [INFO] [stdout] | `index` will be dropped later as of Edition 2024 [INFO] [stdout] 497 | self.set_ignore_newline(prev); [INFO] [stdout] 498 | self.consume(TokenType::RIGHT_BRACKET)?; [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | } else if self.consume(TokenType::DOT).is_ok() { [INFO] [stdout] | ---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | `#8` will be dropped later as of Edition 2024 [INFO] [stdout] 502 | let name = self.consume(TokenType::IDENTIFIER)?; [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#9` [INFO] [stdout] | `#9` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | self.consume(TokenType::DOT)?; [INFO] [stdout] | ----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#10` [INFO] [stdout] | `#10` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#11` [INFO] [stdout] | `#11` will be dropped later as of Edition 2024 [INFO] [stdout] 509 | let name = self.consume(TokenType::IDENTIFIER)?; [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#12` [INFO] [stdout] | `#12` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#13` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `paren` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `args` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `index` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#5` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#6` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#7` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#8` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#9` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#10` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#11` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#12` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> dove-core/src/data_types/dict.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 65 | let key = args[0].clone(); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `key` calls a custom destructor [INFO] [stdout] | `key` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | match dict.borrow_mut().remove(&dict_key) { [INFO] [stdout] | -----------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | }) [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] = note: `key` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dove-core` (lib) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "7a66b8f409bb1867d6d52ba4f988787c49cb767a10882ed2d264d45016508006", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a66b8f409bb1867d6d52ba4f988787c49cb767a10882ed2d264d45016508006", kill_on_drop: false }` [INFO] [stdout] 7a66b8f409bb1867d6d52ba4f988787c49cb767a10882ed2d264d45016508006