[INFO] cloning repository https://github.com/conchino/rust_data_struct [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/conchino/rust_data_struct" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconchino%2Frust_data_struct", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconchino%2Frust_data_struct'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8b0a070f8f3d68f2c145510051365533bee0d134 [INFO] building conchino/rust_data_struct against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconchino%2Frust_data_struct" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/conchino/rust_data_struct on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/conchino/rust_data_struct [INFO] finished tweaking git repo https://github.com/conchino/rust_data_struct [INFO] tweaked toml for git repo https://github.com/conchino/rust_data_struct written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/conchino/rust_data_struct already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa0ba012fd93349b1bc506958d748b0e8f40ba81040667f3f44c29365a47aa92 [INFO] running `Command { std: "docker" "start" "-a" "fa0ba012fd93349b1bc506958d748b0e8f40ba81040667f3f44c29365a47aa92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa0ba012fd93349b1bc506958d748b0e8f40ba81040667f3f44c29365a47aa92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa0ba012fd93349b1bc506958d748b0e8f40ba81040667f3f44c29365a47aa92", kill_on_drop: false }` [INFO] [stdout] fa0ba012fd93349b1bc506958d748b0e8f40ba81040667f3f44c29365a47aa92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80e8cc2aadd578a685e0cbdaa372b50a4bd02b13a43d0af30e7da11f1bdf0612 [INFO] running `Command { std: "docker" "start" "-a" "80e8cc2aadd578a685e0cbdaa372b50a4bd02b13a43d0af30e7da11f1bdf0612", kill_on_drop: false }` [INFO] [stderr] Compiling rust-data-struct v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `option` and `vec` [INFO] [stdout] --> src/signal_list/linkedlist_box.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Display, option, vec}; [INFO] [stdout] | ^^^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `linkedlist_box::*` [INFO] [stdout] --> src/signal_list/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use linkedlist_box::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `linkedlist_Rc::*` [INFO] [stdout] --> src/signal_list/mod.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use linkedlist_Rc::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `linkedlist_box_test::*` [INFO] [stdout] --> src/signal_list/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use linkedlist_box_test::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `linkedlist_Rc_test::*` [INFO] [stdout] --> src/signal_list/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use linkedlist_Rc_test::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut v = vec![1, 2, 3, 4, 5, 6, 7]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let mut v = vec![1, 2, 3, 4, 5, 6, 7]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut v1 = vec![1, 2, 3, 4, 5, 6]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | let mut node = ListNode::vec_to_list(vec![1, 2, 3, 4, 5, 6].as_ref()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/signal_list/linkedlist_Rc.rs:248:45 [INFO] [stdout] | [INFO] [stdout] 248 | while let Some(ref next_node) = Rc::clone(&cur_node).as_ref().borrow_mut().next { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | print!("{} ", cur_node.as_ref().borrow().val); [INFO] [stdout] | -------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 252 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1804:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/core/src/cell.rs:1434:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/signal_list/linkedlist_box.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Node{ [INFO] [stdout] | ------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn get<'a>(&'a mut self, index: usize) -> Option<&'a mut Self> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/signal_list/linkedlist_box.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl ListNode{ [INFO] [stdout] | ----------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub fn get<'a>(&'a mut self, index: usize) -> Option<&'a mut Node> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 104 | pub fn update(&mut self, index: usize, value: T){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | pub fn pop(&mut self){ [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 185 | pub fn add_at_index(mut self, index: usize, elem: T) -> ListNode{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 214 | pub fn delete_at_index(mut self, index: usize) -> ListNode{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 240 | pub fn remove(&mut self, index: usize) -> bool{ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 263 | pub fn insert(&mut self, index: usize, value: T){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `get_next`, and `set_next` are never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl Node{ [INFO] [stdout] | --------------------------------------- associated items in this implementation [INFO] [stdout] 15 | [INFO] [stdout] 16 | pub fn new(value: T) -> Node{ [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn get_next(&mut self) -> Option>>>{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn set_next(&mut self, next: Option>>>) -> () { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | impl ListNode{ [INFO] [stdout] | ------------------------------------------- associated items in this implementation [INFO] [stdout] 50 | [INFO] [stdout] 51 | pub fn new() -> ListNode{ [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn add_head(&mut self, ele: T){ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | pub fn push_back(&mut self, val: T) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn get_last(&self) -> Option>>> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn get(&self, index: isize) -> Option>>> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn index(&self, index: isize) -> Option { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | pub fn pop(&mut self){ [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn pop_head(&mut self){ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 176 | pub fn remove(&mut self, index: usize){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 220 | pub fn insert(&mut self, index: usize, value: T){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 244 | pub fn show(&self){ [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 260 | pub fn vec_to_list(vs: &Vec) -> ListNode { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test2` is never used [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn test2(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test3` is never used [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn test3(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test4` is never used [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn test4(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test5` is never used [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn test5(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test6` is never used [INFO] [stdout] --> src/signal_list/linkedlist_box_test.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn test6(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test1` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn test1(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test2` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn test2(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test3` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn test3(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test4` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn test4(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test5` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn test5(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test6` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn test6(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test7` is never used [INFO] [stdout] --> src/signal_list/linkedlist_Rc_test.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn test7(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `linkedlist_Rc` should have a snake case name [INFO] [stdout] --> src/signal_list/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod linkedlist_Rc; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `linkedlist_rc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `linkedlist_Rc_test` should have a snake case name [INFO] [stdout] --> src/signal_list/mod.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub mod linkedlist_Rc_test; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `linkedlist_rc_test` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/signal_list/linkedlist_box.rs:84:32 [INFO] [stdout] | [INFO] [stdout] 84 | if index > self.len || index < 0 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-data-struct` (bin "rust-data-struct") due to 1 previous error; 28 warnings emitted [INFO] running `Command { std: "docker" "inspect" "80e8cc2aadd578a685e0cbdaa372b50a4bd02b13a43d0af30e7da11f1bdf0612", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80e8cc2aadd578a685e0cbdaa372b50a4bd02b13a43d0af30e7da11f1bdf0612", kill_on_drop: false }` [INFO] [stdout] 80e8cc2aadd578a685e0cbdaa372b50a4bd02b13a43d0af30e7da11f1bdf0612