[INFO] cloning repository https://github.com/arlept/mtklogo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arlept/mtklogo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farlept%2Fmtklogo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farlept%2Fmtklogo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e97f51944be9f6dbafff5b1d619341e1fa97dc4c [INFO] building arlept/mtklogo against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farlept%2Fmtklogo" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/arlept/mtklogo on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/arlept/mtklogo [INFO] finished tweaking git repo https://github.com/arlept/mtklogo [INFO] tweaked toml for git repo https://github.com/arlept/mtklogo written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/arlept/mtklogo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: unused manifest key: package.maintenance [INFO] [stderr] warning: unused manifest key: package.respository [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded inflate v0.4.4 [INFO] [stderr] Downloaded libflate v0.1.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3feefaf759382f587ae8d6586890a57433e54756b7201f77097da994947aa25e [INFO] running `Command { std: "docker" "start" "-a" "3feefaf759382f587ae8d6586890a57433e54756b7201f77097da994947aa25e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3feefaf759382f587ae8d6586890a57433e54756b7201f77097da994947aa25e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3feefaf759382f587ae8d6586890a57433e54756b7201f77097da994947aa25e", kill_on_drop: false }` [INFO] [stdout] 3feefaf759382f587ae8d6586890a57433e54756b7201f77097da994947aa25e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59da238d71250a84da91dbda85898811afc2da2990639e69fdd3e958b2647a9e [INFO] running `Command { std: "docker" "start" "-a" "59da238d71250a84da91dbda85898811afc2da2990639e69fdd3e958b2647a9e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: unused manifest key: package.maintenance [INFO] [stderr] warning: unused manifest key: package.respository [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling libc v0.2.46 [INFO] [stderr] Compiling adler32 v1.0.3 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Compiling byteorder v1.2.7 [INFO] [stderr] Compiling bitflags v1.0.4 [INFO] [stderr] Compiling inflate v0.4.4 [INFO] [stderr] Compiling deflate v0.7.19 [INFO] [stderr] Compiling miniz-sys v0.1.11 [INFO] [stderr] Compiling flate2 v1.0.6 [INFO] [stderr] Compiling png v0.12.0 [INFO] [stderr] Compiling mtklogo v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:89:85 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 89 - pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] 89 + pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:101:71 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result<(Vec)> { [INFO] [stdout] 101 + pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:112:87 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 112 - pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] 112 + pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/mod.rs:20:51 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn load_raw(mut reader: R) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - pub fn load_raw(mut reader: R) -> Result<(Vec)> { [INFO] [stdout] 20 + pub fn load_raw(mut reader: R) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/image.rs:32:63 [INFO] [stdout] | [INFO] [stdout] 32 | &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(rgba.clone())), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/image.rs:46:65 [INFO] [stdout] | [INFO] [stdout] 46 | &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(device.clone())), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `Command { std: "docker" "inspect" "59da238d71250a84da91dbda85898811afc2da2990639e69fdd3e958b2647a9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59da238d71250a84da91dbda85898811afc2da2990639e69fdd3e958b2647a9e", kill_on_drop: false }` [INFO] [stdout] 59da238d71250a84da91dbda85898811afc2da2990639e69fdd3e958b2647a9e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3753590f287a21087a158019a3f3f96a25e231b4d6e80f1cb588f22afc884db2 [INFO] running `Command { std: "docker" "start" "-a" "3753590f287a21087a158019a3f3f96a25e231b4d6e80f1cb588f22afc884db2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: unused manifest key: package.maintenance [INFO] [stderr] warning: unused manifest key: package.respository [INFO] [stderr] Compiling lazy_static v1.2.0 [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:89:85 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 89 - pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] 89 + pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:101:71 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result<(Vec)> { [INFO] [stdout] 101 + pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:112:87 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 112 - pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] 112 + pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/mod.rs:20:51 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn load_raw(mut reader: R) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - pub fn load_raw(mut reader: R) -> Result<(Vec)> { [INFO] [stdout] 20 + pub fn load_raw(mut reader: R) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/image.rs:32:63 [INFO] [stdout] | [INFO] [stdout] 32 | &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(rgba.clone())), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/image.rs:46:65 [INFO] [stdout] | [INFO] [stdout] 46 | &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(device.clone())), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling mtklogo v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/integration_test.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 95 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:89:85 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 89 - pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] 89 + pub fn rgba_to_bgra(mut reader: R, w: u32, h: u32) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:101:71 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result<(Vec)> { [INFO] [stdout] 101 + pub fn u32be_to_u32le(mut reader: R, words: usize) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/image.rs:112:87 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 112 - pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result<(Vec)> { [INFO] [stdout] 112 + pub fn rgba_to_rgb565(mut reader: R, w: u32, h: u32) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/utils/mod.rs:20:51 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn load_raw(mut reader: R) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - pub fn load_raw(mut reader: R) -> Result<(Vec)> { [INFO] [stdout] 20 + pub fn load_raw(mut reader: R) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/image.rs:32:63 [INFO] [stdout] | [INFO] [stdout] 32 | &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(rgba.clone())), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/image.rs:46:65 [INFO] [stdout] | [INFO] [stdout] 46 | &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(device.clone())), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `Command { std: "docker" "inspect" "3753590f287a21087a158019a3f3f96a25e231b4d6e80f1cb588f22afc884db2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3753590f287a21087a158019a3f3f96a25e231b4d6e80f1cb588f22afc884db2", kill_on_drop: false }` [INFO] [stdout] 3753590f287a21087a158019a3f3f96a25e231b4d6e80f1cb588f22afc884db2