[INFO] cloning repository https://github.com/andrechen77/chemhelper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andrechen77/chemhelper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandrechen77%2Fchemhelper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandrechen77%2Fchemhelper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bc504225840ebe398846fb2476bf98f4e4ef9f3b [INFO] building andrechen77/chemhelper against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandrechen77%2Fchemhelper" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/andrechen77/chemhelper on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/andrechen77/chemhelper [INFO] finished tweaking git repo https://github.com/andrechen77/chemhelper [INFO] tweaked toml for git repo https://github.com/andrechen77/chemhelper written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/andrechen77/chemhelper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b1600191227b6129ac23ac5b1fa7c39422ef818c3980a79a82668a897f29381 [INFO] running `Command { std: "docker" "start" "-a" "3b1600191227b6129ac23ac5b1fa7c39422ef818c3980a79a82668a897f29381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b1600191227b6129ac23ac5b1fa7c39422ef818c3980a79a82668a897f29381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b1600191227b6129ac23ac5b1fa7c39422ef818c3980a79a82668a897f29381", kill_on_drop: false }` [INFO] [stdout] 3b1600191227b6129ac23ac5b1fa7c39422ef818c3980a79a82668a897f29381 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2dab171bc3923977c52b9e5be21a0bbddad833ff0fefee471a1e7164a4cd971e [INFO] running `Command { std: "docker" "start" "-a" "2dab171bc3923977c52b9e5be21a0bbddad833ff0fefee471a1e7164a4cd971e", kill_on_drop: false }` [INFO] [stderr] Compiling chemhelper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `DictAccessError` [INFO] [stdout] --> src/parse/expression.rs:3:55 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::chem_data::dictionary::{Dictionary, Value, DictAccessError, UndefinedIdentifierError, BadTypeError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/chem_data/chem_eqn.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: lifetime may not live long enough [INFO] [stdout] --> src/chem_data/dictionary.rs:177:41 [INFO] [stdout] | [INFO] [stdout] 174 | fn source(&self) -> Option<&(dyn Error + 'static)> { [INFO] [stdout] | ----- has type `&DictAccessError<'1>` [INFO] [stdout] ... [INFO] [stdout] 177 | DictAccessError::UndefinedId(err) => Some(err), [INFO] [stdout] | ^^^^^^^^^ returning this value requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: lifetime may not live long enough [INFO] [stdout] --> src/chem_data/dictionary.rs:211:3 [INFO] [stdout] | [INFO] [stdout] 210 | fn from(value: UndefinedIdentifierError<'_>) -> Self { [INFO] [stdout] | ----- ---- return type is DictAccessError<'2> [INFO] [stdout] | | [INFO] [stdout] | has type `UndefinedIdentifierError<'1>` [INFO] [stdout] 211 | DictAccessError::UndefinedId(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/chem_data/real_number.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `token` [INFO] [stdout] --> src/parse/expression/parser.rs:601:26 [INFO] [stdout] | [INFO] [stdout] 601 | fn add_token(&mut self, token: Token) -> Result, ParseError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_token` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0515]: cannot return value referencing local data `self.name` [INFO] [stdout] --> src/parse/expression.rs:46:6 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(dict.get_value(&self.name).cloned()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^----------^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `self.name` is borrowed here [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dict` [INFO] [stdout] --> src/parse/expression.rs:90:35 [INFO] [stdout] | [INFO] [stdout] 90 | fn evaluate<'a>(self: Box, dict: &'a Dictionary) -> Result, EvaluationError<'a>> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_dict` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dict` [INFO] [stdout] --> src/parse/expression.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | fn evaluate<'a>(self: Box, dict: &'a Dictionary) -> Result, EvaluationError<'a>> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_dict` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dict` [INFO] [stdout] --> src/parse/expression.rs:121:35 [INFO] [stdout] | [INFO] [stdout] 121 | fn evaluate<'a>(self: Box, dict: &'a Dictionary) -> Result, EvaluationError<'a>> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_dict` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dict` [INFO] [stdout] --> src/parse/expression.rs:147:35 [INFO] [stdout] | [INFO] [stdout] 147 | fn evaluate<'a>(self: Box, dict: &'a Dictionary) -> Result, EvaluationError<'a>> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_dict` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dict` [INFO] [stdout] --> src/parse/expression.rs:197:35 [INFO] [stdout] | [INFO] [stdout] 197 | fn evaluate<'a>(self: Box, dict: &'a Dictionary) -> Result, EvaluationError<'a>> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_dict` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | match parse_str(&line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 32 | Ok(expr) => { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `expr` calls a custom destructor [INFO] [stdout] | `expr` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `expr` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stderr] error: could not compile `chemhelper` (lib) due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2dab171bc3923977c52b9e5be21a0bbddad833ff0fefee471a1e7164a4cd971e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dab171bc3923977c52b9e5be21a0bbddad833ff0fefee471a1e7164a4cd971e", kill_on_drop: false }` [INFO] [stdout] 2dab171bc3923977c52b9e5be21a0bbddad833ff0fefee471a1e7164a4cd971e