[INFO] cloning repository https://github.com/Sheyne/basic-rust-lisp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sheyne/basic-rust-lisp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSheyne%2Fbasic-rust-lisp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSheyne%2Fbasic-rust-lisp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9deeb82036c6a75ca2b94109c133159389502543 [INFO] building Sheyne/basic-rust-lisp against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSheyne%2Fbasic-rust-lisp" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sheyne/basic-rust-lisp on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Sheyne/basic-rust-lisp [INFO] finished tweaking git repo https://github.com/Sheyne/basic-rust-lisp [INFO] tweaked toml for git repo https://github.com/Sheyne/basic-rust-lisp written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Sheyne/basic-rust-lisp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded atomic-counter v1.0.1 [INFO] [stderr] Downloaded im v13.0.0 [INFO] [stderr] Downloaded sized-chunks v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 701241e620986e16a79d78fdad515f1c77411f91fc6e60d82187ad80a7abd279 [INFO] running `Command { std: "docker" "start" "-a" "701241e620986e16a79d78fdad515f1c77411f91fc6e60d82187ad80a7abd279", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "701241e620986e16a79d78fdad515f1c77411f91fc6e60d82187ad80a7abd279", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "701241e620986e16a79d78fdad515f1c77411f91fc6e60d82187ad80a7abd279", kill_on_drop: false }` [INFO] [stdout] 701241e620986e16a79d78fdad515f1c77411f91fc6e60d82187ad80a7abd279 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a54729db1730ab5a7afa96d1f9b222da47ad5ac6b1426269510771c7b8f11490 [INFO] running `Command { std: "docker" "start" "-a" "a54729db1730ab5a7afa96d1f9b222da47ad5ac6b1426269510771c7b8f11490", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling atomic-counter v1.0.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling im v13.0.0 [INFO] [stderr] Compiling sized-chunks v0.3.0 [INFO] [stderr] Compiling rust_interp v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.32s [INFO] running `Command { std: "docker" "inspect" "a54729db1730ab5a7afa96d1f9b222da47ad5ac6b1426269510771c7b8f11490", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a54729db1730ab5a7afa96d1f9b222da47ad5ac6b1426269510771c7b8f11490", kill_on_drop: false }` [INFO] [stdout] a54729db1730ab5a7afa96d1f9b222da47ad5ac6b1426269510771c7b8f11490 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 738b1491c54f8b3f231333aee5c4c35073f1910ea74f52b9c3c4cb7e9ef7fda0 [INFO] running `Command { std: "docker" "start" "-a" "738b1491c54f8b3f231333aee5c4c35073f1910ea74f52b9c3c4cb7e9ef7fda0", kill_on_drop: false }` [INFO] [stderr] Compiling rust_interp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/eval.rs:294:42 [INFO] [stdout] | [INFO] [stdout] 292 | let env = HashMap::unit("x", Value::Double(14.0)); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `env` calls a custom destructor [INFO] [stdout] | `env` will be dropped later as of Edition 2024 [INFO] [stdout] 293 | [INFO] [stdout] 294 | assert_eq!(eval(&id("x"), &env), Value::Double(14.0)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 295 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/sized-chunks-0.3.0/src/sparse_chunk.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | impl> Drop for SparseChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/sized-chunks-0.3.0/src/sparse_chunk.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | impl> Drop for SparseChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `env` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/sized-chunks-0.3.0/src/sparse_chunk.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | impl> Drop for SparseChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/eval.rs:302:42 [INFO] [stdout] | [INFO] [stdout] 300 | let env = HashMap::unit("x", Value::Double(14.0)); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `env` calls a custom destructor [INFO] [stdout] | `env` will be dropped later as of Edition 2024 [INFO] [stdout] 301 | [INFO] [stdout] 302 | assert_eq!(eval(&id("y"), &env), Value::Double(14.0)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 303 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/sized-chunks-0.3.0/src/sparse_chunk.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | impl> Drop for SparseChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/sized-chunks-0.3.0/src/sparse_chunk.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | impl> Drop for SparseChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `env` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/sized-chunks-0.3.0/src/sparse_chunk.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | impl> Drop for SparseChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_interp` (bin "rust_interp" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "738b1491c54f8b3f231333aee5c4c35073f1910ea74f52b9c3c4cb7e9ef7fda0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "738b1491c54f8b3f231333aee5c4c35073f1910ea74f52b9c3c4cb7e9ef7fda0", kill_on_drop: false }` [INFO] [stdout] 738b1491c54f8b3f231333aee5c4c35073f1910ea74f52b9c3c4cb7e9ef7fda0