[INFO] cloning repository https://github.com/Sherif-Abdou/basic-algebra [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sherif-Abdou/basic-algebra" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherif-Abdou%2Fbasic-algebra", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherif-Abdou%2Fbasic-algebra'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 68f7850565c1d8a03512daa152434c4333c93b4a [INFO] building Sherif-Abdou/basic-algebra against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherif-Abdou%2Fbasic-algebra" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sherif-Abdou/basic-algebra on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Sherif-Abdou/basic-algebra [INFO] finished tweaking git repo https://github.com/Sherif-Abdou/basic-algebra [INFO] tweaked toml for git repo https://github.com/Sherif-Abdou/basic-algebra written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Sherif-Abdou/basic-algebra already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3daf11efb0a89bcb7d29911857ef1b6ec319aec41fcbbfdd6c179e3225979d9d [INFO] running `Command { std: "docker" "start" "-a" "3daf11efb0a89bcb7d29911857ef1b6ec319aec41fcbbfdd6c179e3225979d9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3daf11efb0a89bcb7d29911857ef1b6ec319aec41fcbbfdd6c179e3225979d9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3daf11efb0a89bcb7d29911857ef1b6ec319aec41fcbbfdd6c179e3225979d9d", kill_on_drop: false }` [INFO] [stdout] 3daf11efb0a89bcb7d29911857ef1b6ec319aec41fcbbfdd6c179e3225979d9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3a08f0d7a1232e741cada911f5c36c6e73a602eae3547f2ba3ec0662ffb2078 [INFO] running `Command { std: "docker" "start" "-a" "b3a08f0d7a1232e741cada911f5c36c6e73a602eae3547f2ba3ec0662ffb2078", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling regex-syntax v0.6.18 [INFO] [stderr] Compiling aho-corasick v0.7.10 [INFO] [stderr] Compiling regex v1.3.9 [INFO] [stderr] Compiling algebra v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/equation_solver.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | let new_left_side = if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - let new_left_side = if (!flip) { [INFO] [stdout] 77 + let new_left_side = if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | return if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - return if (!flip) { [INFO] [stdout] 101 + return if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::equation::*` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::equation::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 50 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - let values = (*box_tuple.clone()); [INFO] [stdout] 50 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - let values = (*box_tuple.clone()); [INFO] [stdout] 58 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - let values = (*box_tuple.clone()); [INFO] [stdout] 66 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - let values = (*box_tuple.clone()); [INFO] [stdout] 74 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/equation_solver.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut variable_path = self.get_variable_path()?; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut new_eq_result = solver.solve_step(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut equation = equation::Equation::from_tokens(tokens); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let mut solver = [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `right_side` and `left_side` are never read [INFO] [stdout] --> src/equation.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Equation { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 4 | tokens: Vec, [INFO] [stdout] 5 | pub right_side: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 6 | pub left_side: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.01s [INFO] running `Command { std: "docker" "inspect" "b3a08f0d7a1232e741cada911f5c36c6e73a602eae3547f2ba3ec0662ffb2078", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3a08f0d7a1232e741cada911f5c36c6e73a602eae3547f2ba3ec0662ffb2078", kill_on_drop: false }` [INFO] [stdout] b3a08f0d7a1232e741cada911f5c36c6e73a602eae3547f2ba3ec0662ffb2078 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad5686cdf61a99afcd675751f5a4306dc59d09cbd940aa971bb1c2fb93f0c417 [INFO] running `Command { std: "docker" "start" "-a" "ad5686cdf61a99afcd675751f5a4306dc59d09cbd940aa971bb1c2fb93f0c417", kill_on_drop: false }` [INFO] [stderr] Compiling algebra v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/equation_solver.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | let new_left_side = if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - let new_left_side = if (!flip) { [INFO] [stdout] 77 + let new_left_side = if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | return if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - return if (!flip) { [INFO] [stdout] 101 + return if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::equation::*` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::equation::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 50 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - let values = (*box_tuple.clone()); [INFO] [stdout] 50 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - let values = (*box_tuple.clone()); [INFO] [stdout] 58 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - let values = (*box_tuple.clone()); [INFO] [stdout] 66 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - let values = (*box_tuple.clone()); [INFO] [stdout] 74 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/equation_solver.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut variable_path = self.get_variable_path()?; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut new_eq_result = solver.solve_step(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut equation = equation::Equation::from_tokens(tokens); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let mut solver = [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `right_side` and `left_side` are never read [INFO] [stdout] --> src/equation.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Equation { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 4 | tokens: Vec, [INFO] [stdout] 5 | pub right_side: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 6 | pub left_side: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.14s [INFO] running `Command { std: "docker" "inspect" "ad5686cdf61a99afcd675751f5a4306dc59d09cbd940aa971bb1c2fb93f0c417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad5686cdf61a99afcd675751f5a4306dc59d09cbd940aa971bb1c2fb93f0c417", kill_on_drop: false }` [INFO] [stdout] ad5686cdf61a99afcd675751f5a4306dc59d09cbd940aa971bb1c2fb93f0c417