[INFO] cloning repository https://github.com/S-Mann/bad-grep [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/S-Mann/bad-grep" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS-Mann%2Fbad-grep", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS-Mann%2Fbad-grep'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2d9f40048a324c9e46d0c69716a8d9edba4ef825 [INFO] building S-Mann/bad-grep against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS-Mann%2Fbad-grep" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/S-Mann/bad-grep on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/S-Mann/bad-grep [INFO] finished tweaking git repo https://github.com/S-Mann/bad-grep [INFO] tweaked toml for git repo https://github.com/S-Mann/bad-grep written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/S-Mann/bad-grep already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6385cb07b1389b17512ccf767a1bb0f163b773678106ad9774c1e2a5ecff64c [INFO] running `Command { std: "docker" "start" "-a" "c6385cb07b1389b17512ccf767a1bb0f163b773678106ad9774c1e2a5ecff64c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6385cb07b1389b17512ccf767a1bb0f163b773678106ad9774c1e2a5ecff64c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6385cb07b1389b17512ccf767a1bb0f163b773678106ad9774c1e2a5ecff64c", kill_on_drop: false }` [INFO] [stdout] c6385cb07b1389b17512ccf767a1bb0f163b773678106ad9774c1e2a5ecff64c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a4e9ea044307d9ac146948ccccf432ff8ff4b42d55d1f201fc46cf7f9139848 [INFO] running `Command { std: "docker" "start" "-a" "5a4e9ea044307d9ac146948ccccf432ff8ff4b42d55d1f201fc46cf7f9139848", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling yaml-rust v0.3.5 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling colored v2.0.0 [INFO] [stderr] Compiling bad-grep v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/app_logic/mod.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | let file_path = filename.as_ref().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 41 - let file_path = filename.as_ref().clone(); [INFO] [stdout] 41 + let file_path = filename.as_ref(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.64s [INFO] running `Command { std: "docker" "inspect" "5a4e9ea044307d9ac146948ccccf432ff8ff4b42d55d1f201fc46cf7f9139848", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a4e9ea044307d9ac146948ccccf432ff8ff4b42d55d1f201fc46cf7f9139848", kill_on_drop: false }` [INFO] [stdout] 5a4e9ea044307d9ac146948ccccf432ff8ff4b42d55d1f201fc46cf7f9139848 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d4e8af4e6711755d49d751c3e478437a4310d24740acf13c093f3a0d6faec0e [INFO] running `Command { std: "docker" "start" "-a" "1d4e8af4e6711755d49d751c3e478437a4310d24740acf13c093f3a0d6faec0e", kill_on_drop: false }` [INFO] [stderr] Compiling bad-grep v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/app_logic/mod.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | let file_path = filename.as_ref().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 41 - let file_path = filename.as_ref().clone(); [INFO] [stdout] 41 + let file_path = filename.as_ref(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.14s [INFO] running `Command { std: "docker" "inspect" "1d4e8af4e6711755d49d751c3e478437a4310d24740acf13c093f3a0d6faec0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d4e8af4e6711755d49d751c3e478437a4310d24740acf13c093f3a0d6faec0e", kill_on_drop: false }` [INFO] [stdout] 1d4e8af4e6711755d49d751c3e478437a4310d24740acf13c093f3a0d6faec0e