[INFO] cloning repository https://github.com/MarcHoff94/chatroom [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MarcHoff94/chatroom" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarcHoff94%2Fchatroom", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarcHoff94%2Fchatroom'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2b75bf00779c39dc43cecf58ca5a66c5cb4718b8 [INFO] building MarcHoff94/chatroom against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarcHoff94%2Fchatroom" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MarcHoff94/chatroom on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MarcHoff94/chatroom [INFO] finished tweaking git repo https://github.com/MarcHoff94/chatroom [INFO] tweaked toml for git repo https://github.com/MarcHoff94/chatroom written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/MarcHoff94/chatroom already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27419272175b4c9d7389acaaf44b0e755fbbcb0bc7b43d36e7ea00390eaf4c4f [INFO] running `Command { std: "docker" "start" "-a" "27419272175b4c9d7389acaaf44b0e755fbbcb0bc7b43d36e7ea00390eaf4c4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27419272175b4c9d7389acaaf44b0e755fbbcb0bc7b43d36e7ea00390eaf4c4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27419272175b4c9d7389acaaf44b0e755fbbcb0bc7b43d36e7ea00390eaf4c4f", kill_on_drop: false }` [INFO] [stdout] 27419272175b4c9d7389acaaf44b0e755fbbcb0bc7b43d36e7ea00390eaf4c4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 409795cbdc1f55e6b072621a789f56bf6b5319cae3b381bdc77bb498915862f9 [INFO] running `Command { std: "docker" "start" "-a" "409795cbdc1f55e6b072621a789f56bf6b5319cae3b381bdc77bb498915862f9", kill_on_drop: false }` [INFO] [stderr] Compiling chatroom v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs::read` [INFO] [stdout] --> src/client.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Read` and `Split` [INFO] [stdout] --> src/client.rs:2:41 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, BufRead, BufReader, Read, Split, Stdin, Write}; [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/client.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/client.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | loop {; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/client.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 96 | / loop { [INFO] [stdout] 97 | | input.clear(); [INFO] [stdout] 98 | | stdin.read_line(&mut input)?; [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 123 | [INFO] [stdout] 124 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut msg_username = format_msg(MessageType::LOGIN, username.trim(), "I have joined the Lobby!", None); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `result` is never read [INFO] [stdout] --> src/client.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | let mut result = String::new(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/client.rs:225:21 [INFO] [stdout] | [INFO] [stdout] 225 | let content = resp_iter.next().unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `resp_type` [INFO] [stdout] --> src/client.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 253 | let resp_type = resp_iter.next().unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_resp_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/client.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | let content = resp_iter.next().unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | let mut response = match await_server_response(Arc::clone(&response_buffer)) { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/client.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn main() -> std::io::Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_username` is never used [INFO] [stdout] --> src/client.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn get_username(io_input: &Stdin) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_username_legal` is never used [INFO] [stdout] --> src/client.rs:176:4 [INFO] [stdout] | [INFO] [stdout] 176 | fn is_username_legal<'a>(username: &'a str) -> Result<(), &'a str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `await_server_response` is never used [INFO] [stdout] --> src/client.rs:185:4 [INFO] [stdout] | [INFO] [stdout] 185 | fn await_server_response(buffer: Arc>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `enter_lobby` is never used [INFO] [stdout] --> src/client.rs:197:4 [INFO] [stdout] | [INFO] [stdout] 197 | fn enter_lobby<'a>(stream: Arc>, username: &'a str, curr_chatroom: Arc>, response_buffer: Arc src/client.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | stream.lock().unwrap().write_all(msg_username.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = stream.lock().unwrap().write_all(msg_username.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 105 | let _ = stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | io_input.read_line(&mut username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 165 | let _ = io_input.read_line(&mut username); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | stdin.read_line(&mut input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 208 | let _ = stdin.read_line(&mut input); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 215 | let _ = stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:244:17 [INFO] [stdout] | [INFO] [stdout] 244 | stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 244 | let _ = stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:263:17 [INFO] [stdout] | [INFO] [stdout] 263 | stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 263 | let _ = stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/main.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 235 | let stream = Arc::clone(self.logged_in.get(&username.to_string()).unwrap()); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | ... match lobby.lock().unwrap().log_in(String::from(username), Arc::clone(&stream)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#12` [INFO] [stdout] | up until Edition 2021 `#12` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 63 | ... Ok(_) => { [INFO] [stdout] 64 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LogInSuccess, username, None).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LogInFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | ... }, [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 74 | ... match lobby.lock().unwrap().create_chatroom(String::from(content), participants) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 75 | ... Ok(_) => stream.lock().unwrap().write_all(format_response(ServerResponse::CreateChatroomSuccess, username, None).as_bytes()), [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 76 | ... Err(e) => stream.lock().unwrap().write_all(format_response(ServerResponse::CreateChatroomFailed, username, Some(e)).as_byte... [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | ... match lobby.lock().unwrap().enter_chatroom(String::from(username), chatroom_name.clone()) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::EnterChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LeaveChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | `#8` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | ... lobby.lock().unwrap().chatrooms.keys().for_each(|x| { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#9` [INFO] [stdout] | `#9` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::GetChatroomsSuccess, username, Some(chatroomlist.as_str())).as... [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#10` [INFO] [stdout] | `#10` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::ChatMessageFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#11` [INFO] [stdout] | `#11` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#12` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#9` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#10` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#11` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:111:31 [INFO] [stdout] | [INFO] [stdout] 64 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LogInSuccess, username, None).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LogInFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | ... match lobby.lock().unwrap().create_chatroom(String::from(content), participants) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] 75 | ... Ok(_) => stream.lock().unwrap().write_all(format_response(ServerResponse::CreateChatroomSuccess, username, None).as_bytes()), [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | `#4` will be dropped later as of Edition 2024 [INFO] [stdout] 76 | ... Err(e) => stream.lock().unwrap().write_all(format_response(ServerResponse::CreateChatroomFailed, username, Some(e)).as_byte... [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#5` [INFO] [stdout] | `#5` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | ... match lobby.lock().unwrap().enter_chatroom(String::from(username), chatroom_name.clone()) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#6` [INFO] [stdout] | `#6` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::EnterChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#7` [INFO] [stdout] | `#7` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LeaveChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#8` [INFO] [stdout] | `#8` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | ... lobby.lock().unwrap().chatrooms.keys().for_each(|x| { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#9` [INFO] [stdout] | `#9` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::GetChatroomsSuccess, username, Some(chatroomlist.as_str())).as... [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#10` [INFO] [stdout] | `#10` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | ... match lobby.lock().unwrap().broadcast_message(username, chatroom, content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#12` [INFO] [stdout] | up until Edition 2021 `#12` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::ChatMessageFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#11` [INFO] [stdout] | `#11` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | ... } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: `#12` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#5` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#6` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#7` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#8` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#9` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#10` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] note: `#11` invokes this custom destructor [INFO] [stdout] --> /rustc/11663cd3bfefef7d34e8f0892c250bf698049392/library/std/src/sync/mutex.rs:644:1 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/main.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 131 | struct Chatroom { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 132 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Chatroom` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `logged_out` is never read [INFO] [stdout] --> src/main.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 163 | struct Lobby { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 164 | logged_in: HashMap>>, [INFO] [stdout] 165 | logged_out: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Lobby` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `log_out` is never used [INFO] [stdout] --> src/main.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 168 | impl Lobby { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 179 | fn log_out(&mut self, username: String) -> Result<(), &str> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `GetChatroomsFailed` is never constructed [INFO] [stdout] --> src/main.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 251 | enum ServerResponse { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 263 | GetChatroomsFailed, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:64:33 [INFO] [stdout] | [INFO] [stdout] 64 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LogInSuccess, username, None).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 64 | let _ = stream.lock().unwrap().write_all(format_response(ServerResponse::LogInSuccess, username, None).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 67 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LogInFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 67 | let _ = stream.lock().unwrap().write_all(format_response(ServerResponse::LogInFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | / ... match lobby.lock().unwrap().create_chatroom(String::from(content), participants) { [INFO] [stdout] 75 | | ... Ok(_) => stream.lock().unwrap().write_all(format_response(ServerResponse::CreateChatroomSuccess, username, None).as_bytes()), [INFO] [stdout] 76 | | ... Err(e) => stream.lock().unwrap().write_all(format_response(ServerResponse::CreateChatroomFailed, username, Some(e)).as_bytes()) [INFO] [stdout] 77 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = match lobby.lock().unwrap().create_chatroom(String::from(content), participants) { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::EnterChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 85 | let _ = stream.lock().unwrap().write_all(format_response(ServerResponse::EnterChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:94:33 [INFO] [stdout] | [INFO] [stdout] 94 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::LeaveChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 94 | let _ = stream.lock().unwrap().write_all(format_response(ServerResponse::LeaveChatroomFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:107:25 [INFO] [stdout] | [INFO] [stdout] 107 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::GetChatroomsSuccess, username, Some(chatroomlist.as_str())).as_bytes()); ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = stream.lock().unwrap().write_all(format_response(ServerResponse::GetChatroomsSuccess, username, Some(chatroomlist.as_str())).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:114:33 [INFO] [stdout] | [INFO] [stdout] 114 | ... stream.lock().unwrap().write_all(format_response(ServerResponse::ChatMessageFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 114 | let _ = stream.lock().unwrap().write_all(format_response(ServerResponse::ChatMessageFailed, username, Some(e)).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:195:17 [INFO] [stdout] | [INFO] [stdout] 195 | stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 195 | let _ = stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 211 | let _ = stream.lock().unwrap().write_all(msg.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chatroom` (bin "chatroom") due to 2 previous errors; 14 warnings emitted [INFO] running `Command { std: "docker" "inspect" "409795cbdc1f55e6b072621a789f56bf6b5319cae3b381bdc77bb498915862f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "409795cbdc1f55e6b072621a789f56bf6b5319cae3b381bdc77bb498915862f9", kill_on_drop: false }` [INFO] [stdout] 409795cbdc1f55e6b072621a789f56bf6b5319cae3b381bdc77bb498915862f9