[INFO] cloning repository https://github.com/John-Bush14/rsnbs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/John-Bush14/rsnbs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohn-Bush14%2Frsnbs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohn-Bush14%2Frsnbs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1a82161f95bb71de109918b42ebb267dd385419e [INFO] building John-Bush14/rsnbs against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohn-Bush14%2Frsnbs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/John-Bush14/rsnbs on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/John-Bush14/rsnbs [INFO] finished tweaking git repo https://github.com/John-Bush14/rsnbs [INFO] tweaked toml for git repo https://github.com/John-Bush14/rsnbs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2de54845bead8424027b89d2d4e4873f82ac0c2aa14abe61171cae1e2deab684 [INFO] running `Command { std: "docker" "start" "-a" "2de54845bead8424027b89d2d4e4873f82ac0c2aa14abe61171cae1e2deab684", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2de54845bead8424027b89d2d4e4873f82ac0c2aa14abe61171cae1e2deab684", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2de54845bead8424027b89d2d4e4873f82ac0c2aa14abe61171cae1e2deab684", kill_on_drop: false }` [INFO] [stdout] 2de54845bead8424027b89d2d4e4873f82ac0c2aa14abe61171cae1e2deab684 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5acda420f7b00bcbe36a92929d673733edd5c2ee91560907009b373e40c57e77 [INFO] running `Command { std: "docker" "start" "-a" "5acda420f7b00bcbe36a92929d673733edd5c2ee91560907009b373e40c57e77", kill_on_drop: false }` [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling rsnbs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Header` [INFO] [stdout] --> src/parser.rs:1:37 [INFO] [stdout] | [INFO] [stdout] 1 | use super::{Song, BinaryMut, Layer, Header, Note, Instrument}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem::transmute` [INFO] [stdout] --> src/parser.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use std::mem::transmute; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `from_bytes` should have an upper camel case name [INFO] [stdout] --> src/parser.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | trait from_bytes {fn from_bytes(bytes: Vec) -> T;} [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `FromBytes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/parser.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::parser::read_nbs` [INFO] [stdout] --> src/tests.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | use super::super::parser::read_nbs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::Song` [INFO] [stdout] --> src/tests.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | use super::super::Song; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diff::chars` [INFO] [stdout] --> src/tests.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use diff::chars; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `writable_bin` should have an upper camel case name [INFO] [stdout] --> src/writer.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | trait writable_bin { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `WritableBin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | fn read_string(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/parser.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | for (binary, version) in part { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 32 | impl_writable_bin!([u8, i8, i16, i32,]); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_writable_bin` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 43 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/writer.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | for (binary, version) in part { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | fn write_part(mut file: File, part: Vec<(Binary, u8)>) -> Option<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | let mut file = match OpenOptions::new().write(true).open(filename) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TEST_FILES` is never used [INFO] [stdout] --> src/tests.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | const TEST_FILES: [&str;2] = ["test_files/Megalovania.nbs", "test_files/DB.nbs"]; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `Command { std: "docker" "inspect" "5acda420f7b00bcbe36a92929d673733edd5c2ee91560907009b373e40c57e77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5acda420f7b00bcbe36a92929d673733edd5c2ee91560907009b373e40c57e77", kill_on_drop: false }` [INFO] [stdout] 5acda420f7b00bcbe36a92929d673733edd5c2ee91560907009b373e40c57e77 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4193dc7b27224e8dd9d8bed8baa93be2800b27cbd29f74c9819fc46c47c95a36 [INFO] running `Command { std: "docker" "start" "-a" "4193dc7b27224e8dd9d8bed8baa93be2800b27cbd29f74c9819fc46c47c95a36", kill_on_drop: false }` [INFO] [stdout] warning: unused import: `Header` [INFO] [stdout] --> src/parser.rs:1:37 [INFO] [stdout] | [INFO] [stdout] 1 | use super::{Song, BinaryMut, Layer, Header, Note, Instrument}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem::transmute` [INFO] [stdout] --> src/parser.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use std::mem::transmute; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `from_bytes` should have an upper camel case name [INFO] [stdout] --> src/parser.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | trait from_bytes {fn from_bytes(bytes: Vec) -> T;} [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `FromBytes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/parser.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::parser::read_nbs` [INFO] [stdout] --> src/tests.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | use super::super::parser::read_nbs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::Song` [INFO] [stdout] --> src/tests.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | use super::super::Song; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diff::chars` [INFO] [stdout] --> src/tests.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use diff::chars; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `writable_bin` should have an upper camel case name [INFO] [stdout] --> src/writer.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | trait writable_bin { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `WritableBin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | fn read_string(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/parser.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | for (binary, version) in part { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 32 | impl_writable_bin!([u8, i8, i16, i32,]); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_writable_bin` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 43 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/writer.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | for (binary, version) in part { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | fn write_part(mut file: File, part: Vec<(Binary, u8)>) -> Option<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | let mut file = match OpenOptions::new().write(true).open(filename) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TEST_FILES` is never used [INFO] [stdout] --> src/tests.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | const TEST_FILES: [&str;2] = ["test_files/Megalovania.nbs", "test_files/DB.nbs"]; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling rsnbs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Header` [INFO] [stdout] --> src/parser.rs:1:37 [INFO] [stdout] | [INFO] [stdout] 1 | use super::{Song, BinaryMut, Layer, Header, Note, Instrument}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem::transmute` [INFO] [stdout] --> src/parser.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use std::mem::transmute; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `from_bytes` should have an upper camel case name [INFO] [stdout] --> src/parser.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | trait from_bytes {fn from_bytes(bytes: Vec) -> T;} [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `FromBytes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/parser.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::Song` [INFO] [stdout] --> src/tests.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | use super::super::Song; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/tests.rs:11:30 [INFO] [stdout] | [INFO] [stdout] 11 | let test_file_dest = (test_file.to_string() + "Test"); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - let test_file_dest = (test_file.to_string() + "Test"); [INFO] [stdout] 11 + let test_file_dest = test_file.to_string() + "Test"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `writable_bin` should have an upper camel case name [INFO] [stdout] --> src/writer.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | trait writable_bin { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `WritableBin` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | fn read_string(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/parser.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | for (binary, version) in part { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 32 | impl_writable_bin!([u8, i8, i16, i32,]); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_writable_bin` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 43 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | fn write_default(mut file: File) -> Option { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/writer.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | for (binary, version) in part { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | fn write_part(mut file: File, part: Vec<(Binary, u8)>) -> Option<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/writer.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | let mut file = match OpenOptions::new().write(true).open(filename) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.26s [INFO] running `Command { std: "docker" "inspect" "4193dc7b27224e8dd9d8bed8baa93be2800b27cbd29f74c9819fc46c47c95a36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4193dc7b27224e8dd9d8bed8baa93be2800b27cbd29f74c9819fc46c47c95a36", kill_on_drop: false }` [INFO] [stdout] 4193dc7b27224e8dd9d8bed8baa93be2800b27cbd29f74c9819fc46c47c95a36