[INFO] cloning repository https://github.com/EleanorWhite/goFish
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EleanorWhite/goFish" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEleanorWhite%2FgoFish", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEleanorWhite%2FgoFish'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] cc95edb4e675f768bcfa0cd6288e0e9faca9639d
[INFO] building EleanorWhite/goFish against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEleanorWhite%2FgoFish" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] validating manifest of git repo https://github.com/EleanorWhite/goFish on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking git repo https://github.com/EleanorWhite/goFish
[INFO] finished tweaking git repo https://github.com/EleanorWhite/goFish
[INFO] tweaked toml for git repo https://github.com/EleanorWhite/goFish written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] crate git repo https://github.com/EleanorWhite/goFish already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded termion v1.5.2
[INFO] [stderr]   Downloaded redox_syscall v0.1.54
[INFO] [stderr]   Downloaded libc v0.2.53
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 163f2029e2aa8f120dd7bbf32a50ec25ee377aa4da7d82a646d3bec4da66d7dd
[INFO] running `Command { std: "docker" "start" "-a" "163f2029e2aa8f120dd7bbf32a50ec25ee377aa4da7d82a646d3bec4da66d7dd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "163f2029e2aa8f120dd7bbf32a50ec25ee377aa4da7d82a646d3bec4da66d7dd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "163f2029e2aa8f120dd7bbf32a50ec25ee377aa4da7d82a646d3bec4da66d7dd", kill_on_drop: false }`
[INFO] [stdout] 163f2029e2aa8f120dd7bbf32a50ec25ee377aa4da7d82a646d3bec4da66d7dd
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a9feb4f1a840e453c9d393c0cb7c703b83758d370f4f26e71203172363cc290b
[INFO] running `Command { std: "docker" "start" "-a" "a9feb4f1a840e453c9d393c0cb7c703b83758d370f4f26e71203172363cc290b", kill_on_drop: false }`
[INFO] [stderr]    Compiling rand_core v0.4.0
[INFO] [stderr]    Compiling autocfg v0.1.4
[INFO] [stderr]    Compiling libc v0.2.53
[INFO] [stderr]    Compiling numtoa v0.1.0
[INFO] [stderr]    Compiling rand_core v0.3.1
[INFO] [stderr]    Compiling rand_jitter v0.1.4
[INFO] [stderr]    Compiling rand_isaac v0.1.1
[INFO] [stderr]    Compiling rand_xorshift v0.1.1
[INFO] [stderr]    Compiling rand_hc v0.1.0
[INFO] [stderr]    Compiling rand_chacha v0.1.1
[INFO] [stderr]    Compiling rand_pcg v0.1.2
[INFO] [stderr]    Compiling rand v0.6.5
[INFO] [stderr]    Compiling rand_os v0.1.3
[INFO] [stderr]    Compiling termion v1.5.2
[INFO] [stderr]    Compiling new_rust_project v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused imports: `Write`, `stdin`, and `stdout`
[INFO] [stdout]  --> src/main.rs:7:15
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::io::{Write, stdout, stdin};
[INFO] [stdout]   |               ^^^^^  ^^^^^^  ^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/main.rs:59:6
[INFO] [stdout]    |
[INFO] [stdout] 59 |         if (ranks[i] == card) {
[INFO] [stdout]    |            ^                ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 59 -         if (ranks[i] == card) {
[INFO] [stdout] 59 +         if ranks[i] == card {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/main.rs:80:7
[INFO] [stdout]    |
[INFO] [stdout] 80 |             if (new < min_val) {
[INFO] [stdout]    |                ^             ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 80 -             if (new < min_val) {
[INFO] [stdout] 80 +             if new < min_val {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     if (playing_hand.is_empty()) {
[INFO] [stdout]     |        ^                       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 123 -     if (playing_hand.is_empty()) {
[INFO] [stdout] 123 +     if playing_hand.is_empty() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:124:6
[INFO] [stdout]     |
[INFO] [stdout] 124 |         if (deck.is_empty()) { // game is over
[INFO] [stdout]     |            ^               ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 124 -         if (deck.is_empty()) { // game is over
[INFO] [stdout] 124 +         if deck.is_empty() { // game is over
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `while` condition
[INFO] [stdout]    --> src/main.rs:137:8
[INFO] [stdout]     |
[INFO] [stdout] 137 |     while (!card_in(playing_hand, &guess)) { 
[INFO] [stdout]     |           ^                              ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 137 -     while (!card_in(playing_hand, &guess)) { 
[INFO] [stdout] 137 +     while !card_in(playing_hand, &guess) { 
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:148:5
[INFO] [stdout]     |
[INFO] [stdout] 148 |     if (correct) {
[INFO] [stdout]     |        ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 148 -     if (correct) {
[INFO] [stdout] 148 +     if correct {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:157:5
[INFO] [stdout]     |
[INFO] [stdout] 157 |     if (comp_hand.is_empty()) {
[INFO] [stdout]     |        ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 157 -     if (comp_hand.is_empty()) {
[INFO] [stdout] 157 +     if comp_hand.is_empty() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:158:6
[INFO] [stdout]     |
[INFO] [stdout] 158 |         if (deck.is_empty()) { // game is over
[INFO] [stdout]     |            ^               ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 158 -         if (deck.is_empty()) { // game is over
[INFO] [stdout] 158 +         if deck.is_empty() { // game is over
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:183:5
[INFO] [stdout]     |
[INFO] [stdout] 183 |     if (correct) {
[INFO] [stdout]     |        ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 183 -     if (correct) {
[INFO] [stdout] 183 +     if correct {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:191:6
[INFO] [stdout]     |
[INFO] [stdout] 191 |         if (c == card) {
[INFO] [stdout]     |            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 191 -         if (c == card) {
[INFO] [stdout] 191 +         if c == card {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:202:5
[INFO] [stdout]     |
[INFO] [stdout] 202 |     if (card_in(other_hand, &guess)) {
[INFO] [stdout]     |        ^                           ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 202 -     if (card_in(other_hand, &guess)) {
[INFO] [stdout] 202 +     if card_in(other_hand, &guess) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:208:7
[INFO] [stdout]     |
[INFO] [stdout] 208 |             if (c == &guess) {
[INFO] [stdout]     |                ^           ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 208 -             if (c == &guess) {
[INFO] [stdout] 208 +             if c == &guess {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:230:10
[INFO] [stdout]     |
[INFO] [stdout] 230 |                      if (is_player) { println!("Drew {}", &x); }
[INFO] [stdout]     |                         ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 230 -                      if (is_player) { println!("Drew {}", &x); }
[INFO] [stdout] 230 +                      if is_player { println!("Drew {}", &x); }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:239:7
[INFO] [stdout]     |
[INFO] [stdout] 239 |             if (c == guess) {
[INFO] [stdout]     |                ^          ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 239 -             if (c == guess) {
[INFO] [stdout] 239 +             if c == guess {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:243:6
[INFO] [stdout]     |
[INFO] [stdout] 243 |         if (count == 4) {
[INFO] [stdout]     |            ^          ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 243 -         if (count == 4) {
[INFO] [stdout] 243 +         if count == 4 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:250:5
[INFO] [stdout]     |
[INFO] [stdout] 250 |     if (comp_finished.len() > player_finished.len()) {
[INFO] [stdout]     |        ^                                           ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 250 -     if (comp_finished.len() > player_finished.len()) {
[INFO] [stdout] 250 +     if comp_finished.len() > player_finished.len() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: denote infinite loops with `loop { ... }`
[INFO] [stdout]    --> src/main.rs:271:2
[INFO] [stdout]     |
[INFO] [stdout] 271 |     while true {
[INFO] [stdout]     |     ^^^^^^^^^^ help: use `loop`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(while_true)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:272:6
[INFO] [stdout]     |
[INFO] [stdout] 272 |         if (deck.is_empty() && player_hand.is_empty()) {
[INFO] [stdout]     |            ^                                         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 272 -         if (deck.is_empty() && player_hand.is_empty()) {
[INFO] [stdout] 272 +         if deck.is_empty() && player_hand.is_empty() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:135:25
[INFO] [stdout]     |
[INFO] [stdout] 135 |     let mut guess = buffer.trim_right().to_string();
[INFO] [stdout]     |                            ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 135 |     let mut guess = buffer.trim_end().to_string();
[INFO] [stdout]     |                            ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:143:18
[INFO] [stdout]     |
[INFO] [stdout] 143 |         guess = buffer.trim_right().to_string();
[INFO] [stdout]     |                        ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 143 |         guess = buffer.trim_end().to_string();
[INFO] [stdout]     |                        ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:146:21
[INFO] [stdout]     |
[INFO] [stdout] 146 |          &mut deck, guess.trim_right().to_string(), true);
[INFO] [stdout]     |                           ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 146 |          &mut deck, guess.trim_end().to_string(), true);
[INFO] [stdout]     |                           ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:181:21
[INFO] [stdout]     |
[INFO] [stdout] 181 |          &mut deck, guess.trim_right().to_string(), false);    
[INFO] [stdout]     |                           ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 181 |          &mut deck, guess.trim_end().to_string(), false);    
[INFO] [stdout]     |                           ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/main.rs:35:12
[INFO] [stdout]    |
[INFO] [stdout] 35 | fn shuffle(mut cards: &mut Vec<String>) {
[INFO] [stdout]    |            ----^^^^^
[INFO] [stdout]    |            |
[INFO] [stdout]    |            help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `suite`
[INFO] [stdout]   --> src/main.rs:50:7
[INFO] [stdout]    |
[INFO] [stdout] 50 |         for suite in 0..NUM_SUITES {
[INFO] [stdout]    |             ^^^^^ help: if this is intentional, prefix it with an underscore: `_suite`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]   --> src/main.rs:95:6
[INFO] [stdout]    |
[INFO] [stdout] 95 |     for i in 0..NUM_HAND {
[INFO] [stdout]    |         ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/main.rs:133:6
[INFO] [stdout]     |
[INFO] [stdout] 133 |     let mut buffer = &mut String::new();
[INFO] [stdout]     |         ----^^^^^^
[INFO] [stdout]     |         |
[INFO] [stdout]     |         help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/main.rs:199:2
[INFO] [stdout]     |
[INFO] [stdout] 199 |     mut other_hand: &mut Vec<String>, mut deck: &mut Vec<String>, guess: String, is_player: bool) -> bool {
[INFO] [stdout]     |     ----^^^^^^^^^^
[INFO] [stdout]     |     |
[INFO] [stdout]     |     help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `ranks` should have an upper case name
[INFO] [stdout]   --> src/main.rs:28:7
[INFO] [stdout]    |
[INFO] [stdout] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six",
[INFO] [stdout]    |       ^^^^^ help: convert the identifier to upper case: `RANKS`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `Result` that must be used
[INFO] [stdout]    --> src/main.rs:134:2
[INFO] [stdout]     |
[INFO] [stdout] 134 |     std::io::stdin().read_line(buffer);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stdout]     = note: `#[warn(unused_must_use)]` on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]     |
[INFO] [stdout] 134 |     let _ = std::io::stdin().read_line(buffer);
[INFO] [stdout]     |     +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `Result` that must be used
[INFO] [stdout]    --> src/main.rs:142:6
[INFO] [stdout]     |
[INFO] [stdout] 142 |         std::io::stdin().read_line(buffer);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]     |
[INFO] [stdout] 142 |         let _ = std::io::stdin().read_line(buffer);
[INFO] [stdout]     |         +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.50s
[INFO] running `Command { std: "docker" "inspect" "a9feb4f1a840e453c9d393c0cb7c703b83758d370f4f26e71203172363cc290b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a9feb4f1a840e453c9d393c0cb7c703b83758d370f4f26e71203172363cc290b", kill_on_drop: false }`
[INFO] [stdout] a9feb4f1a840e453c9d393c0cb7c703b83758d370f4f26e71203172363cc290b
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 4e87839eefbd73184c60157a211739922e7ae32a05b3b5465f5110eccccec726
[INFO] running `Command { std: "docker" "start" "-a" "4e87839eefbd73184c60157a211739922e7ae32a05b3b5465f5110eccccec726", kill_on_drop: false }`
[INFO] [stderr]    Compiling new_rust_project v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused imports: `Write`, `stdin`, and `stdout`
[INFO] [stdout]  --> src/main.rs:7:15
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::io::{Write, stdout, stdin};
[INFO] [stdout]   |               ^^^^^  ^^^^^^  ^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/main.rs:59:6
[INFO] [stdout]    |
[INFO] [stdout] 59 |         if (ranks[i] == card) {
[INFO] [stdout]    |            ^                ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 59 -         if (ranks[i] == card) {
[INFO] [stdout] 59 +         if ranks[i] == card {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]   --> src/main.rs:80:7
[INFO] [stdout]    |
[INFO] [stdout] 80 |             if (new < min_val) {
[INFO] [stdout]    |                ^             ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 80 -             if (new < min_val) {
[INFO] [stdout] 80 +             if new < min_val {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     if (playing_hand.is_empty()) {
[INFO] [stdout]     |        ^                       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 123 -     if (playing_hand.is_empty()) {
[INFO] [stdout] 123 +     if playing_hand.is_empty() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:124:6
[INFO] [stdout]     |
[INFO] [stdout] 124 |         if (deck.is_empty()) { // game is over
[INFO] [stdout]     |            ^               ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 124 -         if (deck.is_empty()) { // game is over
[INFO] [stdout] 124 +         if deck.is_empty() { // game is over
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `while` condition
[INFO] [stdout]    --> src/main.rs:137:8
[INFO] [stdout]     |
[INFO] [stdout] 137 |     while (!card_in(playing_hand, &guess)) { 
[INFO] [stdout]     |           ^                              ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 137 -     while (!card_in(playing_hand, &guess)) { 
[INFO] [stdout] 137 +     while !card_in(playing_hand, &guess) { 
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:148:5
[INFO] [stdout]     |
[INFO] [stdout] 148 |     if (correct) {
[INFO] [stdout]     |        ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 148 -     if (correct) {
[INFO] [stdout] 148 +     if correct {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:157:5
[INFO] [stdout]     |
[INFO] [stdout] 157 |     if (comp_hand.is_empty()) {
[INFO] [stdout]     |        ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 157 -     if (comp_hand.is_empty()) {
[INFO] [stdout] 157 +     if comp_hand.is_empty() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:158:6
[INFO] [stdout]     |
[INFO] [stdout] 158 |         if (deck.is_empty()) { // game is over
[INFO] [stdout]     |            ^               ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 158 -         if (deck.is_empty()) { // game is over
[INFO] [stdout] 158 +         if deck.is_empty() { // game is over
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:183:5
[INFO] [stdout]     |
[INFO] [stdout] 183 |     if (correct) {
[INFO] [stdout]     |        ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 183 -     if (correct) {
[INFO] [stdout] 183 +     if correct {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:191:6
[INFO] [stdout]     |
[INFO] [stdout] 191 |         if (c == card) {
[INFO] [stdout]     |            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 191 -         if (c == card) {
[INFO] [stdout] 191 +         if c == card {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:202:5
[INFO] [stdout]     |
[INFO] [stdout] 202 |     if (card_in(other_hand, &guess)) {
[INFO] [stdout]     |        ^                           ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 202 -     if (card_in(other_hand, &guess)) {
[INFO] [stdout] 202 +     if card_in(other_hand, &guess) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:208:7
[INFO] [stdout]     |
[INFO] [stdout] 208 |             if (c == &guess) {
[INFO] [stdout]     |                ^           ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 208 -             if (c == &guess) {
[INFO] [stdout] 208 +             if c == &guess {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:230:10
[INFO] [stdout]     |
[INFO] [stdout] 230 |                      if (is_player) { println!("Drew {}", &x); }
[INFO] [stdout]     |                         ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 230 -                      if (is_player) { println!("Drew {}", &x); }
[INFO] [stdout] 230 +                      if is_player { println!("Drew {}", &x); }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:239:7
[INFO] [stdout]     |
[INFO] [stdout] 239 |             if (c == guess) {
[INFO] [stdout]     |                ^          ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 239 -             if (c == guess) {
[INFO] [stdout] 239 +             if c == guess {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:243:6
[INFO] [stdout]     |
[INFO] [stdout] 243 |         if (count == 4) {
[INFO] [stdout]     |            ^          ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 243 -         if (count == 4) {
[INFO] [stdout] 243 +         if count == 4 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:250:5
[INFO] [stdout]     |
[INFO] [stdout] 250 |     if (comp_finished.len() > player_finished.len()) {
[INFO] [stdout]     |        ^                                           ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 250 -     if (comp_finished.len() > player_finished.len()) {
[INFO] [stdout] 250 +     if comp_finished.len() > player_finished.len() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: denote infinite loops with `loop { ... }`
[INFO] [stdout]    --> src/main.rs:271:2
[INFO] [stdout]     |
[INFO] [stdout] 271 |     while true {
[INFO] [stdout]     |     ^^^^^^^^^^ help: use `loop`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(while_true)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/main.rs:272:6
[INFO] [stdout]     |
[INFO] [stdout] 272 |         if (deck.is_empty() && player_hand.is_empty()) {
[INFO] [stdout]     |            ^                                         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 272 -         if (deck.is_empty() && player_hand.is_empty()) {
[INFO] [stdout] 272 +         if deck.is_empty() && player_hand.is_empty() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:135:25
[INFO] [stdout]     |
[INFO] [stdout] 135 |     let mut guess = buffer.trim_right().to_string();
[INFO] [stdout]     |                            ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 135 |     let mut guess = buffer.trim_end().to_string();
[INFO] [stdout]     |                            ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:143:18
[INFO] [stdout]     |
[INFO] [stdout] 143 |         guess = buffer.trim_right().to_string();
[INFO] [stdout]     |                        ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 143 |         guess = buffer.trim_end().to_string();
[INFO] [stdout]     |                        ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:146:21
[INFO] [stdout]     |
[INFO] [stdout] 146 |          &mut deck, guess.trim_right().to_string(), true);
[INFO] [stdout]     |                           ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 146 |          &mut deck, guess.trim_end().to_string(), true);
[INFO] [stdout]     |                           ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `core::str::<impl str>::trim_right`: superseded by `trim_end`
[INFO] [stdout]    --> src/main.rs:181:21
[INFO] [stdout]     |
[INFO] [stdout] 181 |          &mut deck, guess.trim_right().to_string(), false);    
[INFO] [stdout]     |                           ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]     |
[INFO] [stdout] 181 |          &mut deck, guess.trim_end().to_string(), false);    
[INFO] [stdout]     |                           ~~~~~~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/main.rs:35:12
[INFO] [stdout]    |
[INFO] [stdout] 35 | fn shuffle(mut cards: &mut Vec<String>) {
[INFO] [stdout]    |            ----^^^^^
[INFO] [stdout]    |            |
[INFO] [stdout]    |            help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `suite`
[INFO] [stdout]   --> src/main.rs:50:7
[INFO] [stdout]    |
[INFO] [stdout] 50 |         for suite in 0..NUM_SUITES {
[INFO] [stdout]    |             ^^^^^ help: if this is intentional, prefix it with an underscore: `_suite`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]   --> src/main.rs:95:6
[INFO] [stdout]    |
[INFO] [stdout] 95 |     for i in 0..NUM_HAND {
[INFO] [stdout]    |         ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/main.rs:133:6
[INFO] [stdout]     |
[INFO] [stdout] 133 |     let mut buffer = &mut String::new();
[INFO] [stdout]     |         ----^^^^^^
[INFO] [stdout]     |         |
[INFO] [stdout]     |         help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/main.rs:199:2
[INFO] [stdout]     |
[INFO] [stdout] 199 |     mut other_hand: &mut Vec<String>, mut deck: &mut Vec<String>, guess: String, is_player: bool) -> bool {
[INFO] [stdout]     |     ----^^^^^^^^^^
[INFO] [stdout]     |     |
[INFO] [stdout]     |     help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `ranks` should have an upper case name
[INFO] [stdout]   --> src/main.rs:28:7
[INFO] [stdout]    |
[INFO] [stdout] 28 | const ranks: [&'static str; NUM_RANKS as usize] = ["ace", "one", "two", "three", "four", "five", "six",
[INFO] [stdout]    |       ^^^^^ help: convert the identifier to upper case: `RANKS`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `Result` that must be used
[INFO] [stdout]    --> src/main.rs:134:2
[INFO] [stdout]     |
[INFO] [stdout] 134 |     std::io::stdin().read_line(buffer);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stdout]     = note: `#[warn(unused_must_use)]` on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]     |
[INFO] [stdout] 134 |     let _ = std::io::stdin().read_line(buffer);
[INFO] [stdout]     |     +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `Result` that must be used
[INFO] [stdout]    --> src/main.rs:142:6
[INFO] [stdout]     |
[INFO] [stdout] 142 |         std::io::stdin().read_line(buffer);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]     |
[INFO] [stdout] 142 |         let _ = std::io::stdin().read_line(buffer);
[INFO] [stdout]     |         +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `test` profile [unoptimized + debuginfo] target(s) in 0.16s
[INFO] running `Command { std: "docker" "inspect" "4e87839eefbd73184c60157a211739922e7ae32a05b3b5465f5110eccccec726", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "4e87839eefbd73184c60157a211739922e7ae32a05b3b5465f5110eccccec726", kill_on_drop: false }`
[INFO] [stdout] 4e87839eefbd73184c60157a211739922e7ae32a05b3b5465f5110eccccec726