[INFO] cloning repository https://github.com/AestheticIntegration/batsmt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AestheticIntegration/batsmt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAestheticIntegration%2Fbatsmt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAestheticIntegration%2Fbatsmt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b1eac8ce809bfee345bd8f4eb6aea2531db37ac7 [INFO] building AestheticIntegration/batsmt against master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order for pr-134523 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAestheticIntegration%2Fbatsmt" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AestheticIntegration/batsmt on toolchain 11663cd3bfefef7d34e8f0892c250bf698049392 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AestheticIntegration/batsmt [INFO] finished tweaking git repo https://github.com/AestheticIntegration/batsmt [INFO] tweaked toml for git repo https://github.com/AestheticIntegration/batsmt written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/AestheticIntegration/batsmt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-3-tc1/source/src/pretty/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/c-cube/batsat` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded log v0.4.6 [INFO] [stderr] Downloaded smallvec v0.6.9 [INFO] [stderr] Downloaded pretty v0.5.2 [INFO] [stderr] Downloaded tempfile v3.0.7 [INFO] [stderr] Downloaded byteorder v1.3.1 [INFO] [stderr] Downloaded rand_os v0.1.2 [INFO] [stderr] Downloaded rand_pcg v0.1.1 [INFO] [stderr] Downloaded remove_dir_all v0.5.1 [INFO] [stderr] Downloaded redox_syscall v0.1.51 [INFO] [stderr] Downloaded rand_jitter v0.1.3 [INFO] [stderr] Downloaded ucd-util v0.1.3 [INFO] [stderr] Downloaded lazy_static v1.2.0 [INFO] [stderr] Downloaded quick-error v1.2.2 [INFO] [stderr] Downloaded autocfg v0.1.2 [INFO] [stderr] Downloaded num-traits v0.2.6 [INFO] [stderr] Downloaded fnv v1.0.6 [INFO] [stderr] Downloaded rand v0.5.6 [INFO] [stderr] Downloaded bitflags v1.0.4 [INFO] [stderr] Downloaded rand_core v0.4.0 [INFO] [stderr] Downloaded regex-syntax v0.6.5 [INFO] [stderr] Downloaded libc v0.2.48 [INFO] [stderr] Downloaded winapi v0.3.6 [INFO] [stderr] Downloaded bit-vec v0.5.0 [INFO] [stderr] Downloaded bit-set v0.5.0 [INFO] [stderr] Downloaded rusty-fork v0.2.1 [INFO] [stderr] Downloaded typed-arena v1.4.1 [INFO] [stderr] Downloaded proptest v0.8.7 [INFO] [stderr] Downloaded colored v1.7.0 [INFO] [stderr] Downloaded wait-timeout v0.1.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b14a983fb73a06e5c48d7432f727d9957d6635184536ef7eb4fe98208a41925a [INFO] running `Command { std: "docker" "start" "-a" "b14a983fb73a06e5c48d7432f727d9957d6635184536ef7eb4fe98208a41925a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b14a983fb73a06e5c48d7432f727d9957d6635184536ef7eb4fe98208a41925a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b14a983fb73a06e5c48d7432f727d9957d6635184536ef7eb4fe98208a41925a", kill_on_drop: false }` [INFO] [stdout] b14a983fb73a06e5c48d7432f727d9957d6635184536ef7eb4fe98208a41925a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail-expr-drop-order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:f3a9d4ad9d972b27faf3965f35b62e55ba32bbce8f20bc8fe909558a86702fde" "/opt/rustwide/cargo-home/bin/cargo" "+11663cd3bfefef7d34e8f0892c250bf698049392" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f71d8a28e52722753f7c921ba48da46c0f1ddf32547ad08172f062ea1cc6adaf [INFO] running `Command { std: "docker" "start" "-a" "f71d8a28e52722753f7c921ba48da46c0f1ddf32547ad08172f062ea1cc6adaf", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/src/pretty/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling typed-arena v1.4.1 [INFO] [stderr] Compiling bit-vec v0.5.0 [INFO] [stderr] Compiling smallvec v0.6.9 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Compiling lazy_static v1.2.0 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Compiling colored v1.7.0 [INFO] [stderr] Compiling pretty v0.5.2 [INFO] [stderr] Compiling bit-set v0.5.0 [INFO] [stderr] Compiling batsat v0.3.1 (https://github.com/c-cube/batsat#3b91e4db) [INFO] [stderr] Compiling batsmt-logger v0.1.0 (/opt/rustwide/workdir/src/logger) [INFO] [stderr] Compiling batsmt-pretty v0.1.0 (/opt/rustwide/workdir/src/pretty) [INFO] [stderr] Compiling fxhash v0.2.1 [INFO] [stderr] Compiling batsmt-core v0.1.0 (/opt/rustwide/workdir/src/core) [INFO] [stderr] Compiling batsmt-parser v0.1.0 (/opt/rustwide/workdir/src/parser) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/parser/src/parser.rs:211:34 [INFO] [stdout] | [INFO] [stdout] 211 | let s: Atom = str.into();; // now convert to utf8 [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser/src/parser.rs:23:44 [INFO] [stdout] | [INFO] [stdout] 23 | pub type Result = result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub type Result = result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser/src/parser.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | fn cause(&self) -> Option<&error::Error> { None } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | fn cause(&self) -> Option<&dyn error::Error> { None } [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/parser/src/parser.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | fn mk_err(s: String) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 25 | fn mk_err(s: String) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/core/src/ast.rs:463:33 [INFO] [stdout] | [INFO] [stdout] 463 | while let Some(t) = $self.st.pop() { [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 480 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 495 | iter_impl!(self, m, t, f); [INFO] [stdout] | ------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `iter_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/core/src/ast.rs:463:33 [INFO] [stdout] | [INFO] [stdout] 463 | while let Some(t) = $self.st.pop() { [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 480 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 510 | iter_impl!(self, m, t, f); [INFO] [stdout] | ------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: this error originates in the macro `iter_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/core/src/ast.rs:604:38 [INFO] [stdout] | [INFO] [stdout] 604 | while let Some((ee,t)) = self.st.pop() { [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/core/src/ast.rs:750:36 [INFO] [stdout] | [INFO] [stdout] 750 | while let Some(task) = self.tasks.pop() { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `task` calls a custom destructor [INFO] [stdout] | `task` will be dropped later as of Edition 2024 [INFO] [stdout] 751 | match task { [INFO] [stdout] 752 | Task::Enter(t) => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 792 | let head = self.res.pop().unwrap(); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | `head` calls a custom destructor [INFO] [stdout] | `head` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Sub` instead of cloning the inner type [INFO] [stdout] --> src/core/src/ast.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | let f = &f.clone(); // separate pointer [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `batsmt-core` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f71d8a28e52722753f7c921ba48da46c0f1ddf32547ad08172f062ea1cc6adaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f71d8a28e52722753f7c921ba48da46c0f1ddf32547ad08172f062ea1cc6adaf", kill_on_drop: false }` [INFO] [stdout] f71d8a28e52722753f7c921ba48da46c0f1ddf32547ad08172f062ea1cc6adaf