[INFO] fetching crate zng-task 0.4.10... [INFO] checking zng-task-0.4.10 against try#da25749bf5e6ba5ed862ff361c19afff2a986b2d for pr-132712 [INFO] extracting crate zng-task 0.4.10 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate zng-task 0.4.10 on toolchain da25749bf5e6ba5ed862ff361c19afff2a986b2d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zng-task 0.4.10 [INFO] finished tweaking crates.io crate zng-task 0.4.10 [INFO] tweaked toml for crates.io crate zng-task 0.4.10 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 259 packages to latest compatible versions [INFO] [stderr] Adding fs4 v0.9.1 (available: v0.11.1) [INFO] [stderr] Adding http-cache-semantics v1.0.2 (available: v2.1.0) [INFO] [stderr] Adding http-serde v1.1.3 (available: v2.1.1) [INFO] [stderr] Adding linkme v0.3.28 (available: v0.3.29) [INFO] [stderr] Adding linkme-impl v0.3.28 (available: v0.3.29) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd5d707c636e533cc5540a862bd7acda391171ad6a9036c062d7982c459fed48 [INFO] running `Command { std: "docker" "start" "-a" "cd5d707c636e533cc5540a862bd7acda391171ad6a9036c062d7982c459fed48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd5d707c636e533cc5540a862bd7acda391171ad6a9036c062d7982c459fed48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd5d707c636e533cc5540a862bd7acda391171ad6a9036c062d7982c459fed48", kill_on_drop: false }` [INFO] [stdout] cd5d707c636e533cc5540a862bd7acda391171ad6a9036c062d7982c459fed48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=allow" "-e" "RUSTDOCFLAGS=--cap-lints=allow" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+da25749bf5e6ba5ed862ff361c19afff2a986b2d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 067fba626c317e95ec6cf13a65560e5f87ada4f9aaad9b3c274ee2fa02caf042 [INFO] running `Command { std: "docker" "start" "-a" "067fba626c317e95ec6cf13a65560e5f87ada4f9aaad9b3c274ee2fa02caf042", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Checking foldhash v0.1.3 [INFO] [stderr] Checking allocator-api2 v0.2.19 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling cpufeatures v0.2.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking fastrand v2.2.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling zng-app-context v0.5.12 [INFO] [stderr] Checking pretty-type-name v1.0.1 [INFO] [stderr] Compiling zng-var v0.5.9 [INFO] [stderr] Compiling zng-task v0.4.10 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking zng-clone-move v0.2.5 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking futures-lite v2.5.0 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking zng-handle v0.2.5 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling bytemuck_derive v1.8.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling linkme-impl v0.3.28 [INFO] [stderr] Compiling zng-var-proc-macros v0.2.8 [INFO] [stderr] Compiling zng-task-proc-macros v0.2.6 [INFO] [stderr] Checking linkme v0.3.28 [INFO] [stderr] Checking bytemuck v1.19.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking zng-txt v0.2.8 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking zng-unique-id v0.4.7 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking zng-state-map v0.3.7 [INFO] [stderr] Checking zng-unit v0.2.10 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Compiling zng-env-proc-macros v0.2.2 [INFO] [stderr] Checking zng-env v0.3.7 [INFO] [stderr] Checking zng-time v0.2.24 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/ui.rs (3 fixes) [INFO] [stderr] Fixed src/lib.rs (234 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:481:21 [INFO] [stdout] | [INFO] [stdout] 472 | let (sender, receiver) = channel::bounded(1); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | `receiver` calls a custom destructor [INFO] [stdout] | `receiver` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 481 | receiver.recv().await.unwrap() [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 482 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/flume-0.11.1/src/async.rs:481:1 [INFO] [stdout] | [INFO] [stdout] 481 | impl<'a, T> Drop for RecvFut<'a, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `receiver` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/flume-0.11.1/src/lib.rs:1016:1 [INFO] [stdout] | [INFO] [stdout] 1016 | impl Drop for Receiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/io.rs (2 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.00s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling zng-task v0.4.10 (/tmp/fixit) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `Command { std: "docker" "inspect" "067fba626c317e95ec6cf13a65560e5f87ada4f9aaad9b3c274ee2fa02caf042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "067fba626c317e95ec6cf13a65560e5f87ada4f9aaad9b3c274ee2fa02caf042", kill_on_drop: false }` [INFO] [stdout] 067fba626c317e95ec6cf13a65560e5f87ada4f9aaad9b3c274ee2fa02caf042